Page MenuHomePhabricator
Create Task
Maniphest T98032

Mobile page banner experiment is clashing with WikidataPageBanner
Closed, ResolvedPublic
Actions

Description

Screen_Shot_2015-05-04_at_6.29.23_PM.png (626×893 px, 700 KB)

This is just a tracking bug to make sure the mobile web deals with this before this is pushed to stable.

@Sumit you shouldn't need to do anything here... not yet anyway ;-)

Details

SubjectRepoBranchLines +/-
Tweaking WikidataPageBanner compatibilitymediawiki/extensions/MobileFrontendmaster+32 -7
Don't load our page banner when a wikidata page banner is registeredmediawiki/extensions/MobileFrontendmaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.May 4 2015, 5:29 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Wikidata-Page-Banner, Web-Team-Backlog.
Jdlrobson moved this task to In discussion on the Wikidata-Page-Banner board.
Jdlrobson added subscribers: Jdlrobson, Sumit.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2015, 5:29 PM
Jdlrobson added a subtask: T98029: Deploy PageBanner extension on English Wikivoyage project.May 4 2015, 5:29 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson set Security to None.
Jdlrobson updated the task description. (Show Details)
phuedx moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.May 5 2015, 1:50 PM
Jdlrobson moved this task from In discussion to June 26-July 18 on the Wikidata-Page-Banner board.Jun 5 2015, 10:54 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptJun 5 2015, 10:54 PM
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Jun 7 2015, 10:26 AM
Jdlrobson moved this task from June 26-July 18 to Backlog on the Wikidata-Page-Banner board.Jul 7 2015, 4:12 PM
Jdlrobson removed a subtask: T98029: Deploy PageBanner extension on English Wikivoyage project.Jul 7 2015, 4:40 PM
Jdlrobson added a parent task: T98145: [EPIC] Lead images (WikidataPageBanner integration) to stable.
phuedx added a parent task: T101108: Switch lead image in beta out for WikidataPageBanner.Aug 7 2015, 6:46 PM
gerritbot subscribed.Aug 18 2015, 12:13 AM

Change 232227 had a related patch set uploaded (by Jdlrobson):
Don't load our page banner when a wikidata page banner is registered

https://gerrit.wikimedia.org/r/232227

gerritbot added a project: Patch-For-Review.Aug 18 2015, 12:13 AM
gerritbot added a comment.Aug 21 2015, 12:12 AM

Change 232227 abandoned by Jdlrobson:
Don't load our page banner when a wikidata page banner is registered

Reason:
i missed cut off which was the original plan so let's do a better job. It's probably not too important..

https://gerrit.wikimedia.org/r/232227

Jdlrobson edited projects, added MobileFrontend; removed Web-Team-Backlog.Sep 3 2015, 4:53 PM
Jdlrobson triaged this task as High priority.Sep 4 2015, 5:34 PM

High now WIkivoyage is using it and has a beta.

gerritbot added a comment.Sep 16 2015, 12:29 AM

Change 238655 had a related patch set uploaded (by Jdlrobson):
Tweaking WikidataPageBanner compatibility

https://gerrit.wikimedia.org/r/238655

Jdlrobson claimed this task.Sep 16 2015, 12:31 AM
Jdlrobson moved this task from Backlog to Epics on the Wikidata-Page-Banner board.
gerritbot added a comment.Sep 17 2015, 10:05 PM

Change 238655 merged by jenkins-bot:
Tweaking WikidataPageBanner compatibility

https://gerrit.wikimedia.org/r/238655

• Konfused-Kitten mentioned this in rMEXT94b9e611c7bb: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 17 2015, 10:05 PM
• Konfused-Kitten mentioned this in rEMFR25979d6e63ae: Tweaking WikidataPageBanner compatibility.
Jdlrobson closed this task as Resolved.Sep 17 2015, 10:12 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 17 2015, 11:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits