Page MenuHomePhabricator

Mobile page banner experiment is clashing with WikidataPageBanner
Closed, ResolvedPublic

Description


This is just a tracking bug to make sure the mobile web deals with this before this is pushed to stable.

@Sumit you shouldn't need to do anything here... not yet anyway ;-)

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task to In discussion on the Wikidata-Page-Banner board.
Jdlrobson added subscribers: Jdlrobson, Sumit.

Change 232227 had a related patch set uploaded (by Jdlrobson):
Don't load our page banner when a wikidata page banner is registered

https://gerrit.wikimedia.org/r/232227

Change 232227 abandoned by Jdlrobson:
Don't load our page banner when a wikidata page banner is registered

Reason:
i missed cut off which was the original plan so let's do a better job. It's probably not too important..

https://gerrit.wikimedia.org/r/232227

High now WIkivoyage is using it and has a beta.

Change 238655 had a related patch set uploaded (by Jdlrobson):
Tweaking WikidataPageBanner compatibility

https://gerrit.wikimedia.org/r/238655

Change 238655 merged by jenkins-bot:
Tweaking WikidataPageBanner compatibility

https://gerrit.wikimedia.org/r/238655