Page MenuHomePhabricator

Switch lead image in beta out for WikidataPageBanner
Closed, ResolvedPublic

Description

  • The existing banner code in MobileFrontend should be removed
  • WikidataPageBanner should be used instead
  • WikidataPageBanner should be deployed on at all wiki projects, so it can be used for this substitution

Notes:

  • This should not impact any other skin other than mobile.

Related Objects

Event Timeline

phuedx raised the priority of this task from to Needs Triage.
phuedx updated the task description. (Show Details)
phuedx added a project: Readers-Web-Backlog.
phuedx added a subscriber: phuedx.

Not sure how this differs from T98145 ?
Also, it would be a good sensible idea to push this to a separate extension... Wikidata-Page-Banner perhaps?

T98145 tracks the high-level work, not the technical/implementation details.

So you are using the latter as a tracking card? Personally I find this confusing, especially given it's not an epic if it only has 1 card associated with it :) I'd advise merging them and using blocking cards for things that prevent us doing this to avoid confusion (you'll have to close both cards at the same time in current form right..?).

I notice you've added a couple of blocking tasks to T98145 but there was more than 1 to begin with… Am I looking at the wrong task?

basically in my mental model you have a card such as 'push the lead images to stable' and then you add blocking tasks to it which basically say 'this task cannot be done until the blocking tasks are carried out.' having a sub task 'push lead images to stable' just confuses me - as it suggests it can be done without the others being done as nothing blocks it.

That's my mental model any how.
So I would propose rewriting the description of T98145 to be this and dropping this card

If my mental model doesn't make sense we should at least rename the cards so they are less similar e.g. T98145 should have tracking in the title.

Jhernandez triaged this task as Medium priority.Aug 18 2015, 5:45 PM
Jhernandez added a subscriber: Jhernandez.
Jdlrobson renamed this task from Promote lead image from beta to stable to Switch lead image in beta out for WikidataPageBanner.Nov 3 2015, 8:08 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson set Security to None.
Jdlrobson moved this task from Epics to Team:Growth on the MobileFrontend board.

Change 251544 had a related patch set uploaded (by Jdlrobson):
Enable banners extension on mobile web beta only (enwiki)

https://gerrit.wikimedia.org/r/251544

Change 251544 merged by jenkins-bot:
Enable banners extension on mobile web beta only (enwiki)

https://gerrit.wikimedia.org/r/251544

Change 239018 had a related patch set uploaded (by Jdlrobson):
Use WikidataPageBanner instead of MobileFrontend specific code from banners

https://gerrit.wikimedia.org/r/239018

Change 257511 had a related patch set uploaded (by Jdlrobson):
Minerva should also be blacklisted

https://gerrit.wikimedia.org/r/257511

Change 257511 merged by jenkins-bot:
Minerva should also be blacklisted

https://gerrit.wikimedia.org/r/257511

Change 239018 merged by jenkins-bot:
Use WikidataPageBanner instead of MobileFrontend specific code from banners

https://gerrit.wikimedia.org/r/239018