Page MenuHomePhabricator
Create Task
Maniphest T98808

Beta: VE entry field looks broken
Closed, ResolvedPublic
Actions

Description

Looking at an entry field on en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow

The icons in the VE toolbar are higher in the box than they should be, and separated with gray lines. When focus is put in the entry field, the blue line doesn't fit the whole entry field. See attachments.

sad on beta.jpg (277×898 px, 53 KB)

more sad on beta.jpg (543×895 px, 90 KB)

Details

SubjectRepoBranchLines +/-
Fix VE toolbar styling to account for OOUI changesmediawiki/extensions/Flowmaster+4 -3
Customize query in gerrit

Related Objects

Event Timeline

• DannyH created this task.May 12 2015, 12:18 AM
• DannyH raised the priority of this task from to Unbreak Now!.
• DannyH updated the task description. (Show Details)
• DannyH added a project: Collaboration-Team-Sprint-B-2015-05-20.
• DannyH moved this task to Sprint B - ends May 27 on the Collaboration-Team-Sprint-B-2015-05-20 board.
• DannyH subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2015, 12:18 AM
Catrope subscribed.May 12 2015, 10:41 AM

This is a regression caused by changes in the OOUI toolbar, which were apparently breaking changes :(

Pginer-WMF subscribed.May 12 2015, 11:18 AM
gerritbot subscribed.May 12 2015, 11:36 AM

Change 210302 had a related patch set uploaded (by Catrope):
[WIP] Fix VE toolbar styling to account for OOUI changes

https://gerrit.wikimedia.org/r/210302

gerritbot added a project: Patch-For-Review.May 12 2015, 11:36 AM
Catrope moved this task from Sprint B - ends May 27 to Needs Review on the Collaboration-Team-Sprint-B-2015-05-20 board.May 12 2015, 11:57 AM
matmarex merged a task: T98783: betalabs: Misaligned VE icons .May 12 2015, 12:14 PM
matmarex added subscribers: Krenair, Etonkovidova.
gerritbot added a comment.May 12 2015, 12:55 PM

Change 210302 merged by jenkins-bot:
Fix VE toolbar styling to account for OOUI changes

https://gerrit.wikimedia.org/r/210302

Catrope mentioned this in rMEXT0ad7fbbb7cbb: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….May 12 2015, 12:55 PM
Catrope mentioned this in rEFLW88b34415fa0a: Fix VE toolbar styling to account for OOUI changes.
matthiasmullie moved this task from Needs Review to QA Review on the Collaboration-Team-Sprint-B-2015-05-20 board.May 12 2015, 2:01 PM
Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Sprint-B-2015-05-20 board.May 12 2015, 4:17 PM
Etonkovidova moved this task from Product Review to Done on the Collaboration-Team-Sprint-B-2015-05-20 board.
Etonkovidova moved this task from Done to Product Review on the Collaboration-Team-Sprint-B-2015-05-20 board.
• DannyH closed this task as Resolved.May 12 2015, 5:34 PM
• DannyH claimed this task.

Works on Beta, thanks

• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-B-2015-05-20 board.May 12 2015, 5:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL