Who to reproduce:
go to an article, click the "read in other languages menu"
get this list:
English and another English (Chinese) show in the list.
Matanya | |
May 21 2015, 11:21 PM |
F167689: Screenshot_2015-05-22-02-18-12.png | |
May 21 2015, 11:21 PM |
Who to reproduce:
go to an article, click the "read in other languages menu"
get this list:
English and another English (Chinese) show in the list.
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Fix article language picker for Chinese | apps/android/wikipedia | master | +667 -342 |
So, what's happening here is that when the adapter asks for the language code to convert to the local name, PageTitle.getSite().getLanguage() is returning plain old "zh" which doesn't exist in our resource list of languages anymore, so as a result the local language name is defaulting to "English."
The question is: what behavior do we want? Do we want to:
(a) Show separate entries for Simplified and Traditional Chinese?
(b) Show only one "smart" generic Chinese entry that leads to the correct variant based on the user preference?
(c) Have a generic Chinese entry *in addition to* specific Simplified and Traditional entries?
Any of these can be done in principle, but none of them is obvious to me (as a non-Chinese speaker) as being the correct way of doing things.
Adding @Niedzielski for comment since he worked on this stuff not too long ago and likely has insights.
Linking for reference: https://phabricator.wikimedia.org/T62743 (Special case Traditional and Simplified Chinese in all language handling)
I do note that the native Chinese speaker in that convo seemed to approve of how Mobile Frontend handles this:
https://phabricator.wikimedia.org/T62743#1123511
https://phabricator.wikimedia.org/T62743#1225501
@Niedzielski I was wondering if you'd be in a better position to handle this actually. Will reassign.
Change 217306 had a related patch set uploaded (by Niedzielski):
Fix article language picker for Chinese