Here's the patch https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/584646/

In T248710#6009665, @zeljkofilipin wrote:

@Aklapper I don't think this is resolved yet. @Gbahdeyboh still did not push a commit to mediawiki/core master branch.

https://gerrit.wikimedia.org/r/q/owner:gbahdeybohbello%2540gmail.com

Yes, looks a lot better now.

Hi @zeljkofilipin @Jpita and @Aklapper.

In T248710#6007287, @zeljkofilipin wrote:

In T248710#6007260, @Gbahdeyboh wrote:

I only cloned mediawiki/core once. And I cloned only the REL1_34 branch.

This is wrong. You should clone master branch. Instructions are here.

https://gerrit.wikimedia.org/r/admin/projects/mediawiki/core

I would suggest cloning via SSH. For me the command is:

git clone "ssh://zfilipin@gerrit.wikimedia.org:29418/mediawiki/core"

You'll have to replace zfilipin with your Gerrit username.

In T248710#6007272, @Reedy wrote:

Yeah, so you obviously didn't follow the right section of the "Download from Git" page, which has a "Download for development" section

I do note it's not exactly clear in the ordering, so it's definitely not your own fault

https://www.mediawiki.org/wiki/Download_from_Git#Download needs updating/re-arranging IMHO. Either the comment above git clone https://gerrit.wikimedia.org/r/mediawiki/core.git --branch REL1_34 mediawiki, or moving into its own section

You should either follow some instructions like on https://stackoverflow.com/questions/6802145/how-to-convert-a-git-shallow-clone-to-a-full-clone or else follow https://www.mediawiki.org/wiki/Download_from_Git#Download_for_development (which may be easier and prevent these weird errors)

You can create a patch of your commit from your git repo, and then apply it to the new clone.. Or use something like git review -x 584079 to cherry pick this commit onto your new master, or a branch you've created from master

git review -R gave that error in the branch I created and worked on REL1_34 branch

I'm pushing with git review -R

In T248710#6007262, @Reedy wrote:

I only cloned mediawiki/core once. And I cloned only the REL1_34 branch.

Did you do some sort of shallow clone? Otherwise that is not the case, you will have all branches locally...

What command are you using to "push"?

In T248710#6007218, @Aklapper wrote:

In T248710#6006838, @Gbahdeyboh wrote:

@Aklapper These are the commands I've ran so far...

That is very unlikely. I am very sure that you had to run git clone at some point.

In T248710#6006827, @Gbahdeyboh wrote:

22612d499e HEAD@{16}: clone: from https://gerrit.wikimedia.org/r/mediawiki/core.

clone: from https://gerrit.wikimedia.org/r/mediawiki/core. is not the same as
clone: from ssh://gbahdeyboh@gerrit.wikimedia.org:29418/mediawiki/core.git which I would have expected here.

It's my first time using gerrit and I'm still trying to get used to it 🙂

In T248710#6007171, @Reedy wrote:

In T248710#6006838, @Gbahdeyboh wrote:

I'm following the tutorial you shared, and git branch prints the name of my two branches REL1_34 and the one I created

It does look like you either ran a git checkout REL1_34 at some point, or you did a git clone that told it to check out REL1_34 at the same time. Then you created your branch ontop of REL1_34

Generally, you should be working from master

I've been able to create a simple test using puppeteer

@Jpita @zeljkofilipin. Can you kindly point me to a place where I can view a list of all projects that makes use of WebdriverIO as it's browser automation framework?

In T248710#6006625, @Gbahdeyboh wrote:

git checkout -b branch_name`
git add .
git commit -m "commit message"
git review -R

@Reedy I've only cloned master, and I'm in the current branch I am trying to push.

@Reedy I created a new branch and committed my changes to that branch, what I am trying to push is the branch I newly created

Hi @Aklapper, I'm sorry I sent in an incomplete proposal. I was still typing in a draft and mistakenly submitted it.

Hi @Jpita, I'd love to send you a DM on zulip. Do you mind sharing your username/name?

I've been able to Make a trivial change to tests/selenium/README.md file of mediawiki/core repository

In T247835#6000010, @Gaura87 wrote:

Hello, My name is gaurav and i am persuing my engineering in computer science department , and am looking for a part of gsoc 2020 . So i think this project is perfect , i know i am a bit late for all this,but i can give my best in remaining time. I worked on both Java script and Node js and had a good expirence.
So can anyone tell me how can i start contributing in this project or which micro task should i do.

I would be looking forward to hear from you

Thank You
Gaurav

I have been able to run Selenium tests on my machine and they all pass.

Wow! Thanks a lot, @kostajh and @zeljkofilipin. I really appreciate your help.

Yes, I have. Seen!

There are pictures in tests/selenium/log.

@zeljkofilipin Thanks.

Some of the errors I'm having is exactly the one stated here which was from a year or two ago.

In T248016#5997703, @AlQaholic007 wrote:

In T248016#5997697, @Gbahdeyboh wrote:

In T248016#5987725, @zeljkofilipin wrote:

In T248016#5986571, @Dinp2 wrote:

All tests are passing now, the issue was I did not have ffmpeg installed. Do you think it's a good idea to send a patch to update the "Linux Users" section of this file to mention the requirement to install ffmpeg?

It would be good to figure out the problem, but the solution is not to update that file. Could you please uninstall all dependencies that you've installed to get things running on your machine (like ffmpeg) and try again? Please create a task and copy/paste your entire terminal session into it, so I could see what went wrong.

I'm having the exact same issue he had @zeljkofilipin . Just one out of the 6 tests passes

What OS are you on?

In T248016#5987725, @zeljkofilipin wrote:

In T248016#5986571, @Dinp2 wrote:

All tests are passing now, the issue was I did not have ffmpeg installed. Do you think it's a good idea to send a patch to update the "Linux Users" section of this file to mention the requirement to install ffmpeg?

It would be good to figure out the problem, but the solution is not to update that file. Could you please uninstall all dependencies that you've installed to get things running on your machine (like ffmpeg) and try again? Please create a task and copy/paste your entire terminal session into it, so I could see what went wrong.

Thanks a lot @kostajh.

Thanks a lot @kostajh, It went through now. However, while I was installing the composer packages this error got logged

Yes, puppeteer supports firefox as well

I've been able to get chrome drivers working properly again, the problem I seem to have now is with docker.

I followed the steps here and setup docker using the steps here.