Gerrit change fixed.

@MarcoAurelio I just did a quick search over on translatewiki for "patrol", and can't seem to find any keys that would match this.

I am currently under a gerrit release for 2.2, awaiting feedback :)
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Patroller/+/536219/

This got pushed into the master branch as of this gerrit commit;
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Patroller/+/536142/

I am still supporting this extension actively :)

This got resolved already, sorry for the delay :P

Version 2.1.0 is now live.

There is now a patch that should resolve this issue.

Well there are other API parameters that could be classed as "expensive", since they don't call indexed columns. Surely it'd be classed as the same thing?

Hmm, I can see the issue with active indexing causing it to run slow. Still, surely it's implementable if it's flagged as an expensive call.

Patch above is half-complete, submitting fix on top which contains API field.

I suppose we could tag is as being an expensive call? Would still be nice to have the availability for it to be there.

Practical. A sortable table exists on one of my wikis, and is causing this issue currently. And yes, on a page using wikicode =]

Oh didn't notice that until now =] Thanks. And commit message updated.

Sadly, I do not have access to GIT at this time. If somebody else could ammend the commit message, that would be great (Y)

Can't do that using the patcher :(

-sigh- 3rd patch fixes all JSLint issues. Should do patches in future when not sleepy.

Woops, can somebody close that patch. Forgot a comma =]

I think it's best that a developer takes a look, since the code is hacky and could be majorly improved. =]

for ( i = len - 1; i >= 0; i-- ) {
	if ( $( $rows[ i ] ).children( 'td' ).length ) {
		break;
	}
	$tfoot.prepend( $( $rows[ i ] ) );
}

Changes to:

var tfootAdditions = [], rowspan, ii;
for ( i = len - 1; i >= 0; i-- ) {
	if ( $( $rows[ i ] ).children( 'td' ).length ) {
		rowspanNum = $( $rows[ i ] ).children( 'td' ).attr( 'rowspan' );
		if ( rowspan !== undefined ) {
			for ( ii = parseInt( rowspan ); ii < parseInt( rowspan ).length; ii++ ) {
				if ( tfootAdditions.indexOf( i + parseInt( rowspan ) ) !== -1 ) {
					tfootAdditions.splice( tfootAdditions.indexOf( i + parseInt( rowspan ) ) );
				}
			}
		}
		continue;
	}
	tfootAdditions.push( i );
}
for ( i = 0; i < tfootAdditions.length; i++ ) {
	$tfoot.prepend( $( $rows[ i ] ) );
}

@Krenair:

Should be resolved. :-)

https://gerrit.wikimedia.org/r/#/c/238002/ :-) Thought you might like

Should have it done by some time later today :) Weekends = personal projects time, so lots to do aha

@Aklapper aha I thought by the reply with the link, you was telling me to create my own ticket for this. My bad :)

Transferred to T112387 (Since presuming the author has to request it by @Aklapper's response)

I am intending to implement some more stuff regarding it to handle the loading better (and not through the API possibly). A single instance is fine :)

Surely if it's set to sysop-only, the protection dropdown should not appear?