User Details
- User Since
- May 3 2021, 6:53 AM (164 w, 3 d)
- Availability
- Available
- LDAP User
- Unknown
- MediaWiki User
- Martaannaj [ Global Accounts ]
Mar 2 2022
Aug 2 2021
Jul 31 2021
@Michaelcochez Should be fixed now, in the case where there are no properties already attributed to the entity the PropertySuggester would simply return a pre-set list, so the request duration would be 0 ms. This in turn would cause the line $this->requestDuration ?: -1 to replace the 0 by -1, causing the error.
@Michaelcochez can you give me an example of an entity where this happens? Because looking at https://wikidata.beta.wmflabs.org/wiki/Q86 (served by the PropertySuggester) the request duration gets logged nicely.
In the implementation, in the case where the call to the SchemaTreeRecommender times out the request gets handled by the PropertySuggester. In these cases the request duration gets logged as -1 to indicate that it was supposed to be handled by the SchemaTreeRecommender but something went wrong with the request so it ended up being executed by the PropertySuggester. Maybe this is what you see in the logs?
I think that what should be seen is one event log where the recommender used is the 'SchemaTreeRecommender' with the request duration of -1 and then another server side log for the same entity but with the recommender used 'PropertySuggester'
Jul 30 2021
Jul 28 2021
Jul 26 2021
It would still be required to test the event logging on beta right? And for that I believe that the schemas still need to be merged. If that gets done then I can make another patch for deploying the event logging streams to mediawiki-config. After that there should be nothing missing in order to proceed with test.wikidata.