Page MenuHomePhabricator
Create Task
Maniphest T100351

[QuestyCaptcha+ReCaptcha] typo in extension.json files
Closed, ResolvedPublic
Actions

Description

"config": {

		"CaptchaClass": "QuestyCaptcha",
		"CaptchaQuestions": [],                         <-- additional comma

}

This creates:
Fatal error: Uncaught exception 'Exception' with message '/var/www/web156/html/mediawiki/extensions/ConfirmEdit/QuestyCaptcha/extension.json is not a valid JSON file.' ...

Details

SubjectRepoBranchLines +/-
Fix extension.json filesmediawiki/extensions/ConfirmEditREL1_25+2 -2
Fix extension.json filesmediawiki/extensions/ConfirmEditmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Villpaul created this task.May 25 2015, 7:42 PM
Villpaul raised the priority of this task from to Needs Triage.
Villpaul updated the task description. (Show Details)
Villpaul added a project: ConfirmEdit (CAPTCHA extension).
Villpaul subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2015, 7:42 PM
Villpaul added a comment.May 25 2015, 7:44 PM

Forgot to add the version: mediawiki-1.25.0

Krenair triaged this task as Unbreak Now! priority.May 25 2015, 7:45 PM
Krenair subscribed.
gerritbot subscribed.May 25 2015, 7:47 PM

Change 213610 had a related patch set uploaded (by Alex Monk):
Fix extension.json files

https://gerrit.wikimedia.org/r/213610

gerritbot added a project: Patch-For-Review.May 25 2015, 7:47 PM
Krenair renamed this task from [QuestyCaptcha] typo in extension.json to [QuestyCaptcha+ReCaptcha] typo in extension.json files.May 25 2015, 7:49 PM
Krenair set Security to None.
Krenair added subscribers: Florian, Legoktm.
gerritbot added a comment.May 25 2015, 7:56 PM

Change 213610 merged by jenkins-bot:
Fix extension.json files

https://gerrit.wikimedia.org/r/213610

Krenair mentioned this in rECOEa9b8fcec0484: Fix extension.json files.May 25 2015, 7:56 PM
Krenair mentioned this in rMEXT69cb36c8d7e0: Updated mediawiki/extensions Project: mediawiki/extensions/ConfirmEdit….
gerritbot added a comment.May 25 2015, 7:56 PM

Change 213612 had a related patch set uploaded (by Alex Monk):
Fix extension.json files

https://gerrit.wikimedia.org/r/213612

gerritbot added a comment.May 25 2015, 8:00 PM

Change 213612 merged by jenkins-bot:
Fix extension.json files

https://gerrit.wikimedia.org/r/213612

Krenair mentioned this in rECOEb4a3cffce6e8: Fix extension.json files.May 25 2015, 8:00 PM
Legoktm added a project: MW-1.25-release.May 25 2015, 8:02 PM
Krenair added a subscriber: • demon.May 25 2015, 8:05 PM
Krenair added a project: Release-Engineering-Team.May 25 2015, 8:31 PM

This extension went out in the 1.25 tarball, we should try to get an update to that

Krenair mentioned this in T88047: Convert ConfirmEdit extension to use extension registration.May 25 2015, 8:48 PM
Krenair closed this task as Resolved.May 25 2015, 10:30 PM
Krenair claimed this task.
Krenair added a subscriber: • csteipp.

@csteipp and @Legoktm have done a release with the fix: https://lists.wikimedia.org/pipermail/mediawiki-announce/2015-May/000178.html

Legoktm mentioned this in T100599: make-release should run a syntax checker over the generated tarball.May 28 2015, 2:04 AM
Legoktm mentioned this in T100600: scap should lint JSON files.May 28 2015, 2:07 AM
Legoktm mentioned this in T100601: ConfirmEdit needs a jsontlint job.
Legoktm added a comment.May 28 2015, 2:09 AM

Follow up bugs to prevent this issue from happening again:

greg moved this task from INBOX to Done on the Release-Engineering-Team board.Jun 2 2015, 3:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL