Page MenuHomePhabricator
Create Task
Maniphest T88047

Convert ConfirmEdit extension to use extension registration
Closed, ResolvedPublic
Actions

Description

The ConfirmEdit extension needs to be converted to use the new extension registration system. More details are available on T87875.

Details

SubjectRepoBranchLines +/-
Remove PHP entry point and use extension.json for ConfirmEditmediawiki/extensions/ConfirmEditmaster+133 -208
Add extension.json, empty PHP entry pointmediawiki/extensions/ConfirmEditREL1_25+302 -221
Add extension.json, empty PHP entry pointmediawiki/extensions/ConfirmEditREL1_26+303 -221
Add extension.json, empty PHP entry pointmediawiki/extensions/ConfirmEditREL1_26+302 -221
Add extension.json, empty PHP entry pointmediawiki/extensions/ConfirmEditREL1_25+292 -221
Add extension.json, empty PHP entry pointmediawiki/extensions/ConfirmEditmaster+303 -223
Prepare and use ExtensionRegistration to install ConfirmEdit Captchasmediawiki/extensions/ConfirmEditmaster+527 -275
Move FancyCaptcha to its own locationmediawiki/extensions/ConfirmEditmaster+88 -122
Use extension.json and clear PHP entry point for MathCaptchamediawiki/extensions/ConfirmEditREL1_25+20 -19
Remove PHP entry point and use extension.json for QuestyCaptchamediawiki/extensions/ConfirmEditREL1_25+26 -45
Clear PHP entry point and use extension.json for ReCaptchamediawiki/extensions/ConfirmEditREL1_25+39 -61
Clear PHP entry point and use extension.json for ReCaptchamediawiki/extensions/ConfirmEditmaster+39 -61
Use extension.json and clear PHP entry point for MathCaptchamediawiki/extensions/ConfirmEditmaster+20 -19
Remove PHP entry point and use extension.json for QuestyCaptchamediawiki/extensions/ConfirmEditmaster+26 -45
Add extension.json and clear PHP entry pointmediawiki/extensions/ConfirmEditREL1_25+73 -85
Add extension.json and clear PHP entry pointmediawiki/extensions/ConfirmEditmaster+73 -85
Move QuestyCaptcha to its own placemediawiki/extensions/ConfirmEditREL1_25+49 -83
Move ReCaptcha to it's own placemediawiki/extensions/ConfirmEditREL1_25+64 -98
Move MathCaptcha to it's own placemediawiki/extensions/ConfirmEditREL1_25+23 -21
Move FancyCaptcha to its own locationmediawiki/extensions/ConfirmEditREL1_25+88 -122
Clean up ConfirmEdit.php entry point and move common files to common placesmediawiki/extensions/ConfirmEditREL1_25+48 -47
Move i18n to Captcha modules own directorymediawiki/extensions/ConfirmEditREL1_25+148 -63
Move QuestyCaptcha to its own placemediawiki/extensions/ConfirmEditmaster+49 -83
Move ReCaptcha to it's own placemediawiki/extensions/ConfirmEditmaster+64 -98
Move MathCaptcha to it's own placemediawiki/extensions/ConfirmEditmaster+23 -21
Clean up ConfirmEdit.php entry point and move common files to common placesmediawiki/extensions/ConfirmEditmaster+48 -47
Move i18n to Captcha modules own directorymediawiki/extensions/ConfirmEditmaster+23 -63
Show related patches Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNoneT87875 Convert all Wikimedia-deployed extensions and skins to use extension registration
ResolvedLegoktmT94758 Convert all skins and extensions bundled with the tarball to use extension registration
ResolvedPaladoxT88047 Convert ConfirmEdit extension to use extension registration
· · ·

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Diffusion mentioned this in rMEXTaa9ef3d2d9ae: Updated mediawiki/extensions Project: mediawiki/extensions/ConfirmEdit….May 23 2015, 8:01 AM
gerritbot added a comment.May 23 2015, 8:03 AM

Change 212571 merged by jenkins-bot:
Move QuestyCaptcha to its own place

https://gerrit.wikimedia.org/r/212571

ori mentioned this in rECOE2f0db346ebef: Move QuestyCaptcha to its own place.May 23 2015, 8:03 AM
Diffusion mentioned this in rMEXTe8701dd39469: Updated mediawiki/extensions Project: mediawiki/extensions/ConfirmEdit….May 23 2015, 8:03 AM
Florian mentioned this in rECOEe65a44abb124: Move i18n to Captcha modules own directory.May 23 2015, 8:09 AM
gerritbot added a comment.May 23 2015, 8:24 AM

Change 212844 had a related patch set uploaded (by Florianschmidtwelzow):
Move i18n to Captcha modules own directory

https://gerrit.wikimedia.org/r/212844

gerritbot added a comment.May 23 2015, 8:27 AM

Change 212844 merged by jenkins-bot:
Move i18n to Captcha modules own directory

https://gerrit.wikimedia.org/r/212844

Florian mentioned this in rECOE4d1dba36229e: Move i18n to Captcha modules own directory.May 23 2015, 8:28 AM
gerritbot added a comment.May 23 2015, 8:31 AM

Change 212845 had a related patch set uploaded (by Legoktm):
Clean up ConfirmEdit.php entry point and move common files to common places

https://gerrit.wikimedia.org/r/212845

gerritbot added a comment.May 23 2015, 8:31 AM

Change 212847 had a related patch set uploaded (by Legoktm):
Move FancyCaptcha to its own location

https://gerrit.wikimedia.org/r/212847

gerritbot added a comment.May 23 2015, 8:31 AM

Change 212848 had a related patch set uploaded (by Legoktm):
Move MathCaptcha to it's own place

https://gerrit.wikimedia.org/r/212848

gerritbot added a comment.May 23 2015, 8:31 AM

Change 212849 had a related patch set uploaded (by Legoktm):
Move ReCaptcha to it's own place

https://gerrit.wikimedia.org/r/212849

gerritbot added a comment.May 23 2015, 8:31 AM

Change 212851 had a related patch set uploaded (by Legoktm):
Move QuestyCaptcha to its own place

https://gerrit.wikimedia.org/r/212851

gerritbot added a comment.May 23 2015, 8:33 AM

Change 212845 merged by jenkins-bot:
Clean up ConfirmEdit.php entry point and move common files to common places

https://gerrit.wikimedia.org/r/212845

Legoktm mentioned this in rECOE1ddec5abfdc3: Clean up ConfirmEdit.php entry point and move common files to common places.May 23 2015, 8:33 AM
gerritbot added a comment.May 23 2015, 8:34 AM

Change 212847 merged by jenkins-bot:
Move FancyCaptcha to its own location

https://gerrit.wikimedia.org/r/212847

gerritbot added a comment.May 23 2015, 8:34 AM

Change 212848 merged by jenkins-bot:
Move MathCaptcha to it's own place

https://gerrit.wikimedia.org/r/212848

gerritbot added a comment.May 23 2015, 8:34 AM

Change 212849 merged by jenkins-bot:
Move ReCaptcha to it's own place

https://gerrit.wikimedia.org/r/212849

Legoktm mentioned this in rECOEe9892c0ff238: Move FancyCaptcha to its own location.May 23 2015, 8:34 AM
Legoktm mentioned this in rECOE0a9dd5b8e5c8: Move ReCaptcha to it's own place.
Legoktm mentioned this in rECOE34ef1670da6b: Move MathCaptcha to it's own place.
gerritbot added a comment.May 23 2015, 8:34 AM

Change 212851 merged by jenkins-bot:
Move QuestyCaptcha to its own place

https://gerrit.wikimedia.org/r/212851

Legoktm mentioned this in rECOEff3b5f10813d: Move QuestyCaptcha to its own place.May 23 2015, 8:34 AM
gerritbot added a comment.May 23 2015, 8:48 AM

Change 212853 had a related patch set uploaded (by Florianschmidtwelzow):
Add extension.json and clear PHP entry point

https://gerrit.wikimedia.org/r/212853

gerritbot added a comment.May 23 2015, 9:14 AM

Change 212853 merged by jenkins-bot:
Add extension.json and clear PHP entry point

https://gerrit.wikimedia.org/r/212853

Florian mentioned this in rECOEbf412aad280e: Add extension.json and clear PHP entry point.May 23 2015, 9:15 AM
Florian mentioned this in rMEXTabe5effa4516: Updated mediawiki/extensions Project: mediawiki/extensions/ConfirmEdit….
gerritbot added a comment.May 23 2015, 9:19 AM

Change 212860 had a related patch set uploaded (by Legoktm):
Add extension.json and clear PHP entry point

https://gerrit.wikimedia.org/r/212860

gerritbot added a comment.May 23 2015, 9:21 AM

Change 212860 merged by jenkins-bot:
Add extension.json and clear PHP entry point

https://gerrit.wikimedia.org/r/212860

Legoktm mentioned this in rECOE50c05db26b18: Add extension.json and clear PHP entry point.May 23 2015, 9:21 AM
gerritbot added a comment.May 23 2015, 9:21 AM

Change 212862 had a related patch set uploaded (by Florianschmidtwelzow):
Remove PHP entry point and use extension.json for QuestyCaptcha

https://gerrit.wikimedia.org/r/212862

gerritbot added a comment.May 23 2015, 9:25 AM

Change 212863 had a related patch set uploaded (by Florianschmidtwelzow):
Use extension.json and clear PHP entry point for MathCaptcha

https://gerrit.wikimedia.org/r/212863

gerritbot added a comment.May 23 2015, 9:34 AM

Change 212864 had a related patch set uploaded (by Florianschmidtwelzow):
Clear PHP entry point and use extension.json for ReCaptcha

https://gerrit.wikimedia.org/r/212864

Jdforrester-WMF closed subtask T88726: ConfirmEdit shouldn't have several entry points as Declined.May 23 2015, 12:22 PM
Jdforrester-WMF removed a subtask: T88726: ConfirmEdit shouldn't have several entry points.
gerritbot added a comment.May 23 2015, 12:48 PM

Change 212862 merged by jenkins-bot:
Remove PHP entry point and use extension.json for QuestyCaptcha

https://gerrit.wikimedia.org/r/212862

Florian mentioned this in rMEXT22802279c608: Updated mediawiki/extensions Project: mediawiki/extensions/ConfirmEdit….May 23 2015, 12:48 PM
Florian mentioned this in rECOE3cbbec45399d: Remove PHP entry point and use extension.json for QuestyCaptcha.
gerritbot added a comment.May 23 2015, 12:49 PM

Change 212863 merged by jenkins-bot:
Use extension.json and clear PHP entry point for MathCaptcha

https://gerrit.wikimedia.org/r/212863

Diffusion mentioned this in rMEXTfd6098a91eed: Updated mediawiki/extensions Project: mediawiki/extensions/ConfirmEdit….May 23 2015, 12:49 PM
Florian mentioned this in rECOE2d0be6432efd: Use extension.json and clear PHP entry point for MathCaptcha.May 23 2015, 12:49 PM
gerritbot added a comment.May 23 2015, 12:54 PM

Change 212864 merged by jenkins-bot:
Clear PHP entry point and use extension.json for ReCaptcha

https://gerrit.wikimedia.org/r/212864

Florian mentioned this in rECOEd7e46583ed29: Clear PHP entry point and use extension.json for ReCaptcha.May 23 2015, 12:54 PM
Diffusion mentioned this in rMEXTb652ae8c253b: Updated mediawiki/extensions Project: mediawiki/extensions/ConfirmEdit….May 23 2015, 12:55 PM
gerritbot added a comment.May 23 2015, 12:57 PM

Change 212904 had a related patch set uploaded (by Florianschmidtwelzow):
Remove PHP entry point and use extension.json for ConfirmEdit

https://gerrit.wikimedia.org/r/212904

gerritbot added a comment.May 23 2015, 1:15 PM

Change 212910 had a related patch set uploaded (by Legoktm):
Remove PHP entry point and use extension.json for QuestyCaptcha

https://gerrit.wikimedia.org/r/212910

gerritbot added a comment.May 23 2015, 1:15 PM

Change 212911 had a related patch set uploaded (by Legoktm):
Use extension.json and clear PHP entry point for MathCaptcha

https://gerrit.wikimedia.org/r/212911

gerritbot added a comment.May 23 2015, 1:15 PM

Change 212912 had a related patch set uploaded (by Legoktm):
Clear PHP entry point and use extension.json for ReCaptcha

https://gerrit.wikimedia.org/r/212912

gerritbot added a comment.May 23 2015, 1:23 PM

Change 212912 merged by jenkins-bot:
Clear PHP entry point and use extension.json for ReCaptcha

https://gerrit.wikimedia.org/r/212912

gerritbot added a comment.May 23 2015, 1:23 PM

Change 212910 merged by jenkins-bot:
Remove PHP entry point and use extension.json for QuestyCaptcha

https://gerrit.wikimedia.org/r/212910

gerritbot added a comment.May 23 2015, 1:24 PM

Change 212911 merged by jenkins-bot:
Use extension.json and clear PHP entry point for MathCaptcha

https://gerrit.wikimedia.org/r/212911

Legoktm mentioned this in rECOE023f24aa8a34: Clear PHP entry point and use extension.json for ReCaptcha.May 23 2015, 1:24 PM
Legoktm mentioned this in rECOE6c6a1da8b256: Remove PHP entry point and use extension.json for QuestyCaptcha.
Legoktm mentioned this in rECOEd916993fbea3: Use extension.json and clear PHP entry point for MathCaptcha.
Legoktm closed this task as Resolved.May 23 2015, 1:35 PM
Jdforrester-WMF added a project: WMF-deploy-2015-05-27_(1.26wmf8).May 23 2015, 2:22 PM
Liuxinyu970226 unsubscribed.May 24 2015, 1:03 AM
Krenair subscribed.May 25 2015, 8:48 PM

This broke the release: T100351: [QuestyCaptcha+ReCaptcha] typo in extension.json files

gerritbot added a comment.May 26 2015, 1:39 PM

Change 213825 had a related patch set uploaded (by Paladox):
Add extension.json, empty PHP entry point

https://gerrit.wikimedia.org/r/213825

Paladox removed a project: Patch-For-Review.May 26 2015, 3:35 PM
Paladox added a project: Patch-For-Review.
hashar mentioned this in T100839: Run test suites for all captcha types in ConfirmEdit.May 29 2015, 9:13 PM
Paladox reopened this task as Open.EditedJun 14 2015, 11:21 PM
Paladox subscribed.

Reopened since the main ConfirmEdit php entry point still hasn't been done it yet.

gerritbot added a comment.Jun 15 2015, 5:12 AM

Change 201499 abandoned by Legoktm:
Prepare and use ExtensionRegistration to install ConfirmEdit Captchas

https://gerrit.wikimedia.org/r/201499

Liuxinyu970226 subscribed.Jun 16 2015, 9:16 AM
Pennth subscribed.Sep 15 2015, 6:31 PM

While this patch is still in development, please note in the 1.25 changelog/readme that ConfirmEdit must be called using the old require_once syntax.

Attempting to use wfLoadExtension( 'ConfirmEdit' ) produces a showstopper from maintenance/update.php:

Fatal error: Uncaught exception 'Exception' with message '/home/wiki/web_docs/mediawiki-1.25.2/extensions/ConfirmEdit/extension.json does not exist!'
Paladox added a comment.Sep 15 2015, 7:08 PM

Hi I have a patch that is the final migration for extension.json and will fix your problem. Just need someone to review it.

Florian added a comment.Sep 15 2015, 7:22 PM
In T88047#1642513, @Pennth wrote:

While this patch is still in development, please note in the 1.25 changelog/readme that ConfirmEdit must be called using the old require_once syntax.

Attempting to use wfLoadExtension( 'ConfirmEdit' ) produces a showstopper from maintenance/update.php:

Fatal error: Uncaught exception 'Exception' with message '/home/wiki/web_docs/mediawiki-1.25.2/extensions/ConfirmEdit/extension.json does not exist!'

The Extension page is up-to-date and the installation method for ConfirmEdit is still mentioned in the Php style only. There are probably a lot of other extensions with the same problem, so the best idea would be to read the extension page before moving to extension registration. I think noting it in the changelog/readme of MediaWiki core would be a huge amount of work and notices about extensions (bundled or not) shouldn't be in the changelog/readme, in my opinion :)

Aklapper added a comment.Oct 5 2015, 12:14 PM

Looks like this is the only task left to also solve the tracking task T94758...

gerritbot added a comment.Oct 31 2015, 7:41 PM

Change 213825 merged by jenkins-bot:
Add extension.json, empty PHP entry point

https://gerrit.wikimedia.org/r/213825

Paladox closed this task as Resolved.Oct 31 2015, 7:45 PM
Paladox claimed this task.

Assigned to also Florian.

Paladox removed a project: ConfirmEdit (CAPTCHA extension).Oct 31 2015, 7:59 PM
Paladox removed a project: Patch-For-Review.
Paladox added a project: ConfirmEdit (CAPTCHA extension).
Paladox removed a subscriber: gerritbot.
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Oct 31 2015, 8:00 PM
gerritbot added a comment.Oct 31 2015, 9:30 PM

Change 250275 had a related patch set uploaded (by Florianschmidtwelzow):
Add extension.json, empty PHP entry point

https://gerrit.wikimedia.org/r/250275

gerritbot added a project: Patch-For-Review.Oct 31 2015, 9:30 PM

Change 250275 abandoned by Florianschmidtwelzow:
Add extension.json, empty PHP entry point

Reason:
really cool, cherry picking to REL1_26 and then pushing to REL1_25...

https://gerrit.wikimedia.org/r/250275

gerritbot added a comment.Oct 31 2015, 9:32 PM

Change 250276 had a related patch set uploaded (by Paladox):
Add extension.json, empty PHP entry point

https://gerrit.wikimedia.org/r/250276

gerritbot added a comment.Oct 31 2015, 9:35 PM

Change 250277 had a related patch set uploaded (by Florianschmidtwelzow):
Add extension.json, empty PHP entry point

https://gerrit.wikimedia.org/r/250277

gerritbot added a comment.Oct 31 2015, 9:40 PM

Change 250278 had a related patch set uploaded (by Paladox):
Add extension.json, empty PHP entry point

https://gerrit.wikimedia.org/r/250278

Reedy subscribed.Oct 31 2015, 9:45 PM

Why are we backporting things that aren't bugfixes?

gerritbot added a comment.Oct 31 2015, 9:54 PM

Change 250275 restored by Florianschmidtwelzow:
Add extension.json, empty PHP entry point

https://gerrit.wikimedia.org/r/250275

Liuxinyu970226 unsubscribed.Nov 1 2015, 12:04 AM
gerritbot added a comment.Nov 1 2015, 7:34 PM

Change 250278 abandoned by Paladox:
Add extension.json, empty PHP entry point

Reason:
Abandoning florian did the patches.

https://gerrit.wikimedia.org/r/250278

gerritbot added a comment.Nov 1 2015, 7:34 PM

Change 250276 abandoned by Paladox:
Add extension.json, empty PHP entry point

https://gerrit.wikimedia.org/r/250276

hashar mentioned this in T115392: MediaWiki 1.26 bundled repo should be state of the art.Nov 23 2015, 10:37 PM
gerritbot added a comment.Nov 25 2015, 3:58 PM

Change 250277 merged by jenkins-bot:
Add extension.json, empty PHP entry point

https://gerrit.wikimedia.org/r/250277

gerritbot added a comment.Feb 18 2016, 10:20 AM

Change 250275 merged by Hashar:
Add extension.json, empty PHP entry point

https://gerrit.wikimedia.org/r/250275

gerritbot added a comment.Mar 5 2016, 5:32 PM

Change 212904 abandoned by Florianschmidtwelzow:
Remove PHP entry point and use extension.json for ConfirmEdit

Reason:
oha, why is this change still alive? :D

https://gerrit.wikimedia.org/r/212904

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL