There's a good amount of code in MWTimestamp that is generally re-usable. Some methods are MW specific and probably shouldn't be in MWTimestamp to begin with...
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Legoktm | T100922 Create separate XMP parsing library | |||
| Resolved | Legoktm | T100924 Split MWTimestamp into a separate library |
Change 213355 had a related patch set uploaded (by Legoktm):
Move MWTimestamp::getHumanTimestamp() to Language
To be honest, I'm not exactly sure how useful this really is. MWTimestamp is just a wrapper around PHP's native Timestamp class, and the only additional non-MW-specific functionality it provides is a parser for a bunch of obscure timestamp formats.
Change 213355 merged by jenkins-bot:
Move MWTimestamp::getHumanTimestamp() to Language
Here's what I'm imagining the class/library would look like:
<?php namespace MediaWiki; class Timestamp { const UNIX = "..."; public function __construct( $input ) { $this->timestamp = $this->parseTimestamp( $input ); } /** * @param string $input * @return \DateTime * @throws SomeException */ private function parseTimestamp( $input ) { } /** * @param int $format A TS_ constant * @return string */ public function format( $format ) { } }
Thoughts?
Are we considering the idea of allowing callees to register new timestamp types, and have them associate a parser with that type? Or is the format list just something we're going to keep fixed?
Mhm, I agree. Just wanted to make sure. The interface you posted looks good. I'm assuming the intention is to make it a value object. Should we have transformation functions? Like ->add( Timestamp $other ), which returns a new Timestamp?
@aaron split out most of MWTimestamp into a generic ConvertibleTimestamp class in includes/libs!
We want https://gerrit.wikimedia.org/r/#/c/311881/ to land and then this can be moved into a separate repo/composer package
Change 312198 had a related patch set uploaded (by Legoktm):
Initial commit from MediaWiki core
Change 313682 had a related patch set uploaded (by Legoktm):
Add wikimedia/timestamp 1.0.0