Page MenuHomePhabricator
Create Task
Maniphest T100991

General code-review of WikidataQuality extension
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/WikibaseQuality

Related Objects
Search...

Event Timeline

Tobi_WMDE_SW created this task.Jun 1 2015, 3:47 PM
Tobi_WMDE_SW raised the priority of this task from to High.
Tobi_WMDE_SW updated the task description. (Show Details)
Tobi_WMDE_SW added projects: Wikidata, Wikibase-Quality.
Tobi_WMDE_SW added subscribers: Yair_rand, Liuxinyu970226, • mmodell and 8 others.
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Jun 1 2015, 3:50 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-06-02.Jun 3 2015, 9:30 AM
Tobi_WMDE_SW set Security to None.
Tobi_WMDE_SW edited a custom field.Jun 3 2015, 9:35 AM
JanZerebecki assigned this task to daniel.Jun 4 2015, 2:23 PM
JanZerebecki moved this task from Backlog to Doing on the Wikidata-Sprint-2015-06-02 board.
JanZerebecki subscribed.

@JanZerebecki TODO: try a build with the quality extensions.

gerritbot added a project: Patch-For-Review.Jun 4 2015, 2:31 PM
gerritbot subscribed.

Change 215897 had a related patch set uploaded (by Daniel Kinzler):
[DNM] Patch current master directly on top of blank repo.

https://gerrit.wikimedia.org/r/215897

Diffusion mentioned this in rMEXTf1ed25eb4881: Updated mediawiki/extensions Project: mediawiki/extensions/WikidataQuality….Jun 10 2015, 2:08 PM
Diffusion mentioned this in rEWQL553cc528bd20: Implemented hints from review from Daniel..
daniel moved this task from Doing to Review on the Wikidata-Sprint-2015-06-02 board.Jun 12 2015, 9:00 AM
JanZerebecki added a comment.Jun 12 2015, 5:07 PM
In T100991#1337514, @JanZerebecki wrote:

@JanZerebecki TODO: try a build with the quality extensions.

Done: Used https://github.com/wmde/WikidataBuildResources/pull/27 in vagrant without it blowing up, rendering an Item still works, they show up on Special:Version. Though didn't try to actually use them in any way.

gerritbot added a comment.Jun 15 2015, 10:54 AM

Change 218319 had a related patch set uploaded (by Soeren.oldag):
Implemented further hints from review from Daniel.

https://gerrit.wikimedia.org/r/218319

gerritbot added a comment.Jun 15 2015, 10:55 AM

Change 218320 had a related patch set uploaded (by Soeren.oldag):
Implemented further hints from review from Daniel

https://gerrit.wikimedia.org/r/218320

gerritbot added a comment.Jun 15 2015, 10:55 AM

Change 218321 had a related patch set uploaded (by Soeren.oldag):
Implemented further hints from review from Daniel.

https://gerrit.wikimedia.org/r/218321

gerritbot added a comment.Jun 15 2015, 12:00 PM

Change 218319 merged by Dominic.sauer:
Implemented further hints from review from Daniel.

https://gerrit.wikimedia.org/r/218319

dominic.sauer mentioned this in rMEXT58fd1c91405f: Updated mediawiki/extensions Project: mediawiki/extensions/WikidataQuality….Jun 15 2015, 12:01 PM
Diffusion mentioned this in rEWQL02e6eeb607fd: Implemented further hints from review from Daniel..Jun 15 2015, 12:01 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-06-16.Jun 16 2015, 1:24 PM
Tobi_WMDE_SW moved this task from Backlog to Review on the Wikidata-Sprint-2015-06-16 board.
JanZerebecki moved this task from Backlog to DOING on the Wikibase-Quality board.Jun 18 2015, 10:23 PM
Tamslo moved this task from DOING to Beyond our power on the Wikibase-Quality board.Jun 19 2015, 2:36 PM
Tamslo updated the task description. (Show Details)Jun 23 2015, 9:13 AM
Tamslo subscribed.Jun 23 2015, 9:19 AM

The URL of the repository changed, see the description.

Tobi_WMDE_SW moved this task from Review to Done on the Wikidata-Sprint-2015-06-16 board.Jun 24 2015, 10:07 AM
gerritbot added a comment.Jun 25 2015, 4:51 PM

Change 215897 abandoned by Daniel Kinzler:
[DNM] Patch current master directly on top of blank repo.

Reason:
done

https://gerrit.wikimedia.org/r/215897

Lydia_Pintscher moved this task from ready to go to consider for next sprint on the Wikidata board.Jun 26 2015, 11:21 AM
daniel closed this task as Resolved.Jun 26 2015, 11:29 AM
Liuxinyu970226 unsubscribed.Jun 27 2015, 10:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL