Page MenuHomePhabricator

Menu should not shift content in desktop mode
Closed, InvalidPublic3 Estimated Story Points

Description

opening the hamburger menu shouldn't shift the content left - the menu should come into the available white space

Screen Shot 2015-05-21 at 3.05.28 PM.png (599×755 px, 42 KB)

@Jdlrobson and @KHammerstein

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson subscribed.

Tests for visible menu on different widths please.

+1 to what Jhernandez said. I'd like to see some mock-ups. What should happen when there is no white space at all? Should the menu cover the content body, or should it shift it to the right (the current behavior)? ping Design, @KHammerstein.

@bmansurov and I talked over hangout about how this could work. We decided to resolve this for now as this wouldn't make sense on tablet sizes. We can come back to this later if we spend more time on fine-tuning the left menu.

There should be no need for mock ups unless I'm missing something.. it should just snap to the left when max width comes into play:

Screen Shot 2015-06-23 at 3.11.22 PM.png (683×635 px, 332 KB)

Screen Shot 2015-06-23 at 3.11.58 PM.png (480×796 px, 300 KB)

What kind of tests were you looking for @Jhernandez - since this is visual and solution is likely to be pure css I'm not sure how we'd do that...

@Jdlrobson those images make it a lot clearer. I thought we were going to have the menu floating over the left instead of pushing the content to the right and occupying 100% height.

In such a case testing such visual change is not worth the effort I would say.

Change 222039 had a related patch set uploaded (by Jdlrobson):
WIP: No whitespace to right of menu

https://gerrit.wikimedia.org/r/222039

I had a go at this... it wasnt' as easy as I thought. Someone should feel free to pick up the patch I am not going to work on for the time being.

Jdlrobson moved this task from Doing to To Do on the Reading-Web-Sprint-50-The-X-Files board.

Note that the problem appears when someone visits the site in mobile mode in a very wide screen. Tablets or smart phones don't have this problem. When I talked to @KHammerstein about it we came to a conclusion that this bug/feature could wait and doesn't need fixing as urgently as we think.

Playing around with this and talking to @KHammerstein - I think this needs a lot more thought and design input with demos / prototypes. There are far too many cases to think about and I think fundamentally with the max-width the idea of the hamburger menu seems broken (whilst in old design it felt like you were pulling something from the side now that's not the case).

@phuedx @Jhernandez:
Talking with @KHammerstein we think it would make sense to close this task as invalid and fold this work into an epic around the new header designs.

Change 222039 abandoned by Jdlrobson:
WIP: No whitespace to right of menu

https://gerrit.wikimedia.org/r/222039

@KHammerstein, @Jhernandez: I'm OK with @Jdlrobson's suggestion. Who's gonna create the epic(s)?

@KHammerstein can you create an epic regarding main menu UX and place it in
Web-Team-Backlog (Needs triage)? We'll prioritize it and backlog it.

When we have a response let's stall this task and link to the epic.