| • KHammerstein | |
| Apr 16 2015, 11:17 PM |
| F167567: Screen Shot 2015-05-21 at 3.05.28 PM.png | |
| May 21 2015, 2:04 PM |
| F115316: Screenshot_2015-04-16_16.13.49.png | |
| Apr 16 2015, 11:17 PM |
| F115318: header-04.png | |
| Apr 16 2015, 11:17 PM |
Minerva on desktop
Also,
T96332 Max width for special pages (watchlist, nearby)
T96327 Max-width for overlays (search, talk)
Currently the headers are full width on all devices. They should have a max-width of 893 to match the max-width of content, and to look more intentionally made for desktop.
The line will remain full width of screen
Current:
Design:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Alpha, Beta: Make the header center-aligned on tablet | mediawiki/extensions/MobileFrontend | master | +61 -4 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • rmoen | T101344 [EPIC] Push max-width and last modified work for mobile on desktop to stable | |||
| Resolved | • bmansurov | T96317 Give header a max-width so that it is more connected to content on tablet + desktop |
I'll double check the 893 px width. I thought the current max-width of the content was 1000 px.
@KHammerstein, the way our icons are implemented does not allow us to match your design easily. If you look at the first screenshot (current behavior), there is some space around the hamburger icon. In your proposed design though, there is no space on the left of the icon. Is that intentional?
@bmansurov Yes its intended that the hamburger icon left-align with the content below if possible
Change 210200 had a related patch set uploaded (by Bmansurov):
Make the header center-aligned similar to the content
Change 210200 merged by jenkins-bot:
Alpha, Beta: Make the header center-aligned on tablet
@kaity a few thoughts/feedback on this new design for you to muse over:
IIRC @KHammerstein signed this off at Wikimania-Hackathon-2015. I think we need to revisit @Jdlrobson's first point though.
@Jdlrobson
I agree, the menu shouldn't shift the content left. Should we create another task for that?