Page MenuHomePhabricator
Create Task
Maniphest T101344

[EPIC] Push max-width and last modified work for mobile on desktop to stable
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Please make sure all blockers are cleared first.
Because we are pushing max-width work to stable that includes setting a max-width to the background of the last edited bar, it will be simpler to have the location also at the bottom in stable.

See blocking tasks (T96317 T98385 T96327 T98925 ...)

Details

SubjectRepoBranchLines +/-
Push max-width work from beta to stablemediawiki/extensions/MobileFrontendmaster+75 -123
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
• KLans_WMF moved this task from 2015-16 Q3 to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.Jun 17 2015, 5:55 PM
dr0ptp4kt added subscribers: Jdlrobson, dr0ptp4kt.Jun 18 2015, 4:11 PM

@KHammerstein, @Jdlrobson - what's the estimated deployment date for that? Would you please drag this card on the Roadmap board to the estimated week/month?

phuedx added subscribers: • JKatzWMF, phuedx.Jun 18 2015, 4:47 PM

@JKatzWMF, @dr0ptp4kt: We're going to miss the estimated deployment date (June 15-19) because:

  1. of a few days spent tracking down and working around a critical bug in our server-side templating code, and
  2. the blockers that are listed right at the top of the card (see 1)
phuedx added a comment.Jun 18 2015, 4:48 PM

We'll update Roadmap after we've committed to the next sprint.

dr0ptp4kt added a comment.Jun 18 2015, 4:51 PM

Thanks, @phuedx!

Jdlrobson added a subtask: T101313: Alpha, beta: Max-width in mobile should apply to all pages.Jun 18 2015, 10:10 PM
phuedx added a subtask: T103076: Alpha, beta: Wider than before header and heading widths.Jun 19 2015, 2:29 PM
Jdlrobson added a comment.Jun 19 2015, 3:34 PM

Given that we've only just pushed this to beta, and should only merge a fix for this after next deploy cut off (Tuesday). @phuedx might be an idea to push this to next sprint?

phuedx added a comment.Jun 19 2015, 3:39 PM

Given the number of blockers, however small, I'm inclined to agree.

• KLans_WMF removed a project: Mobile-Web-Sprint-49-Wayne's-World.Jun 22 2015, 4:09 PM
• KLans_WMF moved this task from Old Unorganized Resolved Tasks to 2015-16 Q3 on the Web-Team-Backlog board.
• KLans_WMF added a project: Reading-Web-Sprint-50-The-X-Files.Jun 22 2015, 4:28 PM
• KLans_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-50-The-X-Files board.
Jdlrobson added a subtask: T101044: Menu should not shift content in desktop mode.Jun 22 2015, 4:35 PM
Jdlrobson renamed this task from Push max-width work for mobile on desktop to stable to Push max-width and last modified work for mobile on desktop to stable.Jun 22 2015, 4:53 PM
Jdlrobson merged a task: T103141: Last edited bar at moved from top to bottom of article to stable.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: • bmansurov.
• Jhernandez updated the task description. (Show Details)Jun 22 2015, 4:55 PM
• KLans_WMF edited a custom field.Jun 22 2015, 4:57 PM
• KLans_WMF removed a project: Reading-Web-Sprint-50-The-X-Files.Jun 22 2015, 5:01 PM
• Moushira subscribed.Jun 23 2015, 1:34 AM
phuedx mentioned this in T101313: Alpha, beta: Max-width in mobile should apply to all pages.Jun 25 2015, 1:24 PM
phuedx closed subtask T101313: Alpha, beta: Max-width in mobile should apply to all pages as Resolved.
greg subscribed.Jun 25 2015, 3:59 PM

ETA? This was in Roadmap for the week of June 15th.

phuedx moved this task from June 15-19 to Unscheduled on the Roadmap board.Jun 25 2015, 4:01 PM
phuedx added a comment.Jun 25 2015, 4:03 PM

Thanks for the ping @greg. I've moved this back to Unscheduled.

Jdforrester-WMF added a project: User-notice.Jun 29 2015, 10:38 PM
• KLans_WMF moved this task from 2015-16 Q3 to 2016-17 Q2 on the Web-Team-Backlog board.Jul 1 2015, 6:29 PM
Jdlrobson added a subtask: T104506: [beta, tablets] search within pages indent is broken.Jul 1 2015, 10:18 PM
phuedx closed subtask T104506: [beta, tablets] search within pages indent is broken as Resolved.Jul 2 2015, 12:06 PM
gpaumier removed a project: User-notice.Jul 2 2015, 8:16 PM
gpaumier moved this task from Triaged to Archive on the Notice board.Jul 2 2015, 8:20 PM
• bmansurov closed subtask T103076: Alpha, beta: Wider than before header and heading widths as Resolved.Jul 3 2015, 10:35 AM
phuedx renamed this task from Push max-width and last modified work for mobile on desktop to stable to [EPIC] Push max-width and last modified work for mobile on desktop to stable.Jul 3 2015, 11:33 AM
phuedx closed subtask T98925: Set the last edited bar max-width similar to T96317 as Resolved.
phuedx added a project: Epic.
phuedx edited a custom field.
phuedx mentioned this in T104697: [Stable] Move the last modified bar to the bottom of the page.Jul 3 2015, 11:38 AM
phuedx closed subtask T103024: Excessive margin in notifications overlay on tablets as Resolved.Jul 3 2015, 12:26 PM
phuedx closed subtask T101044: Menu should not shift content in desktop mode as Invalid.Jul 8 2015, 9:52 AM
Jdlrobson mentioned this in T107118: PointerOverlays have issues on larger screens.Aug 3 2015, 9:24 PM
Jdlrobson added a project: Reading-Web-Planning.
phuedx changed the status of subtask T103728: Diff not centered from Open to Stalled.Aug 5 2015, 10:17 AM
• Jhernandez triaged this task as High priority.Aug 5 2015, 10:47 AM
• Jhernandez removed a project: Web-Team-Backlog.
• Jhernandez moved this task from To classify to Sprint 54: 28 days later on the Reading-Web-Planning board.
• Jhernandez subscribed.
• Jhernandez moved this task from Sprint 54: 28 days later to Sprint 55: π on the Reading-Web-Planning board.Aug 7 2015, 3:29 PM
• Jhernandez moved this task from Sprint 55: π to Sprint 54: 28 days later on the Reading-Web-Planning board.
• Jhernandez changed the status of subtask T103728: Diff not centered from Stalled to Open.Aug 14 2015, 10:26 AM
• Jhernandez closed subtask T103728: Diff not centered as Resolved.
Florian closed subtask T103727: Empty message on watchlists is not center aligned. as Resolved.Aug 23 2015, 9:43 PM
Jdlrobson added a project: Reading-Web-Sprint-55-π.Sep 2 2015, 3:58 PM
Jdlrobson moved this task from Needs Analysis to Focus areas on the Reading-Web-Sprint-55-π board.
Jdlrobson moved this task from Focus areas to Needs Analysis on the Reading-Web-Sprint-55-π board.Sep 2 2015, 4:22 PM
Jdlrobson edited a custom field.Sep 2 2015, 4:24 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-55-π board.
• rmoen claimed this task.Sep 3 2015, 5:22 PM
• rmoen moved this task from To Do to Doing on the Reading-Web-Sprint-55-π board.
Jdlrobson added a comment.Sep 4 2015, 4:34 PM

@rmoen I had a first pass. Given the moving parts and given I reckon this will take at least 3 commits I'd like to suggest we try something different and do this in the dev branch so kaity and i can sign off before pushing out to users... thoughts team members?

Jdlrobson moved this task from Sprint 54: 28 days later to Sprint 55: π on the Reading-Web-Planning board.Sep 4 2015, 4:39 PM
• rmoen added a comment.Sep 4 2015, 4:51 PM

@Jdlrobson I can push to a dev branch

gerritbot subscribed.Sep 4 2015, 11:22 PM

Change 236226 had a related patch set uploaded (by Robmoen):
Push max-width work from beta to stable

https://gerrit.wikimedia.org/r/236226

gerritbot added a project: Patch-For-Review.Sep 4 2015, 11:22 PM
• rmoen moved this task from Doing to Code Review on the Reading-Web-Sprint-55-π board.Sep 4 2015, 11:23 PM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-55-π board.Sep 7 2015, 2:30 PM
phuedx moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-55-π board.
phuedx added a comment.Sep 7 2015, 3:33 PM

236226 is deployed to staging. Y'all can take a look at it here: http://reading-web-staging.wmflabs.org/

Jdlrobson added a comment.Sep 7 2015, 4:25 PM

Thanks @phuedx!!
@KHammerstein can you take a close look so we can aim to get this merged to roll out to users for 14th September?

• bmansurov added a comment.Sep 8 2015, 11:49 AM

The dependency needs some attention.

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-55-π board.Sep 8 2015, 5:15 PM

Commit message on https://gerrit.wikimedia.org/r/#/c/236191/2 needs fixing up.

• rmoen moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-55-π board.Sep 8 2015, 10:03 PM
phuedx added a comment.Sep 10 2015, 1:03 PM

T104697 needs attention.

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-55-π board.Sep 11 2015, 11:37 PM
Jdlrobson moved this task from Ready for Signoff to -1 (Needs More Work) on the Reading-Web-Sprint-55-π board.Sep 11 2015, 11:54 PM
gerritbot added a comment.Sep 12 2015, 12:23 AM

Change 236226 merged by jenkins-bot:
Push max-width work from beta to stable

https://gerrit.wikimedia.org/r/236226

• rmoen mentioned this in rMEXTe9284cbae49e: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 12 2015, 12:24 AM
• rmoen mentioned this in rEMFRef1ac4ae0644: Push max-width work from beta to stable.
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 12 2015, 1:00 AM
phuedx moved this task from -1 (Needs More Work) to Ready for Signoff on the Reading-Web-Sprint-55-π board.Sep 14 2015, 10:20 AM

@Jdlrobson: I've moved this into Ready for Signoff as both patches have been merged and I couldn't see anything left to do.

Jdlrobson added a comment.Sep 14 2015, 6:35 PM

Gonna wait till T112341 is resolved before signing off. I'm concerned it's impacting beta optin panel.

A small issue with EditWatchlist page which would be great to fix before shipping (cc @KHammerstein) :

Screen Shot 2015-09-14 at 11.22.38 AM.png (492×950 px, 67 KB)

• bmansurov added a comment.Sep 15 2015, 12:58 AM

T112341 is merged now.

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-55-π board.Sep 15 2015, 5:40 PM
Jdlrobson closed this task as Resolved.Sep 16 2015, 5:03 PM
Jdlrobson closed subtask T104697: [Stable] Move the last modified bar to the bottom of the page as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL