| • bmansurov | |
| Jun 3 2015, 9:16 PM |
| F182720: Screenshot 2015-06-23 14.33.06.png | |
| Jun 23 2015, 9:33 PM |
| F181246: Screenshot 2015-06-19 17.33.28.png | |
| Jun 20 2015, 12:37 AM |
| F180843: Screen Shot 2015-06-18 at 3.17.23 PM.png | |
| Jun 18 2015, 10:16 PM |
| F180844: Screen Shot 2015-06-18 at 3.17.18 PM.png | |
| Jun 18 2015, 10:16 PM |
| F178075: Screen Shot 2015-06-11 at 3.03.55 PM.png | |
| Jun 18 2015, 9:31 PM |
Currently, only Special:EditWatchlist is center aligned, Special:Watchlist isn't.
There are various other places where the centering doesn't quite work as expected
For example banners see screenshot:
Probably for that we need to add a new div containing all notices (siteNotice, localNotice, mw-dismissable-notice) and set a bottom border on that with a -1px margin, or we need to put the header inside another div that is full width and apply the border to that.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • rmoen | T101344 [EPIC] Push max-width and last modified work for mobile on desktop to stable | |||
| Resolved | Jdlrobson | T101313 Alpha, beta: Max-width in mobile should apply to all pages | |||
| Duplicate | Jdlrobson | T102190 Border separating header from banners is limited by max-width, but banners are not |
Change 218403 had a related patch set uploaded (by Bmansurov):
Alpha, beta: Give Special:Watchlist a max-width in mobile
Change 218781 had a related patch set uploaded (by Jdlrobson):
Generalise the desktop max width css
Change 218403 abandoned by Bmansurov:
Alpha, beta: Give Special:Watchlist a max-width in mobile
Reason:
https://gerrit.wikimedia.org/r/#/c/218781/ fixes the bug.
Before and after screenshots look identical to me and I'm not sure why they would not be since I've been careful to not change any of the rules:
Before:
@bmansurov please be a bit more descriptive and check it's not a caching problem.
I see. The bug I'm talking about has already been introduced in an earlier patch. I'll track it down and create a ticket for it. And I think your patch is good to be merged.
Otherwise it looks good. We might find more bugs, but should I sign off on this main work? @KLans_WMF
@Jdlrobson
I think we missed diff pages:
Should this block this task or should I create another?
@KHammerstein create a new task hopefully we can fix it in the sprint. From now we should work on a case by case basis.
@KHammerstein I made the tasks for you and put them as blocking tasks to push this to stable.
@KHammerstein: @Jdlrobson has opened a couple more tasks that block the parent task (T101344) – which should be an Epic by now – so I'm closing this as resolved.
