Page MenuHomePhabricator

Alpha, beta: Wider than before header and heading widths
Closed, ResolvedPublic

Description

Ic49206ec463b72b7c0285a84849ac0f5e08dbdf6 introduced a bug where the header and the heading of the page are wider than the rest of the page (banner images, page content). Should we apply border-box to those elements or should we make @contentMaxWidthTablet smaller?

Event Timeline

bmansurov raised the priority of this task from to Needs Triage.
bmansurov updated the task description. (Show Details)
bmansurov added a project: Readers-Web-Backlog.
bmansurov added a subscriber: bmansurov.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2015, 10:38 AM

Yeh because of T86366 now padding is included in the width calculation. Easiest thing to do would be to wrap all impacted elements with the view-border-box class. If these impact VisualEditor then something very wrong is happening, as VisualEditorOverlay should be added to the body tag not any of these.

Jdlrobson removed KHammerstein as the assignee of this task.

Is this still applicable or can this be folded into T86366 ?

bmansurov closed this task as Resolved.Jul 3 2015, 10:35 AM
bmansurov claimed this task.

Closing because the original patch has been reverted.

Restricted Application added a project: Readers-Web-Backlog. · View Herald TranscriptJul 3 2015, 10:39 AM