Using Tab as keyboard shortcut in Flow entry fields: the active "Reply" button and source/VE toggle is almost indistinguishable
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• DannyH
	Jun 2 2015, 10:19 PM

Description

Using tab as a keyboard shortcut to hit reply would be very helpful -- personally, that's my #1 way to save edits on wiki pages.

This does work in Flow entry fields, but the difference between an active Reply button and a non-active button is difficult to see with the naked eye. The same is true of the source/VE toggle in Chrome source view. (Tabbing to the toggle doesn't work at all in Firefox; in Chrome VE it's fine.)

Here are screenshots of the active and non-active Reply and toggle buttons in VE mode and source mode. It's really hard to tell the difference.

@Pginer-WMF, this is probably bigger than Flow because of UI standardization, but is there anything we can do to make the active state easier to see?

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T100844 Wikidata - Flow bugs and feature reqs (tracking)
		Resolved		• Prtksxna	T101184 Using Tab as keyboard shortcut in Flow entry fields: the active "Reply" button and source/VE toggle is almost indistinguishable

Event Timeline

• DannyH created this task.Jun 2 2015, 10:19 PM

• DannyH raised the priority of this task from to Medium.

• DannyH updated the task description. (Show Details)

• DannyH added projects: Collaboration-Team-Triage, StructuredDiscussions, Design.

• DannyH moved this task to Product/Design Work on the Collaboration-Team-Triage board.

• DannyH added subscribers: • DannyH, Pginer-WMF.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2015, 10:19 PM

• DannyH added a parent task: T100844: Wikidata - Flow bugs and feature reqs (tracking).Jun 2 2015, 10:20 PM

• DannyH renamed this task from Using Tab as keyboard shortcut in Flow entry fields: the active "Reply" button is almost indistinguishable to Using Tab as keyboard shortcut in Flow entry fields: the active "Reply" button and source/VE toggle is almost indistinguishable.Jun 2 2015, 10:25 PM

• DannyH updated the task description. (Show Details)

• DannyH set Security to None.

@Pginer-WMF, this is probably bigger than Flow because of UI standardization, but is there anything we can do to make the active state easier to see?

We should be using the standard buttons for consistency (and compatibility with future changes), but it is a good example for the UI-Standardization experts to evaluate the current status of button active state in practice.
Any thoughts @violetto, @Volker_E, @Prtksxna?

Pginer-WMF added a project: UI-Standardization.Jun 3 2015, 3:30 PM

Good news is that @Volker_E is on this for Mediawiki UI. The button specs can be found here. The buttons are already up to spec on OOJS UI.

Keyboard navigation to the "Reply" button is only possible in Chrome, I'm hoping other browsers support keyboard navigation soon.

I've noticed the pattern to submit a form is usually the combination of Command + Enter (on mac) or Ctrl + Enter (on windows). Sometimes in a text field, tabbing adds a tabbed space into the content.

Thanks @violetto for all the clarifications.

Updating these particular styles was blocked due to a few mixin patches. @Mattflaschen recently merged them, and I have updated the focus state. Here is the Patch-For-Review - https://gerrit.wikimedia.org/r/#/c/226060/.

There must be a tracking bug for these inconsistencies but I couldn't find it. Could someone please add it to the see also of this task? I'll update the commit message on Gerrit accordingly.

The patch should make the focus state look like this

Screen Shot 2015-07-21 at 4.46.14 PM.png (327×687 px, 46 KB)

Jdlrobson moved this task from Unsorted to Doing… on the UI-Standardization board.Jul 21 2015, 8:21 PM

• Prtksxna closed this task as Resolved.Jul 22 2015, 6:03 AM

• Prtksxna removed a project: Patch-For-Review.

• Prtksxna moved this task from Doing… to Done on the UI-Standardization board.

Quiddity moved this task from Product/Design Work to Resolved on the Collaboration-Team-Triage board.Jul 29 2015, 11:51 PM

Danny_B moved this task from Done to Unsorted on the UI-Standardization board.May 23 2016, 7:02 AM

	F203254: Screen Shot 2015-07-21 at 4.46.14 PM.png
	Jul 21 2015, 11:16 AM

	F173360: source inactive reply button.jpg
	Jun 2 2015, 10:19 PM

Using Tab as keyboard shortcut in Flow entry fields: the active "Reply" button and source/VE toggle is almost indistinguishableClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

Using Tab as keyboard shortcut in Flow entry fields: the active "Reply" button and source/VE toggle is almost indistinguishable
Closed, ResolvedPublic
Actions

Related Objects
Search...