It seems the Watchlist got broken by the continuation query changes. cc @Anomie
Request is being made to https://en.m.wikipedia.org/w/api.php?action=query&prop=pageimages%7Cinfo&piprop=thumbnail&pithumbsize=80&format=json&generator=watchlistraw&gwrnamespace=0&gwrlimit=51&continue=-%7C%7C which returns {"batchcomplete":""}
Implementator: please add a browser test to cover this.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T109277 [EPIC]: Use core watchlist code for mobile experience | |||
| Resolved | Jdlrobson | T94505 Infinite scrolling Special:EditWatchlist on mobile incorrectly identifies pages as not existing. | |||
| Resolved | Jdlrobson | T101453 Cannot see entire contents of Special:EditWatchlist |
It's a good question. I didn't look too deeply but this is the API request it is now making for some reason. Someone needs to investigate.
This seems like an embarrassing bug @Jhernandez that has been open far too long. Pull into sprint?
Change 229951 had a related patch set uploaded (by Bmansurov):
Show watchlist pages loaded via ajax
The API is still returning the wrong continue parameter (captured in T108384). The side effect of it is that there will be an extra AJAX request at the end of the getting the watchlist pages. But other than that everything is looking good.
Change 230558 had a related patch set uploaded (by Phuedx):
[WIP] Fix watchlist query continuation and rendering
Change 229951 abandoned by Bmansurov:
Show watchlist pages loaded via ajax
Reason:
see @phuedx's patch
Some follow up patches should be reviewed before signing off on this:
https://gerrit.wikimedia.org/r/#/c/230680/
https://gerrit.wikimedia.org/r/#/c/230681/
Change 230680 had a related patch set uploaded (by Jhernandez):
Follow up: Scrolled to pages that exist shouldn't show as red links
Change 230681 had a related patch set uploaded (by Jhernandez):
Hygiene: Remove unnecessary isLandscape calculation
Moving to Code review and reassigning to Jon who is the owner of the followup patches ⬆️
Change 230777 had a related patch set uploaded (by Phuedx):
Don't render "touched" watchlist pages as new
Change 230777 abandoned by Phuedx:
Don't render "touched" watchlist pages as new
Reason:
Jdlrobson's patch works for me now.
Change 230777 restored by Jdlrobson:
Don't render "touched" watchlist pages as new
Reason:
Test seems useful?
Change 230777 abandoned by Jdlrobson:
Don't render "touched" watchlist pages as new
Reason:
Folded test into https://gerrit.wikimedia.org/r/#/c/230680/2
Change 230680 merged by jenkins-bot:
Follow up: Scrolled to pages that exist shouldn't show as red links
Change 230681 abandoned by Jdlrobson:
Hygiene: Remove unnecessary isLandscape calculation
Reason:
Resolve later. The code is messier than I realised. Let's rely on the FIXMEs to fix this later.