Make Magnus tools on tools.wmflabs.org work in HTTPS
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bugreporter
	Jun 15 2015, 8:28 AM

Description

For example:
https://tools.wmflabs.org/magnustools/resources/js/common.js line 45

function httpsAlert ( id , b4 ) {
	if ( window.location.href.match ( /^https:/ ) ) {
		var url = window.location.href.replace ( /^https:/ , 'http:' ) ;
		var h = '<div id="https_alert" class="alert"><strong>Caveat :</strong> Using https on this page does not work in all browsers, due to downstream http dependencies. ' ;
		h += '<a href="' + url + '">Use http instead</a>.<a class="close" data-dismiss="alert" href="#">&times;</a></div>' ;
		if ( b4 ) $('#'+id).before ( h ) ;
		else $('#'+id).after ( h ) ;
		$('#https_alert').alert() ;
	}
}

Related Objects
Search...

Status	Assigned	Task
Resolved	• bd808	T131288 Make Cloud Services shared HTTP proxies enforce TLS
Resolved	• bd808	T102367 Migrate tools.wmflabs.org to https only (and set HSTS)
Resolved	Magnus	T102457 Make Magnus tools on tools.wmflabs.org work in HTTPS
Resolved	Milimetric	T44259 Make domas' pageviews data available in semi-publicly queryable database format
Resolved	Milimetric	T107056 Puppetize a server with a role that sets up Cassandra on Analytics machines [13 pts] {slug}
Resolved	Ottomata	T111053 Request three servers for Pageview API
Resolved	• mobrovac	T114742 restbase is not listening on port 7231 on aqs*

Event Timeline

Bugreporter created this task.Jun 15 2015, 8:28 AM

Bugreporter raised the priority of this task from to Needs Triage.

Bugreporter updated the task description. (Show Details)

Bugreporter added projects: HTTPS-by-default, Patch-For-Review, HTTPS, Toolforge.

Bugreporter added subscribers: Liuxinyu970226, gerritbot, jayvdb and 7 others.

Chmarkine subscribed.Jun 17 2015, 4:04 AM

In that case, specifically, the issue is that http://stats.grok.se/ is not available over https.

In T102457#1372886, @valhallasw wrote:

In that case, specifically, the issue is that http://stats.grok.se/ is not available over https.

Yep, that's a very well known issue and for that reason several Magnus tools NEED to be accessed over http.

I could add a proxy script on Labs, but my experience is that this does help neither speed nor reliability.

Restricted Application added a project: Cloud-Services. · View Herald TranscriptJun 23 2015, 9:27 AM

I could set up an 'official' NFS-independent https -> http proxy on tools (tools-https-proxy.wmflabs.org) that allows you to request https://tools-https-proxy.wmflabs.org/<URL> to proxy a URL.

I can also help the maintainer of stats.grok.de setup SSL, if so desired.

valhallasw triaged this task as Low priority.Jul 2 2015, 7:40 PM

valhallasw moved this task from Backlog to Ready to be worked on on the Toolforge board.

Bugreporter removed a project: Patch-For-Review.Jul 3 2015, 6:40 AM

Bugreporter set Security to None.

BBlack removed a project: HTTPS-by-default.Aug 7 2015, 4:16 PM

Ricordisamoa awarded a token.Dec 29 2015, 5:43 PM

Ricordisamoa subscribed.

Aklapper added a project: Traffic.Feb 23 2016, 6:12 PM

Restricted Application added a project: SRE. · View Herald TranscriptFeb 23 2016, 6:12 PM

In T102457#1391885, @yuvipanda wrote:

I can also help the maintainer of stats.grok.de setup SSL, if so desired.

Or maybe Magnus' tool should use the new Page View API instead of http://stats.grok.se.

In T102457#2072902, @Krinkle wrote:

Or maybe Magnus' tool should use the new Page View API instead of http://stats.grok.se.

He already does and he *also* has a proxy, working with URLs such as https://tools.wmflabs.org/glamtools/proxy.php?url=http%3A%2F%2Fstats.grok.se%2Fjson%2Fit%2F201601%2FMathieu%2520La%2520Porte (test with https://tools.wmflabs.org/glamtools/treeviews/?q=%7B%22lang%22%3A%22it%22%2C%22pagepile%22%3A%22492%22%2C%22rows%22%3A%5B%5D%7D ).

This bug is fixed as regards Magnus tools, I think; and it's probably too generic for the whole of Tool Labs. Maybe just close?

In T102457#2073490, @Nemo_bis wrote:

This bug is fixed as regards Magnus tools, I think; and it's probably too generic for the whole of Tool Labs. Maybe just close?

Use as a tracking ticket. Make subtasks for individual tools who are still http-only.?

In T102457#2073493, @Dzahn wrote:

Use as a tracking ticket. Make subtasks for individual tools who are still http-only.?

We need a list first, for a serious tracking bug. I filed T128409 for now.

Nemo_bis renamed this task from Fix all http-only tools in tools.wmflabs.org to Make Magnus tools on tools.wmflabs.org work in HTTPS.Feb 29 2016, 8:51 PM

Nemo_bis closed this task as Resolved.

Nemo_bis assigned this task to Magnus.

Nemo_bis added a subtask: T44259: Make domas' pageviews data available in semi-publicly queryable database format.

Liuxinyu970226 unsubscribed.Mar 2 2016, 11:14 AM

Just FYI, treeviews is now completely https (the last remaining http element was the tree image...)
https://tools.wmflabs.org/glamtools/treeviews/

Dzahn awarded a token.Mar 10 2016, 7:31 PM

zhuyifei1999 mentioned this in T128409: Detect tools.wmflabs.org tools which are HTTP-only.Jan 29 2017, 2:58 PM

• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:50 PM