Page MenuHomePhabricator
Create Task
Maniphest T103610

Use mediawiki.RegExp on Popups instead of deprecated "escapeRE"
Closed, ResolvedPublic
Actions

Description

I get many copies of

Use of "escapeRE" is deprecated. Use mediawiki.RegExp instead.

on
https://www.mediawiki.org/w/index.php?search=%22jquery.mwExtension%22&title=Special%3ASearch&go=Go&debug=1

It comes from this line:

titleRegex = new RegExp( $.escapeRE( mw.config.get( 'wgArticlePath' ) )

https://github.com/wikimedia/mediawiki-extensions-Popups/blob/2c0b4f842e6a97078755785a9e43c81e2d6d0c69/resources/ext.popups.core.js#L186

Details

SubjectRepoBranchLines +/-
Replace 'jquery.mwExtension' by 'mediawiki.RegExp'mediawiki/extensions/Popupsmaster+2 -2
Replace 'jquery.mwExtension' by 'mediawiki.RegExp'mediawiki/extensions/Popupswmf/1.26wmf11+2 -2
Customize query in gerrit

Related Objects

Event Timeline

He7d3r created this task.Jun 23 2015, 9:42 PM
He7d3r raised the priority of this task from to Needs Triage.
He7d3r updated the task description. (Show Details)
He7d3r added projects: Page-Previews, JavaScript, Technical-Debt.
He7d3r subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2015, 9:42 PM
Ricordisamoa subscribed.Jun 23 2015, 9:51 PM
He7d3r set Security to None.Jun 23 2015, 10:18 PM
He7d3r added a subscriber: ori.
Quiddity moved this task from Backlog to Next Up on the Page-Previews board.Jun 23 2015, 10:33 PM
Krenair subscribed.Jun 23 2015, 10:41 PM
He7d3r added a project: good first task.Jun 24 2015, 3:12 PM
gerritbot subscribed.Jun 26 2015, 7:48 AM

Change 221060 had a related patch set uploaded (by Gerrit Patch Uploader):
Replace 'jquery.mwExtension' by 'mediawiki.RegExp'

https://gerrit.wikimedia.org/r/221060

gerritbot added a project: Patch-For-Review.Jun 26 2015, 7:48 AM
Fomafix mentioned this in T103891: Deployment of jquery.mwExtension being marked as deprecated crashes scripts.Jun 26 2015, 7:49 AM
gerritbot added a comment.Jun 26 2015, 7:53 AM

Change 221060 merged by jenkins-bot:
Replace 'jquery.mwExtension' by 'mediawiki.RegExp'

https://gerrit.wikimedia.org/r/221060

Fomafix mentioned this in rEPOP7713e343fefe: Replace 'jquery.mwExtension' by 'mediawiki.RegExp'.Jun 26 2015, 7:53 AM
Fomafix mentioned this in rMEXT1d7c567d1a1f: Updated mediawiki/extensions Project: mediawiki/extensions/Popups….
gerritbot added a comment.Jun 26 2015, 7:54 AM

Change 221061 had a related patch set uploaded (by Krinkle):
Replace 'jquery.mwExtension' by 'mediawiki.RegExp'

https://gerrit.wikimedia.org/r/221061

gerritbot added a comment.Jun 26 2015, 7:55 AM

Change 221061 merged by jenkins-bot:
Replace 'jquery.mwExtension' by 'mediawiki.RegExp'

https://gerrit.wikimedia.org/r/221061

Krinkle mentioned this in rEPOP073486caf745: Replace 'jquery.mwExtension' by 'mediawiki.RegExp'.Jun 26 2015, 7:55 AM
Fomafix mentioned this in rMW75e6be3b84af: Updated mediawiki/core Project: mediawiki/extensions/Popups….Jun 26 2015, 7:55 AM
Krinkle closed this task as Resolved.Jun 26 2015, 7:59 AM
Krinkle claimed this task.
Krinkle triaged this task as High priority.
• Forrestbot added projects: WMF-deploy-2015-06-23_(1.26wmf11), WMF-deploy-2015-06-30_(1.26wmf12).Jun 26 2015, 8:00 AM
• Forrestbot subscribed.
Ricordisamoa removed a project: Patch-For-Review.Jun 26 2015, 12:25 PM
matmarex mentioned this in rMW8dbab8945c6e: mediawiki.log: Remove call to console.trace() for each warning.Jun 27 2015, 12:49 PM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
Aklapper mentioned this in T105261: "TypeError: $.escapeRE is not a function" on many WMF wikis.Jul 9 2015, 12:53 PM
nshahquinn-wmf moved this task from Next Up to Done on the Page-Previews board.Jul 16 2015, 10:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits