Page MenuHomePhabricator

Use mediawiki.RegExp on Popups instead of deprecated "escapeRE"
Closed, ResolvedPublic

Description

I get many copies of

Use of "escapeRE" is deprecated. Use mediawiki.RegExp instead.

on
https://www.mediawiki.org/w/index.php?search=%22jquery.mwExtension%22&title=Special%3ASearch&go=Go&debug=1

It comes from this line:

titleRegex = new RegExp( $.escapeRE( mw.config.get( 'wgArticlePath' ) )

https://github.com/wikimedia/mediawiki-extensions-Popups/blob/2c0b4f842e6a97078755785a9e43c81e2d6d0c69/resources/ext.popups.core.js#L186

Event Timeline

He7d3r created this task.Jun 23 2015, 9:42 PM
He7d3r updated the task description. (Show Details)
He7d3r raised the priority of this task from to Needs Triage.
He7d3r added a subscriber: He7d3r.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2015, 9:42 PM
He7d3r set Security to None.Jun 23 2015, 10:18 PM
He7d3r added a subscriber: ori.
Quiddity moved this task from Backlog to Next Up on the Page-Previews board.Jun 23 2015, 10:33 PM

Change 221060 had a related patch set uploaded (by Gerrit Patch Uploader):
Replace 'jquery.mwExtension' by 'mediawiki.RegExp'

https://gerrit.wikimedia.org/r/221060

Change 221060 merged by jenkins-bot:
Replace 'jquery.mwExtension' by 'mediawiki.RegExp'

https://gerrit.wikimedia.org/r/221060

Change 221061 had a related patch set uploaded (by Krinkle):
Replace 'jquery.mwExtension' by 'mediawiki.RegExp'

https://gerrit.wikimedia.org/r/221061

Change 221061 merged by jenkins-bot:
Replace 'jquery.mwExtension' by 'mediawiki.RegExp'

https://gerrit.wikimedia.org/r/221061

Krinkle closed this task as Resolved.Jun 26 2015, 7:59 AM
Krinkle claimed this task.
Krinkle triaged this task as High priority.