Copy-and-pasting a reference between VE surfaces causes a Parsoid 500 error
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Steps to reproduce

Open https://en.wikipedia.org/wiki/User:Neil_P._Quinn-WMF/Parsoid_500_a?veaction=edit and https://en.wikipedia.org/wiki/User:Neil_P._Quinn-WMF/Parsoid_500_b?veaction=edit.
Copy and paste the reference from surface b into surface a.
The auto-generated <references /> block now displays "2. This reference is defined in a template or other generated block, and for now can only be edited in source mode." instead of the reference text.
Try reviewing your changes (or saving). The save dialog returns the error "Could not start the review because your revision matches the latest version of this page."
Add something between the two references, like a space or an X or a line break.
Try reviewing your changes (or saving). Parsoid now returns a 500 error.

Browsers

Occurs in Firefox and Safari, but not Chrome.

Details

	Subject	Repo	Branch	Lines +/-
	Never use original data optimisation when in clipboard mode	mediawiki/extensions/VisualEditor	wmf/1.26wmf13	+44 -4
	Never use original data optimisation when in clipboard mode	mediawiki/extensions/VisualEditor	master	+44 -4

Customize query in gerrit

Related Objects

Mentioned In: T100136: Cannot save page edits due to parsoidserver-http: HTTP 500 in Chinese Wikipedia when using Visual Editor
rEVED043e8ea314a8: Never use original data optimisation when in clipboard mode
rEVEDaeedd808cd6a: Never use original data optimisation when in clipboard mode

Event Timeline

nshahquinn-wmf created this task.Jun 29 2015, 6:25 PM

nshahquinn-wmf raised the priority of this task from to High.

nshahquinn-wmf updated the task description. (Show Details)

nshahquinn-wmf added projects: Parsoid, VisualEditor-MediaWiki-References.

nshahquinn-wmf subscribed.

Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 29 2015, 6:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

It breaks as described above in Firefox. On Chromium, the formatting looks odd (the pasted reference being bigger than the original one) but there is no lack of detected changes if the references are adjacent, and no Parsoid error if the references are separated by an 'X'.

nshahquinn-wmf renamed this task from Copy-and-pasting a reference between VE surfaces causes a Parsoid 500 error. to Copy-and-pasting a reference between VE surfaces in Firefox causes a Parsoid 500 error..Jun 29 2015, 6:38 PM

nshahquinn-wmf added a project: Browser-Support-Firefox.

nshahquinn-wmf set Security to None.

nshahquinn-wmf renamed this task from Copy-and-pasting a reference between VE surfaces in Firefox causes a Parsoid 500 error. to Copy-and-pasting a reference between VE surfaces causes a Parsoid 500 error..Jun 29 2015, 6:45 PM

nshahquinn-wmf updated the task description. (Show Details)

nshahquinn-wmf removed a project: Browser-Support-Firefox.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Jun 29 2015, 6:58 PM

I don't notice anything blatantly weird in the paste buffer. Ed?

nshahquinn-wmf added a project: VisualEditor 2015/16 Q1 blockers.Jun 30 2015, 7:22 PM

Jdforrester-WMF moved this task from Nominated to Backlog: T0 on the VisualEditor 2015/16 Q1 blockers board.Jun 30 2015, 7:23 PM

Jdforrester-WMF edited a custom field.Jul 3 2015, 5:48 PM

Jdforrester-WMF renamed this task from Copy-and-pasting a reference between VE surfaces causes a Parsoid 500 error. to Copy-and-pasting a reference between VE surfaces causes a Parsoid 500 error.Jul 3 2015, 5:50 PM

Arlolra moved this task from Needs Triage to Non-Parsing-Team Tasks on the Parsoid board.Jul 7 2015, 3:18 AM

There is no reference body, just an id. We need to tell the converter to never use originalDomElements if the HTML is for the clipboard.

Change 223770 had a related patch set uploaded (by Esanders):
Never use orignal data optimisation when in clipboard mode

https://gerrit.wikimedia.org/r/223770

gerritbot added a project: Patch-For-Review.Jul 9 2015, 12:40 PM

Change 224172 had a related patch set uploaded (by Jforrester):
Never use original data optimisation when in clipboard mode

https://gerrit.wikimedia.org/r/224172

Change 223770 merged by jenkins-bot:
Never use original data optimisation when in clipboard mode

https://gerrit.wikimedia.org/r/223770

Catrope mentioned this in rEVEDaeedd808cd6a: Never use original data optimisation when in clipboard mode.Jul 10 2015, 7:50 PM

• Forrestbot added a project: WMF-deploy-2015-07-14_(1.26wmf14).Jul 10 2015, 8:00 PM

Change 224172 merged by jenkins-bot:
Never use original data optimisation when in clipboard mode

https://gerrit.wikimedia.org/r/224172

Jdforrester-WMF mentioned this in rEVED043e8ea314a8: Never use original data optimisation when in clipboard mode.Jul 13 2015, 11:03 PM

Jdforrester-WMF closed this task as Resolved.Jul 13 2015, 11:28 PM

Jdforrester-WMF assigned this task to Esanders.

Jdforrester-WMF edited projects, added WMF-deploy-2015-07-07_(1.26wmf13); removed Patch-For-Review.

Jdforrester-WMF moved this task from Backlog: T0 to Done on the VisualEditor 2015/16 Q1 blockers board.Jul 16 2015, 1:37 PM

Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:29 PM

Jdforrester-WMF mentioned this in T100136: Cannot save page edits due to parsoidserver-http: HTTP 500 in Chinese Wikipedia when using Visual Editor.Aug 1 2015, 10:27 PM

Copy-and-pasting a reference between VE surfaces causes a Parsoid 500 errorClosed, ResolvedPublic8 Estimated Story PointsActions