Page MenuHomePhabricator
Create Task
Maniphest T105848

GlobalCollect is not recurring: something wrong with "batch mode" in DonatioinInterface
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

We should fix this in a small number of days, because stale recurring charges are not cool.

00:00:12  WD recurring_globalcollect: Processing recurring charge: 14908          [notice]
00:00:12  array_key_exists() expects parameter 2 to be array, null given       [warning]
00:00:12  DonationData.php:184
00:00:12  array_key_exists() expects parameter 2 to be array, null given       [warning]
00:00:12  gateway.adapter.php:3548
00:00:12  array_key_exists() expects parameter 2 to be array, null given       [warning]
00:00:12  gateway.adapter.php:3543
00:00:12  Invalid argument supplied for foreach() DataValidator.php:483        [warning]
00:00:12  WD wmf_common: UNKNOWN Batch processing aborted: Not implemented     [error]
00:00:12  Source: stdClass::__set_state(array(
....
00:00:12     'trxn_id' => 'RECURRING GLOBALCOLLECT 7794677174',

Details

SubjectRepoBranchLines +/-
Better success check for recurring globalcollectwikimedia/fundraising/crmmaster+18 -18
Stop exceptioning in drupal formatMessage stubmediawiki/extensions/DonationInterfacemaster+2 -4
Fix recurring GC false success reportmediawiki/extensions/DonationInterfacemaster+100 -50
Quit demoting log messages to debug under drupalmediawiki/extensions/DonationInterfacemaster+6 -4
PHPUnit test for DonationInterface::createAdapterwikimedia/fundraising/crmmaster+34 -0
Update recurring GC for DonationInterface changeswikimedia/fundraising/crmmaster+14 -23
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Jul 15 2015, 12:45 AM
awight raised the priority of this task from to Unbreak Now!.
awight updated the task description. (Show Details)
awight added projects: Unplanned-Sprint-Work, Fundraising Sprint ODB, Fundraising-Backlog-Old, Wikimedia-Fundraising-CiviCRM.
awight added subscribers: awight, MBeat33.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2015, 12:45 AM
awight added a comment.Jul 15 2015, 12:52 AM

Breadcrumb: The only place this message can come from is a call to either WmfFramework::formatMessage or ::getLanguageCode.

• atgo subscribed.Jul 15 2015, 3:48 AM

@awight could this be related to T105041?

• DStrine added a project: Fundraising-Backlog.Jul 15 2015, 4:14 PM
• DStrine set Security to None.
• atgo added a project: Recurring-Donations.Jul 15 2015, 4:48 PM
• atgo moved this task from Triage to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint ODB board.Jul 16 2015, 12:22 AM
Ejegg subscribed.Jul 16 2015, 12:26 AM

The changes I deployed yesterday included an update to the donation interface composer package, and I failed to appreciate how big a version jump that made. The way our civi module uses the GlobalCollect adapter is no longer correct. We need at a minimum to set a new global variable and update the code for the changed return type of do_transaction.

Ejegg claimed this task.Jul 16 2015, 12:26 AM
gerritbot subscribed.Jul 16 2015, 12:44 AM

Change 224986 had a related patch set uploaded (by Ejegg):
Update recurring GC for DonationInterface changes

https://gerrit.wikimedia.org/r/224986

gerritbot added a project: Patch-For-Review.Jul 16 2015, 12:44 AM
gerritbot added a comment.Jul 16 2015, 1:12 AM

Change 224991 had a related patch set uploaded (by Ejegg):
PHPUnit test for DonationInterface::createAdapter

https://gerrit.wikimedia.org/r/224991

Ejegg moved this task from Doing to Review on the Fundraising Sprint ODB board.Jul 16 2015, 1:13 AM
gerritbot added a comment.Jul 16 2015, 4:05 PM

Change 224986 merged by jenkins-bot:
Update recurring GC for DonationInterface changes

https://gerrit.wikimedia.org/r/224986

Ejegg mentioned this in rWFCGe6b353239758: Update recurring GC for DonationInterface changes.Jul 16 2015, 4:05 PM
gerritbot added a comment.Jul 16 2015, 4:06 PM

Change 224991 merged by jenkins-bot:
PHPUnit test for DonationInterface::createAdapter

https://gerrit.wikimedia.org/r/224991

Ejegg mentioned this in rWFCGbf7ae1ce0c7b: PHPUnit test for DonationInterface::createAdapter.Jul 16 2015, 4:07 PM
gerritbot added a comment.Jul 16 2015, 10:35 PM

Change 225257 had a related patch set uploaded (by Ejegg):
Quit demoting log messages to debug under drupal

https://gerrit.wikimedia.org/r/225257

gerritbot added a comment.Jul 16 2015, 10:51 PM

Change 225261 had a related patch set uploaded (by Ejegg):
Better success check for recurring globalcollect

https://gerrit.wikimedia.org/r/225261

gerritbot added a comment.Jul 16 2015, 11:10 PM

Change 225265 had a related patch set uploaded (by Ejegg):
WIP: Fix recurring GC false success report

https://gerrit.wikimedia.org/r/225265

gerritbot added a comment.Jul 17 2015, 5:38 PM

Change 225257 merged by jenkins-bot:
Quit demoting log messages to debug under drupal

https://gerrit.wikimedia.org/r/225257

Diffusion mentioned this in rMEXTb7389c59d584: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Jul 17 2015, 5:38 PM
Ejegg mentioned this in rEDOI854204f73dcf: Quit demoting log messages to debug under drupal.Jul 17 2015, 5:39 PM
gerritbot added a comment.Jul 17 2015, 10:39 PM

Change 225508 had a related patch set uploaded (by Ejegg):
Stop exceptioning in drupal formatMessage stub

https://gerrit.wikimedia.org/r/225508

gerritbot added a comment.Jul 17 2015, 11:21 PM

Change 225265 merged by jenkins-bot:
Fix recurring GC false success report

https://gerrit.wikimedia.org/r/225265

Ejegg mentioned this in rEDOIee8b70331470: Fix recurring GC false success report.Jul 17 2015, 11:22 PM
Ejegg mentioned this in rMEXTf050c8845876: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….
gerritbot added a comment.Jul 17 2015, 11:25 PM

Change 225508 merged by jenkins-bot:
Stop exceptioning in drupal formatMessage stub

https://gerrit.wikimedia.org/r/225508

Ejegg mentioned this in rEDOI899be810fa33: Stop exceptioning in drupal formatMessage stub.Jul 17 2015, 11:25 PM
Ejegg mentioned this in rMEXT1c23640c8c2a: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….
Ejegg moved this task from Review to Done on the Fundraising Sprint ODB board.Jul 18 2015, 1:09 AM
Ejegg added a comment.Jul 18 2015, 1:17 AM

Fixed!

Set all 'in-process' records back to appropriate status (failed for those with recent failure retry dates, success for the other 1) after determining that none of them could actually have been charged.

Job is re-enabled and batch size is back to 250.

Note: logs for a rgc job run are 18MB each, now that we have all the DonationInterface messages hitting drupal correctly. We could make the log level added in rWFCG94728d configurable on the module settings page if we want a higher threshold for DI messages than for other watchdog messages.

Ejegg closed this task as Resolved.Jul 18 2015, 1:19 AM
gerritbot added a comment.Jul 23 2015, 7:16 AM

Change 225261 merged by Awight:
Better success check for recurring globalcollect

https://gerrit.wikimedia.org/r/225261

awight mentioned this in rWFCG04822e78e84e: Better success check for recurring globalcollect.Jul 23 2015, 7:17 AM
• DStrine edited a custom field.Aug 14 2015, 8:29 PM
• DStrine removed a project: Unplanned-Sprint-Work.Aug 20 2015, 4:53 PM
• atgo unsubscribed.Mar 30 2016, 10:03 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:44 PM
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJun 22 2017, 9:44 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits