Page MenuHomePhabricator

Search input field height is too small
Closed, ResolvedPublic

Description

Search input field looks tall but the real input field inside of it is not very high. We found that in some languages (e.g. Tamil) some text got cropped because od this.

The padding of the search bar element and the input field size should be adjusted so that the search bar is visually the same but the inner input field is higher.

Event Timeline

Pginer-WMF raised the priority of this task from to Needs Triage.
Pginer-WMF updated the task description. (Show Details)
Pginer-WMF added subscribers: santhosh, Nirzar, Aklapper and 2 others.
santhosh triaged this task as Normal priority.
santhosh set Security to None.

Change 224974 had a related patch set uploaded (by Santhosh):
Make the height of search input field same as its container

https://gerrit.wikimedia.org/r/224974

I cannot reproduce the problem. I pasted Tamil text into the search box and it looked OK. I'd expect the screenshot to show the problem, but actually it shows a DOM inspector.

That screenshot shows the problem with padding. Here is a better screenshot showing text being cut in search field

OK, that's convincing enough. Maybe it's different in my browser.

Change 224974 merged by jenkins-bot:
Make the height of search input field same as its container

https://gerrit.wikimedia.org/r/224974

Amire80 closed this task as Resolved.Jul 16 2015, 3:53 AM