Page MenuHomePhabricator

MediaViewer does not work on transcluded user page
Open, LowPublic

Description

MediaViewer only loads on pages which have some images (by checking OutpuPage::getFileSearchOptions() in BeforePageDisplay); that does not work with transcluded user pages. example

Event Timeline

Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added projects: MediaViewer, GlobalUsage.
Tgr subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr set Security to None.

@Legoktm is there a nice way to check if we are on a transcluded userpage? Also, can that page contain an image that's local to Meta?

Tgr added a subscriber: Pine.

@Legoktm is there a nice way to check if we are on a transcluded userpage? Also, can that page contain an image that's local to Meta?

GlobalUserPage::shouldDisplayGlobalPage. Yes, it can.

We could make MV always load on transcluded user pages. It would break on images local to Meta as the imageinfo API is probably not aware of those at all, but that should be rare enough as uploads to Meta are discouraged (there was one file uploaded so far this year, and maybe a dozen in 2014).

Change 228751 had a related patch set uploaded (by Gergő Tisza):
[WIP] Always enable on global user pages

https://gerrit.wikimedia.org/r/228751

Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team.

Jdlrobson changed the task status from Open to Stalled.Sep 24 2015, 12:35 AM
Jdlrobson subscribed.

Patch is still -1ed and a WIP. Is this becoming worked on still?

Not at the moment but planning to. The way I understood Kunal's comment on the patch is that this needs t be fixed in GlobalUserPage, not MediaViewer. I started writing a patch for that but then got distracted.

Change 228751 abandoned by Gergő Tisza:
[WIP] Always enable on global user pages

Reason:
Per Legoktm, probably not the right direction to go.

https://gerrit.wikimedia.org/r/228751

Aklapper changed the task status from Stalled to Open.Nov 1 2020, 10:00 PM

Anyone can rebase / improve a patch, hence resetting stalled status.