Page MenuHomePhabricator
Create Task
Maniphest T107363

Astropay errors should be red text and not popup
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Like in T86214 on the GC forms

Sign off: @atgo

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use helper callback to render Mustache errorsmediawiki/extensions/DonationInterfacemaster+95 -56
Replace alert with red errors for Mustache formsmediawiki/extensions/DonationInterfacemaster+185 -104
DRY up validate_personalmediawiki/extensions/DonationInterfacemaster+48 -49
Customize query in gerrit

Related Objects
Search...

Event Timeline

• atgo created this task.Jul 29 2015, 10:39 PM
• atgo raised the priority of this task from to Medium.
• atgo updated the task description. (Show Details)
• atgo added projects: [DO NOT USE] Astropay [superseded by #FR-Astropay], Fundraising-Backlog.
• atgo subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2015, 10:39 PM
• atgo moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Jul 29 2015, 10:39 PM
• DStrine set Security to None.Jul 29 2015, 10:42 PM
• DStrine edited a custom field.
• atgo updated the task description. (Show Details)Aug 5 2015, 6:06 PM
• atgo moved this task from Sprint +1 to Q3 2021-2022 on the Fundraising-Backlog board.Aug 12 2015, 10:27 PM
• atgo moved this task from Q3 2021-2022 to FY 2022-2023 on the Fundraising-Backlog board.
• atgo added a parent task: T102143: [epic] Processing via Astropay for Spanish-speaking LATAM countries.Aug 14 2015, 5:35 PM
awight added a project: good first task.Oct 9 2015, 2:58 PM
• DStrine added a project: FR-dlocal.Dec 14 2015, 7:15 PM
• atgo unsubscribed.Mar 30 2016, 10:06 PM
gerritbot subscribed.Apr 21 2016, 4:37 AM

Change 284627 had a related patch set uploaded (by Ejegg):
DRY up validate_personal

https://gerrit.wikimedia.org/r/284627

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 21 2016, 4:37 AM
gerritbot added a project: Patch-For-Review.Apr 21 2016, 4:37 AM
gerritbot added a comment.Apr 21 2016, 11:29 PM

Change 284835 had a related patch set uploaded (by Ejegg):
WIP inline errors for mustache

https://gerrit.wikimedia.org/r/284835

Ejegg claimed this task.Apr 22 2016, 1:51 PM
Ejegg added projects: Unplanned-Sprint-Work, Fundraising Sprint Hermit Crab Husbandry.
Ejegg changed the point value for this task from 1 to 2.
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Hermit Crab Husbandry board.
Ejegg added a subscriber: • atgo.
• DStrine moved this task from FY 2022-2023 to Current Sprint & Completed in Q4 1516 on the Fundraising-Backlog board.Apr 22 2016, 3:51 PM
gerritbot added a comment.Apr 22 2016, 4:04 PM

Change 284911 had a related patch set uploaded (by Ejegg):
Red errors for Mustache forms using callback

https://gerrit.wikimedia.org/r/284911

gerritbot added a comment.Apr 22 2016, 5:00 PM

Change 284627 merged by jenkins-bot:
DRY up validate_personal

https://gerrit.wikimedia.org/r/284627

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)).Apr 22 2016, 5:00 PM
gerritbot added a comment.Apr 22 2016, 5:14 PM

Change 284835 merged by jenkins-bot:
Replace alert with red errors for Mustache forms

https://gerrit.wikimedia.org/r/284835

gerritbot added a comment.Apr 22 2016, 6:17 PM

Change 284911 merged by jenkins-bot:
Use helper callback to render Mustache errors

https://gerrit.wikimedia.org/r/284911

• atgo unsubscribed.Apr 22 2016, 6:19 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Hermit Crab Husbandry board.Apr 22 2016, 7:02 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Hermit Crab Husbandry board.Apr 26 2016, 4:29 PM
Ejegg closed this task as Resolved.Apr 27 2016, 10:01 PM
Ejegg added a subscriber: • atgo.
• DStrine removed a project: Unplanned-Sprint-Work.Apr 28 2016, 10:46 PM
• Phabricator_maintenance removed a project: [DO NOT USE] Astropay [superseded by #FR-Astropay].Aug 10 2016, 11:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits