Page MenuHomePhabricator
Create Task
Maniphest T107655

When accessing talk page through echo, the yellow "new message" notification doesn't go away until the next page view
Closed, ResolvedPublic
Actions

Description

This is a problem I have noticed on Wikipedia since about 2-3 weeks ago.

When I have a new message on my talk page, I see a red number in the Echo notification area as well as a yellow reminder. When I open the Echo notification list and click on the item about my new message I will be directed to my talk page. The Echo notification number changes to zero (as desired) but the yellow message does not go away (not desired). See screenshot from Fa WP.

Fa WP Echo Bug.png (32×201 px, 9 KB)

If I got to any other page, that yellow message is gone. It is only on the first visit to my User Talk page that it remains there.

Details

SubjectRepoBranchLines +/-
Don't show orange alert if you are viewing your user talk pagemediawiki/extensions/Echomaster+9 -1
Customize query in gerrit

Related Objects

Event Timeline

Huji created this task.Aug 1 2015, 2:33 PM
Huji raised the priority of this task from to Needs Triage.
Huji updated the task description. (Show Details)
Huji added a project: Notifications.
Huji subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 1 2015, 2:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper added a comment.Aug 3 2015, 9:24 AM

Does it go away when reloading the page and bypassing your browser cache?

Huji added a comment.Aug 3 2015, 2:17 PM

Reloading makes it go away. Any page loads after that make it go away indeed.

Btw, I also noticed it on Meta today.

Etonkovidova closed this task as a duplicate of T106033: "You have new messages" stuck (until page reload) after all messages are 'Mark as read'.Aug 5 2015, 9:44 PM
• Mattflaschen-WMF reopened this task as Open.Aug 5 2015, 9:52 PM
• Mattflaschen-WMF subscribed.

This is about the yellow bar not going away when the user talk page is visited. It's not the same as the other one.

Huji added a comment.Aug 5 2015, 10:11 PM

The root cause may be the same.

Catrope triaged this task as Medium priority.Aug 5 2015, 11:49 PM
Catrope subscribed.
• DannyH moved this task from Untriaged to Near-Term Interest on the Collaboration-Team-Triage board.Aug 5 2015, 11:50 PM
• DannyH moved this task from Near-Term Interest to Freezer on the Collaboration-Team-Triage board.Aug 21 2015, 9:19 PM
Quiddity mentioned this in T106033: "You have new messages" stuck (until page reload) after all messages are 'Mark as read'.Sep 7 2015, 9:58 PM
Legoktm claimed this task.Sep 14 2015, 5:27 PM

I think this is a regression from rMW64bf3a12b514: Defer user_newtalk updates in clearNotification() to post-send. Previously the user_newtalk flag would have already been cleared, so Echo would think you don't have any new messages.

gerritbot subscribed.Sep 14 2015, 5:34 PM

Change 238194 had a related patch set uploaded (by Legoktm):
Don't show orange alert if you are viewing your user talk page

https://gerrit.wikimedia.org/r/238194

gerritbot added a project: Patch-For-Review.Sep 14 2015, 5:34 PM
Legoktm renamed this task from When accessing talk page through echo, the yellow "new message" notification doesn't go away to When accessing talk page through echo, the yellow "new message" notification doesn't go away until the next page view.Sep 14 2015, 5:35 PM
Legoktm edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.
Legoktm set Security to None.
Legoktm moved this task from Untriaged to Needs Review on the Collaboration-Team-Archive-2015-2016 board.
• DannyH added a project: OKR-Work.Sep 14 2015, 10:49 PM
• Elitre subscribed.Sep 15 2015, 9:24 AM
Catrope moved this task from Needs Review to Code Review Started on the Collaboration-Team-Archive-2015-2016 board.Sep 15 2015, 5:42 PM
gerritbot added a comment.Sep 15 2015, 11:01 PM

Change 238194 merged by jenkins-bot:
Don't show orange alert if you are viewing your user talk page

https://gerrit.wikimedia.org/r/238194

Legoktm mentioned this in rECHOe4d8002d7402: Don't show orange alert if you are viewing your user talk page.Sep 15 2015, 11:02 PM
Diffusion mentioned this in rMEXTa296cc765596: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 15 2015, 11:02 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 16 2015, 12:01 AM
Catrope moved this task from Code Review Started to QA Review on the Collaboration-Team-Archive-2015-2016 board.Sep 16 2015, 5:39 PM
Etonkovidova subscribed.Sep 17 2015, 10:38 PM

Checked in beta - getting (via clicking on a specific message notification, or via clicking on Notification, or via Search) to your Talk page will remove yellow/orange 'You have new messages' label.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Sep 17 2015, 10:39 PM
• DannyH closed this task as Resolved.Sep 22 2015, 6:32 PM
• DannyH subscribed.
Legoktm mentioned this in T115304: "New messages" bar appears on your talk page while you are viewing your messages.Oct 13 2015, 6:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits