Page MenuHomePhabricator
Create Task
Maniphest T107897

Implement feature flag to disable LQT Special:NewMessages
Closed, ResolvedPublic
Actions

Description

Implement a feature flag for LQT notifications (Special:NewMessages).

Add variable $wgLiquidThreadsEnableNewMessages, defaults to true

When false:

  1. 'New messages' link is not there
  2. Special:NewMessages is not registered[1]

[1] https://www.mediawiki.org/wiki/Manual:Hooks/SpecialPage_initList

Details

SubjectRepoBranchLines +/-
Remove new messages notice from watchlistmediawiki/extensions/LiquidThreadswmf/1.26wmf19+5 -1
Remove new messages notice from watchlistmediawiki/extensions/LiquidThreadsmaster+5 -1
Flag to disable Special:NewMessagesmediawiki/extensions/LiquidThreadsmaster+35 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Mattflaschen-WMF created this task.Aug 4 2015, 4:25 PM
• Mattflaschen-WMF raised the priority of this task from to Needs Triage.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added projects: MediaWiki-extensions-LiquidThreads, Collaboration-Team-Triage.
• Mattflaschen-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2015, 4:25 PM
• Mattflaschen-WMF renamed this task from Feature LQT Special:NewMessages using feature flag to Implement feature flag to disable LQT Special:NewMessages.Aug 4 2015, 4:27 PM
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF set Security to None.
• Mattflaschen-WMF added a parent task: T107898: Disable LQT Special:NewMessages on wikis with frozen LQT.
• DannyH triaged this task as Medium priority.Aug 4 2015, 10:59 PM
• DannyH moved this task from Untriaged to Ready for next sprint on the Collaboration-Team-Triage board.
• DannyH added a parent task: T92303: Convert LQT pages on MediaWiki.org to Flow (tracking).
• DannyH moved this task from Ready for next sprint to LQT tickets (temporary) on the Collaboration-Team-Triage board.Aug 4 2015, 11:06 PM
• DannyH added a project: Collaboration-Team-Archive-2015-2016.Aug 4 2015, 11:47 PM
Catrope removed a parent task: T92303: Convert LQT pages on MediaWiki.org to Flow (tracking).Aug 4 2015, 11:55 PM
Catrope added a parent task: T92303: Convert LQT pages on MediaWiki.org to Flow (tracking).
• Mattflaschen-WMF updated the task description. (Show Details)Aug 5 2015, 6:09 PM
SBisson claimed this task.Aug 5 2015, 6:09 PM
SBisson updated the task description. (Show Details)
SBisson moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.
gerritbot subscribed.Aug 5 2015, 6:49 PM

Change 229447 had a related patch set uploaded (by Sbisson):
Flag to disable Special:NewMessages

https://gerrit.wikimedia.org/r/229447

gerritbot added a project: Patch-For-Review.Aug 5 2015, 6:49 PM
SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Aug 5 2015, 6:50 PM
Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Aug 5 2015, 10:30 PM
gerritbot added a comment.Aug 5 2015, 10:34 PM

Change 229447 merged by jenkins-bot:
Flag to disable Special:NewMessages

https://gerrit.wikimedia.org/r/229447

Diffusion mentioned this in rMEXTf7c24e1ca3d9: Updated mediawiki/extensions Project: mediawiki/extensions/LiquidThreads….Aug 5 2015, 10:34 PM
Catrope mentioned this in rELQTd648dd6c0600: Flag to disable Special:NewMessages.Aug 5 2015, 10:35 PM
• Forrestbot added a project: WMF-deploy-2015-08-11_(1.26wmf18).Aug 5 2015, 11:00 PM
Etonkovidova subscribed.Aug 11 2015, 11:52 PM

Checked locally - with LiquidThreads.php
$wgLiquidThreadsEnableNewMessages = false;

'New messages' link is not displayed.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Aug 11 2015, 11:53 PM
• Mattflaschen-WMF added a subscriber: Quiddity.Aug 19 2015, 12:02 AM

@Quiddity found there is one more reference on Special:Watchlist.

• Mattflaschen-WMF moved this task from Product Review to In Development on the Collaboration-Team-Archive-2015-2016 board.Aug 19 2015, 12:03 AM
• Mattflaschen-WMF added a comment.Aug 19 2015, 12:07 AM

Watchlist Special_NewMessages link.png (276×430 px, 22 KB)

gerritbot added a comment.Aug 19 2015, 1:25 PM

Change 232493 had a related patch set uploaded (by Sbisson):
Remove new messages notice from watchlist

https://gerrit.wikimedia.org/r/232493

SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Aug 19 2015, 1:27 PM
gerritbot added a comment.Aug 19 2015, 8:17 PM

Change 232493 merged by jenkins-bot:
Remove new messages notice from watchlist

https://gerrit.wikimedia.org/r/232493

SBisson mentioned this in rMEXT1b56197e8923: Updated mediawiki/extensions Project: mediawiki/extensions/LiquidThreads….Aug 19 2015, 8:17 PM
SBisson mentioned this in rELQTeba86ebf5cc5: Remove new messages notice from watchlist.Aug 19 2015, 8:20 PM
• Forrestbot added a project: WMF-deploy-2015-08-25_(1.26wmf20).Aug 19 2015, 9:00 PM
• Mattflaschen-WMF moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Aug 20 2015, 1:55 AM
gerritbot added a comment.Aug 20 2015, 6:42 PM

Change 232783 had a related patch set uploaded (by Mattflaschen):
Remove new messages notice from watchlist

https://gerrit.wikimedia.org/r/232783

Etonkovidova added a comment.Aug 20 2015, 9:29 PM

Re-checked on local for Watchlist new messages notification( $wgLiquidThreadsEnableNewMessages = false; ).

NOTE: At some point in testing(no reproducible steps) - on the Logged out page above <div id="mw-content-text">, there was a message: "You have new messages" in orange colored letter.
Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Aug 20 2015, 9:30 PM
gerritbot added a comment.Aug 20 2015, 11:09 PM

Change 232783 merged by jenkins-bot:
Remove new messages notice from watchlist

https://gerrit.wikimedia.org/r/232783

SBisson mentioned this in rMWf15b7a330dc6: Updated mediawiki/core Project: mediawiki/extensions/LiquidThreads….Aug 20 2015, 11:09 PM
• Mattflaschen-WMF mentioned this in rELQTb7530e58316d: Remove new messages notice from watchlist.Aug 20 2015, 11:09 PM
• DannyH removed a project: Collaboration-Team-Triage.Aug 20 2015, 11:33 PM
• DannyH closed this task as Resolved.Aug 21 2015, 4:54 PM
• DannyH subscribed.
• Forrestbot added a project: WMF-deploy-2015-08-18_(1.26wmf19).Aug 23 2015, 12:34 AM
• Mattflaschen-WMF added a comment.Aug 24 2015, 4:56 AM
In T107897#1558811, @Etonkovidova wrote:
NOTE: At some point in testing(no reproducible steps) - on the Logged out page above <div id="mw-content-text">, there was a message: "You have new messages" in orange colored letter.

That sounds like the core user talk notification (neither Echo nor LQT) for anons (anons can not receive Echo notifications, so I believe it uses the stock UI).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL