Page MenuHomePhabricator
Create Task
Maniphest T107980

FOUC of VE's edit tab on page load caused by EducationProgram ext, made visible by the newly async RL model
Closed, ResolvedPublic8 Estimated Story Points
Actions

Details

SubjectRepoBranchLines +/-
Never unconditionally 'return false' from interface hooksmediawiki/extensions/EducationProgramwmf/1.26wmf17+2 -2
Never unconditionally 'return false' from interface hooksmediawiki/extensions/EducationProgrammaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Aug 5 2015, 2:35 AM
Jdforrester-WMF raised the priority of this task from to Unbreak Now!.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki, MediaWiki-ResourceLoader.
Jdforrester-WMF moved this task to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2015, 2:35 AM
Jdforrester-WMF set Security to None.Aug 5 2015, 2:35 AM
Jdforrester-WMF added subscribers: Krinkle, Esanders.
Jdforrester-WMF mentioned this in T107399: Make top queue fully asynchronous.Aug 5 2015, 11:21 PM
Krinkle added a comment.Aug 5 2015, 11:29 PM

The edit tab is swapped server-side by VisualEditor in PHP. The JS code is only used to fix it up for cached unedited articles (upto 30 days) following a configuration change such as enabling in a namespace, or enabling by default.

That use case was considered and we figured that'd be okay given it's not common in production in general. And when it happens it automatically drops off following cache roll over.

Does VisualEditor have any JavaScript code that (almost) always changes the appearance of the initial page load? If so, let's identify that and work to get rid of it as that is a bad practice. It should be done with HTML and CSS instead.

Jdforrester-WMF added a comment.Aug 5 2015, 11:30 PM

Well, you wrote it…

greg subscribed.Aug 6 2015, 4:09 PM
greg added a subscriber: • mmodell.Aug 6 2015, 4:22 PM

FYI: This task is considered a blocker for the upcoming (August 11th) train deployment to WMF wikis. If this task is not fixed before then I will have to hold the train.

greg added a parent task: T108197: Blockers for 1.26wmf18 (released on 2015-08-11).Aug 6 2015, 4:37 PM
Krinkle added a comment.EditedAug 6 2015, 4:40 PM
In T107980#1513081, @Jdforrester-WMF wrote:

Well, you wrote it…

When I wrote it, there was no flash. The js code and PHP code were functionally equivalent. The JS code is a no-op – unless the wiki's configuration changed recently (namespace, VE default etc.) and the user is anonymous and they're viewing a not-recently-changed cached page.

Krinkle claimed this task.Aug 6 2015, 4:41 PM
Jdforrester-WMF added a comment.Aug 6 2015, 4:51 PM
In T107980#1514927, @Krinkle wrote:
In T107980#1513081, @Jdforrester-WMF wrote:

Well, you wrote it…

When I wrote it, there was no flash. The js code and PHP code were functionally equivalent. The JS code is a no-op – unless the configuration changed recently and the user is anonymous and they're viewing a not-recently-changed cached page.

Yeah, sorry for being snappy. I've skimmed the code and can't see how it's not being set.

gerritbot subscribed.Aug 6 2015, 9:12 PM

Change 229954 had a related patch set uploaded (by Krinkle):
Never unconditionally 'return false' from interface hooks

https://gerrit.wikimedia.org/r/229954

gerritbot added a project: Patch-For-Review.Aug 6 2015, 9:12 PM

Change 229955 had a related patch set uploaded (by Krinkle):
Never unconditionally 'return false' from interface hooks

https://gerrit.wikimedia.org/r/229955

gerritbot added a comment.Aug 6 2015, 9:13 PM

Change 229954 merged by jenkins-bot:
Never unconditionally 'return false' from interface hooks

https://gerrit.wikimedia.org/r/229954

Krinkle mentioned this in rEEDUfa4f454bdbf3: Never unconditionally 'return false' from interface hooks.Aug 6 2015, 9:14 PM
Krinkle mentioned this in rMEXTddb9ae9599bd: Updated mediawiki/extensions Project: mediawiki/extensions/EducationProgram….
gerritbot added a comment.Aug 6 2015, 9:22 PM

Change 229955 merged by jenkins-bot:
Never unconditionally 'return false' from interface hooks

https://gerrit.wikimedia.org/r/229955

Krinkle mentioned this in rMW15fe0b612968: Updated mediawiki/core Project: mediawiki/extensions/EducationProgram….Aug 6 2015, 9:22 PM
Krinkle mentioned this in rEEDU5d44c56c1f5f: Never unconditionally 'return false' from interface hooks.
Jdforrester-WMF renamed this task from [Regression pre-wmf18] FOUC of VE's edit tab on page load caused (?) by newly async RL model to FOUC of VE's edit tab on page load caused by EducationProgram ext, made visible by the newly async RL model.Aug 6 2015, 9:26 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF edited projects, added MediaWiki-extensions-EducationProgram, WMF-deploy-2015-08-04_(1.26wmf17), WMF-deploy-2015-08-11_(1.26wmf18); removed Patch-For-Review.
Jdforrester-WMF edited a custom field.
Krinkle mentioned this in T173615: Enforce concept of unabortable hooks.Aug 19 2017, 12:45 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL