|mediawiki/extensions/EducationProgram : wmf/1.26wmf17||Never unconditionally 'return false' from interface hooks|
|mediawiki/extensions/EducationProgram : master||Never unconditionally 'return false' from interface hooks|
|Resolved||ori||T108197 Blockers for 1.26wmf18 (released on 2015-08-11)|
|Resolved||Krinkle||T107980 FOUC of VE's edit tab on page load caused by EducationProgram ext, made visible by the newly async RL model|
- Mentioned In
- T173615: Enforce concept of unabortable hooks
rEEDU5d44c56c1f5f: Never unconditionally 'return false' from interface hooks
rMW15fe0b612968: Updated mediawiki/core Project: mediawiki/extensions/EducationProgram…
rMEXTddb9ae9599bd: Updated mediawiki/extensions Project: mediawiki/extensions/EducationProgram…
rEEDUfa4f454bdbf3: Never unconditionally 'return false' from interface hooks
T107399: Make top queue fully asynchronous
The edit tab is swapped server-side by VisualEditor in PHP. The JS code is only used to fix it up for cached unedited articles (upto 30 days) following a configuration change such as enabling in a namespace, or enabling by default.
That use case was considered and we figured that'd be okay given it's not common in production in general. And when it happens it automatically drops off following cache roll over.
When I wrote it, there was no flash. The js code and PHP code were functionally equivalent. The JS code is a no-op – unless the wiki's configuration changed recently (namespace, VE default etc.) and the user is anonymous and they're viewing a not-recently-changed cached page.