Maniphest T109000

Use EditorWidget for edit post
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Catrope
	Aug 13 2015, 8:53 PM

Tags

Referenced Files

	F2533987: Screen Shot 2015-09-02 at 2.12.09 PM.png
	Sep 2 2015, 9:15 PM

	F1790948: Screen Shot 2015-08-18 at 11.40.37 AM.png
	Aug 18 2015, 8:03 PM

Subscribers

Description

The summary editor and the topic/post content editor (i.e. not creating new topics/replies, but editing existing ones) come to mind. We should also audit to make sure the old editor code is unused, and then remove it.

Edit post: https://gerrit.wikimedia.org/r/234603

Topic summary: was extracted into T111102: Use EditorWidget for topic summary

Details

	Subject	Repo	Branch	Lines +/-
	Refactor CAPTCHA support into data model and widget	mediawiki/extensions/Flow	master	+198 -89
	Edit post widget	mediawiki/extensions/Flow	master	+287 -128

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• DannyH	T110093 Editing posts: Keep input focus when switching from VE to wikitext editing
		Resolved		None	T109750 [betalabs] 'Cancel' Summarize gives "Cannot read property 'commandRegistry'"
		Resolved		SBisson	T109000 Use EditorWidget for edit post

Event Timeline

Catrope created this task.Aug 13 2015, 8:53 PM

Catrope raised the priority of this task from to Needs Triage.

Catrope updated the task description. (Show Details)

Catrope added projects: StructuredDiscussions, Collaboration-Team-Archive-2015-2016.

Catrope subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2015, 8:53 PM

For testing - to check after the fix:

different wikitext icons for 'Reply' and 'Edit reply'

Screen Shot 2015-08-18 at 11.40.37 AM.png (551×776 px, 62 KB)

Catrope triaged this task as High priority.Aug 19 2015, 11:27 PM

Catrope mentioned this in T109660: Clicking 'edit' should always refetch from the server.Aug 19 2015, 11:52 PM

• DannyH added a project: OKR-Work.Aug 21 2015, 11:20 PM

• DannyH set Security to None.

Catrope added a parent task: T110093: Editing posts: Keep input focus when switching from VE to wikitext editing.Aug 24 2015, 6:59 PM

Catrope claimed this task.Aug 24 2015, 9:48 PM

Catrope moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.

Catrope removed Catrope as the assignee of this task.Aug 25 2015, 5:35 PM

Catrope moved this task from In Development to Untriaged on the Collaboration-Team-Archive-2015-2016 board.

Catrope added a parent task: T109750: [betalabs] 'Cancel' Summarize gives "Cannot read property 'commandRegistry'" .Aug 26 2015, 11:57 PM

SBisson claimed this task.Aug 27 2015, 5:29 PM

SBisson moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.

Change 234423 had a related patch set uploaded (by Mattflaschen):
Initial refactoring to create ContentWidget

https://gerrit.wikimedia.org/r/234423

gerritbot added a project: Patch-For-Review.Aug 27 2015, 8:47 PM

Jay8g subscribed.Aug 27 2015, 10:28 PM

Change 234603 had a related patch set uploaded (by Sbisson):
[WIP] Edit post widget

https://gerrit.wikimedia.org/r/234603

SBisson updated the task description. (Show Details)Sep 1 2015, 1:59 PM

Change 234603 merged by jenkins-bot:
Edit post widget

https://gerrit.wikimedia.org/r/234603

SBisson mentioned this in rEFLW2af44bb6486f: Edit post widget.Sep 1 2015, 6:40 PM

SBisson mentioned this in rMEXTf090412c726b: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….

• Forrestbot added a project: WMF-deploy-2015-09-08_(1.26wmf22).Sep 1 2015, 7:00 PM

SBisson renamed this task from Port remaining editor uses to EditorWidget to Use EditorWidget for edit post.Sep 1 2015, 8:10 PM

SBisson mentioned this in T111102: Use EditorWidget for topic summary.

SBisson updated the task description. (Show Details)

SBisson moved this task from In Development to QA Review on the Collaboration-Team-Archive-2015-2016 board.

Checked in beta - edit/new reply posts are ok:

Screen Shot 2015-09-02 at 2.12.09 PM.png (629×1 px, 81 KB)

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Sep 2 2015, 9:16 PM

• DannyH closed this task as Resolved.Sep 2 2015, 10:43 PM

• DannyH subscribed.

Etonkovidova mentioned this in T109750: [betalabs] 'Cancel' Summarize gives "Cannot read property 'commandRegistry'" .Sep 29 2015, 4:26 PM

Change 234423 merged by jenkins-bot:
Refactor CAPTCHA support into data model and widget

https://gerrit.wikimedia.org/r/234423

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)).Nov 5 2015, 10:00 PM