The code for the origin parameters needs test coverage so another developer can pick up where you have left off and understand how it is supposed to work!
Description
Description
Details
Details
Related Gerrit Patches:
| mediawiki/extensions/WikidataPageBanner : master | WikidataPageBanner improve qunit test |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T108785 Use origin parameter to precisely define a center focus position in JavaScript | |||
| Resolved | None | T109319 Add qunit test coverage for origin parameter |
Event Timeline
Comment Actions
The qunit tests for origin were added in https://gerrit.wikimedia.org/r/#/c/230050/ , are some other tests also needed?
Comment Actions
Whoops!
Looks like I missed those in code review :-s
I'll add some comments on the tests. If you could address the points I think we are good :)
Comment Actions
Change 232195 had a related patch set uploaded (by Sumit):
WikidataPageBanner improve qunit test