Maniphest T109319

Add qunit test coverage for origin parameter
Closed, ResolvedPublic
Actions

Description

The code for the origin parameters needs test coverage so another developer can pick up where you have left off and understand how it is supposed to work!

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/WikidataPageBanner	master	+46 -7	WikidataPageBanner improve qunit test

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T108785 Use origin parameter to precisely define a center focus position in JavaScript
		Resolved		None	T109319 Add qunit test coverage for origin parameter

Event Timeline

Jdlrobson created this task.Aug 17 2015, 3:49 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Wikidata-Page-Banner.

Jdlrobson added subscribers: Nicolas_Raoul, Dbrant, • BGerstle-WMF and 4 others.

Restricted Application added a project: Wikidata. · View Herald TranscriptAug 17 2015, 3:49 PM

Jdlrobson moved this task from In discussion to Epics on the Wikidata-Page-Banner board.Aug 17 2015, 3:49 PM

Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Aug 17 2015, 4:46 PM

The qunit tests for origin were added in https://gerrit.wikimedia.org/r/#/c/230050/ , are some other tests also needed?

Whoops!
Looks like I missed those in code review :-s
I'll add some comments on the tests. If you could address the points I think we are good :)

Change 232195 had a related patch set uploaded (by Sumit):
WikidataPageBanner improve qunit test

https://gerrit.wikimedia.org/r/232195

gerritbot added a project: Patch-For-Review.Aug 17 2015, 8:35 PM

Change 232195 merged by jenkins-bot:
WikidataPageBanner improve qunit test

https://gerrit.wikimedia.org/r/232195

Sumit mentioned this in rMEXTa396c2030be0: Updated mediawiki/extensions Project: mediawiki/extensions/WikidataPageBanner….Aug 17 2015, 11:39 PM

Sumit mentioned this in rEWDP21c175afa648: WikidataPageBanner improve qunit test.

Sumit closed this task as Resolved.Aug 18 2015, 3:16 AM

Sumit set Security to None.

Forrestbot added a project: WMF-deploy-2015-08-25_(1.26wmf20).Aug 19 2015, 6:02 AM