Page MenuHomePhabricator

Add qunit test coverage for origin parameter
Closed, ResolvedPublic

Description

The code for the origin parameters needs test coverage so another developer can pick up where you have left off and understand how it is supposed to work!

Details

Related Gerrit Patches:
mediawiki/extensions/WikidataPageBanner : masterWikidataPageBanner improve qunit test

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Restricted Application added a project: Wikidata. · View Herald TranscriptAug 17 2015, 3:49 PM
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Aug 17 2015, 4:46 PM
Sumit added a subscriber: Sumit.Aug 17 2015, 5:15 PM

The qunit tests for origin were added in https://gerrit.wikimedia.org/r/#/c/230050/ , are some other tests also needed?

Whoops!
Looks like I missed those in code review :-s
I'll add some comments on the tests. If you could address the points I think we are good :)

Change 232195 had a related patch set uploaded (by Sumit):
WikidataPageBanner improve qunit test

https://gerrit.wikimedia.org/r/232195

Change 232195 merged by jenkins-bot:
WikidataPageBanner improve qunit test

https://gerrit.wikimedia.org/r/232195

Sumit closed this task as Resolved.Aug 18 2015, 3:16 AM
Sumit set Security to None.