Page MenuHomePhabricator
Create Task
Maniphest T109319

Add qunit test coverage for origin parameter
Closed, ResolvedPublic
Actions

Description

The code for the origin parameters needs test coverage so another developer can pick up where you have left off and understand how it is supposed to work!

Details

Related Gerrit Patches:
mediawiki/extensions/WikidataPageBanner : masterWikidataPageBanner improve qunit test

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Aug 17 2015, 3:49 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Wikidata-Page-Banner.
Jdlrobson added subscribers: Nicolas_Raoul, Dbrant, • BGerstle-WMF and 4 others.
Restricted Application added a project: Wikidata. · View Herald TranscriptAug 17 2015, 3:49 PM
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Aug 17 2015, 4:46 PM
Sumit added a subscriber: Sumit.Aug 17 2015, 5:15 PM

The qunit tests for origin were added in https://gerrit.wikimedia.org/r/#/c/230050/ , are some other tests also needed?

Jdlrobson added a comment.Aug 17 2015, 6:18 PM

Whoops!
Looks like I missed those in code review :-s
I'll add some comments on the tests. If you could address the points I think we are good :)

gerritbot added a comment.Aug 17 2015, 8:35 PM

Change 232195 had a related patch set uploaded (by Sumit):
WikidataPageBanner improve qunit test

https://gerrit.wikimedia.org/r/232195

gerritbot added a comment.Aug 17 2015, 11:39 PM

Change 232195 merged by jenkins-bot:
WikidataPageBanner improve qunit test

https://gerrit.wikimedia.org/r/232195

Sumit closed this task as Resolved.Aug 18 2015, 3:16 AM
Sumit set Security to None.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL