Page MenuHomePhabricator
Create Task
Maniphest T109688

[CatWatch] Links to history are incorrect
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

First of all: thank you for the new feature "watch changes in category membership"!!

One thing I noticed: the link to the page history isn't working (see attached screenshot, lowest line "05:37"). Clicking on "hist" opens the file description page, not its history.

test.png (119×1 px, 13 KB)

And if there are more than one actions for a category (see screenshot "08:54") there are links that seem to point to the category's history ("2 changes" and "history") but actually they point to the first file's diff and history (i.e. "File:Simon pass.JPG").

This only happens if the "group changes by page" option is activated in the settings for recent changes. Otherwise there are no hist/diff links at all.

Details

SubjectRepoBranchLines +/-
Enable users to watch category membership changes #2mediawiki/coremaster+427 -57
Enable users to watch category membership changes #2mediawiki/coremaster+727 -82
Customize query in gerrit

Related Objects
Search...

Event Timeline

Thgoiter created this task.Aug 20 2015, 7:03 AM
Thgoiter raised the priority of this task from to Needs Triage.
Thgoiter updated the task description. (Show Details)
Thgoiter added a project: TCB-Team (now WMDE-TechWish).
Thgoiter subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2015, 7:03 AM
Thgoiter set Security to None.Aug 20 2015, 9:11 AM
Thgoiter added a subscriber: kai.nissen.
Thgoiter updated the task description. (Show Details)Aug 20 2015, 9:14 AM
Thgoiter updated the task description. (Show Details)
Thgoiter updated the task description. (Show Details)
• KasiaWMDE subscribed.Aug 20 2015, 10:14 AM
• KasiaWMDE added a project: German-Community-Wishlist.Aug 20 2015, 10:41 AM
Bmueller subscribed.Aug 20 2015, 1:16 PM
Thgoiter updated the task description. (Show Details)Aug 20 2015, 4:06 PM
Ireas subscribed.Aug 20 2015, 9:15 PM
AuFCL subscribed.Aug 20 2015, 9:27 PM
Tobi_WMDE_SW added a parent task: T9148: Watch edits which add or remove pages from a category.Aug 27 2015, 12:30 PM
PeterBowman subscribed.Aug 28 2015, 8:56 AM
Addshore renamed this task from Links to history (feature "watch changes in category membership") to [CatWatch] Links to history (feature "watch changes in category membership").Aug 31 2015, 8:13 AM
Addshore subscribed.
gerritbot subscribed.Aug 31 2015, 3:53 PM

Change 233441 had a related patch set uploaded (by Addshore):
[WIP] Enable users to watch category membership changes (try #2)

https://gerrit.wikimedia.org/r/233441

gerritbot added a project: Patch-For-Review.Aug 31 2015, 3:53 PM
Addshore renamed this task from [CatWatch] Links to history (feature "watch changes in category membership") to [CatWatch] Links to history are incorrect.Sep 1 2015, 2:31 PM
Addshore added a project: TCB-Team-Sprint-2015-08-26.
Addshore moved this task from Backlog to Review on the TCB-Team-Sprint-2015-08-26 board.
Addshore claimed this task.Sep 1 2015, 2:33 PM

In the current version of the patch the history links are disabled.
Once the first patch is up to scratch we can decide what we want to do here.

Addshore edited a custom field.Sep 2 2015, 8:56 AM
• KasiaWMDE triaged this task as High priority.Sep 4 2015, 10:02 AM
• KasiaWMDE moved this task from Incoming to Work in progress on the German-Community-Wishlist board.
Tobi_WMDE_SW added a project: TCB-Team-Sprint-2015-09-09.Sep 9 2015, 1:20 PM
Tobi_WMDE_SW moved this task from Backlog to Review on the TCB-Team-Sprint-2015-09-09 board.
gerritbot added a comment.Sep 17 2015, 10:37 AM

Change 239065 had a related patch set (by Addshore) published:
Enable users to watch category membership changes #2

https://gerrit.wikimedia.org/r/239065

gerritbot added a comment.Sep 17 2015, 10:47 AM

Change 233441 abandoned by Addshore:
Enable users to watch category membership changes #2

Reason:
Please see the following changes which have been factored out of this one:
https://gerrit.wikimedia.org/r/#/c/239061/
https://gerrit.wikimedia.org/r/#/c/239060/
https://gerrit.wikimedia.org/r/#/c/239065/

https://gerrit.wikimedia.org/r/233441

Tobi_WMDE_SW added a project: TCB-Team-Sprint-2015-09-24.Sep 24 2015, 10:47 AM
Tobi_WMDE_SW moved this task from Backlog to Review on the TCB-Team-Sprint-2015-09-24 board.
Tobi_WMDE_SW added a project: TCB-Team-Sprint-2015-10-07.Oct 7 2015, 2:09 PM
Tobi_WMDE_SW moved this task from Backlog to Review on the TCB-Team-Sprint-2015-10-07 board.
Tobi_WMDE_SW added a project: TCB-Team-Sprint-2015-10-14.Oct 14 2015, 1:09 PM
Tobi_WMDE_SW moved this task from Backlog to Review on the TCB-Team-Sprint-2015-10-14 board.
gerritbot added a comment.Oct 20 2015, 9:41 PM

Change 239065 merged by jenkins-bot:
Enable users to watch category membership changes #2

https://gerrit.wikimedia.org/r/239065

Addshore closed this task as Resolved.Oct 20 2015, 9:54 PM
Addshore moved this task from Review to Done on the TCB-Team-Sprint-2015-10-14 board.
Addshore moved this task from Incoming to Done on the TCB-Team (now WMDE-TechWish) board.Nov 27 2015, 10:29 AM
Tobi_WMDE_SW moved this task from Work in progress to Done on the German-Community-Wishlist board.Jan 21 2016, 12:15 PM
Luke081515 added a project: CatWatch.Feb 24 2016, 7:24 PM
AuFCL unsubscribed.Nov 21 2016, 7:38 PM
IKhitron subscribed.Aug 28 2017, 10:42 AM
Restricted Application added a project: User-Addshore. · View Herald TranscriptAug 28 2017, 10:42 AM
Addshore moved this task from Unsorted 💣 to Closing ✔️ on the User-Addshore board.Aug 28 2017, 11:47 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL