Page MenuHomePhabricator

[CatWatch] Links to history are incorrect
Closed, ResolvedPublic2 Estimated Story Points

Description

First of all: thank you for the new feature "watch changes in category membership"!!

One thing I noticed: the link to the page history isn't working (see attached screenshot, lowest line "05:37"). Clicking on "hist" opens the file description page, not its history.

test.png (119×1 px, 13 KB)

And if there are more than one actions for a category (see screenshot "08:54") there are links that seem to point to the category's history ("2 changes" and "history") but actually they point to the first file's diff and history (i.e. "File:Simon pass.JPG").

This only happens if the "group changes by page" option is activated in the settings for recent changes. Otherwise there are no hist/diff links at all.

Event Timeline

Thgoiter raised the priority of this task from to Needs Triage.
Thgoiter updated the task description. (Show Details)
Thgoiter added a project: archived--TCB-Team.
Thgoiter added a subscriber: Thgoiter.
Thgoiter updated the task description. (Show Details)
Thgoiter updated the task description. (Show Details)
Addshore renamed this task from Links to history (feature "watch changes in category membership") to [CatWatch] Links to history (feature "watch changes in category membership").Aug 31 2015, 8:13 AM
Addshore added a subscriber: Addshore.

Change 233441 had a related patch set uploaded (by Addshore):
[WIP] Enable users to watch category membership changes (try #2)

https://gerrit.wikimedia.org/r/233441

Addshore renamed this task from [CatWatch] Links to history (feature "watch changes in category membership") to [CatWatch] Links to history are incorrect.Sep 1 2015, 2:31 PM
Addshore moved this task from Backlog to Review on the TCB-Team-Sprint-2015-08-26 board.

In the current version of the patch the history links are disabled.
Once the first patch is up to scratch we can decide what we want to do here.

Change 239065 had a related patch set (by Addshore) published:
Enable users to watch category membership changes #2

https://gerrit.wikimedia.org/r/239065

Change 233441 abandoned by Addshore:
Enable users to watch category membership changes #2

Reason:
Please see the following changes which have been factored out of this one:
https://gerrit.wikimedia.org/r/#/c/239061/
https://gerrit.wikimedia.org/r/#/c/239060/
https://gerrit.wikimedia.org/r/#/c/239065/

https://gerrit.wikimedia.org/r/233441

Change 239065 merged by jenkins-bot:
Enable users to watch category membership changes #2

https://gerrit.wikimedia.org/r/239065

Addshore moved this task from Review to Done on the TCB-Team-Sprint-2015-10-14 board.