[CatWatch] Page ID for categorizations in API inconsistent
Closed, DeclinedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Schnark
	Aug 20 2015, 7:21 AM

Referenced Files

	F2512330: pasted_file
	Aug 31 2015, 1:07 PM

Subscribers

View All 9 Subscribers

Description

The pageid in API output (for watchlist and recentchanges) for categorizations is inconsistent with other pageids. Example change:

{
    "type": "categorize",
    "ns": 14,
    "title": "Kategorie:TestKategorie",
    "pageid": 1205,
    "revid": 11474,
    "old_revid": 0,
    "rcid": 17417,
    "timestamp": "2015-08-19T16:27:42Z"
},

1205 is not the page ID for Kategorie:TestKategorie, but for Wikipedia:Spielwiese, the page that was categorized. In all other places title and pageid refer to the same page, so the current behavior is inconsistent.

Related Objects
Search...

Status	Assigned	Task
Invalid	TTO	T125171 [Catwatch] Filter for Watch edits which add or remove pages from a category
Resolved	Addshore	T9148 Watch edits which add or remove pages from a category
Declined	Addshore	T109689 [CatWatch] Page ID for categorizations in API inconsistent

Event Timeline

Schnark created this task.Aug 20 2015, 7:21 AM

Schnark raised the priority of this task from to Needs Triage.

Schnark updated the task description. (Show Details)

Schnark added projects: MediaWiki-Watchlist, MediaWiki-Action-API, TCB-Team (now WMDE-TechWish).

Schnark added subscribers: Schnark, kai.nissen.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2015, 7:21 AM

• KasiaWMDE subscribed.Aug 20 2015, 10:16 AM

• KasiaWMDE added a project: German-Community-Wishlist.Aug 20 2015, 10:40 AM

• KasiaWMDE set Security to None.

Bmueller subscribed.Aug 20 2015, 2:53 PM

Anomie moved this task from Unsorted to Needs details or plan on the MediaWiki-Action-API board.Aug 20 2015, 4:31 PM

Feature was reverted with https://gerrit.wikimedia.org/r/#/c/232764/

Hopefully they fix this if they resubmit the feature.

Ciencia_Al_Poder mentioned this in T9148: Watch edits which add or remove pages from a category.Aug 20 2015, 8:28 PM

RP88 subscribed.Aug 20 2015, 8:30 PM

Re opening per https://gerrit.wikimedia.org/r/#/c/233441/ being open and a WIP which should then solve this issue

In T109689#1570751, @Addshore wrote:

Re opening per https://gerrit.wikimedia.org/r/#/c/233441/ being open and a WIP which should then solve this issue

It seems odd to me to have a bug open when it only exists in code that isn't actually merged anywhere.

Sitic subscribed.Aug 25 2015, 3:03 PM

Tobi_WMDE_SW removed Anomie as the assignee of this task.Aug 26 2015, 1:41 PM

Tobi_WMDE_SW triaged this task as Medium priority.

Tobi_WMDE_SW edited a custom field.

Tobi_WMDE_SW added a project: TCB-Team-Sprint-2015-08-26.

Tobi_WMDE_SW added a subtask: T9148: Watch edits which add or remove pages from a category.

Tobi_WMDE_SW removed a subtask: T9148: Watch edits which add or remove pages from a category.Aug 26 2015, 2:45 PM

Tobi_WMDE_SW added a parent task: T9148: Watch edits which add or remove pages from a category.

Tobi_WMDE_SW renamed this task from [Category Watchlist] Page ID for categorizations in API inconsistent to [CatWatch] Page ID for categorizations in API inconsistent.Aug 28 2015, 7:18 AM

Addshore claimed this task.Aug 31 2015, 11:51 AM

Addshore moved this task from Backlog to Doing on the TCB-Team-Sprint-2015-08-26 board.

Change 233441 had a related patch set uploaded (by Addshore):
[WIP] Enable users to watch category membership changes (try #2)

https://gerrit.wikimedia.org/r/233441

gerritbot added a project: Patch-For-Review.Aug 31 2015, 11:52 AM

Addshore moved this task from Doing to Review on the TCB-Team-Sprint-2015-08-26 board.Aug 31 2015, 11:53 AM

So, I just went and change this in the current change.
The change can be seen at https://gerrit.wikimedia.org/r/#/c/233441/4..5/includes/changes/RecentChange.php

This however means that RCCacheEntryFactory now no longer has any access to the pageid of the change that may have added / removed the category...
Which I guess was why it was done the way it was done!

Then I went to read https://www.mediawiki.org/wiki/Manual:Recentchanges_table specifically for rc_title and rc_cur_id and it doesn't actually state that they necessarily refer to the same thing

The more I look at it the more I feel that....
title and namespace must refer to the Category in question
cur_id, this_oldid, last_oldid must refer to the change / edit if possible (that added or removed the cat)
Although this kind of sucks as then there is no ID for the category, just a title, though this probably doesn't matter too much... I mean the title doesn't change if I move a page, so it wont change if I move a category....

Anomie moved this task from Needs details or plan to In Dev on the MediaWiki-Action-API board.Sep 2 2015, 1:17 PM

• KasiaWMDE moved this task from Incoming to Work in progress on the German-Community-Wishlist board.Sep 4 2015, 10:02 AM

Tobi_WMDE_SW added a project: TCB-Team-Sprint-2015-09-09.Sep 9 2015, 1:20 PM

Tobi_WMDE_SW moved this task from Backlog to Review on the TCB-Team-Sprint-2015-09-09 board.

Tobi_WMDE_SW added a project: TCB-Team-Sprint-2015-09-24.Sep 24 2015, 10:47 AM

Tobi_WMDE_SW moved this task from Backlog to Review on the TCB-Team-Sprint-2015-09-24 board.

Tobi_WMDE_SW added a project: TCB-Team-Sprint-2015-10-07.Oct 7 2015, 2:09 PM

Tobi_WMDE_SW moved this task from Backlog to Review on the TCB-Team-Sprint-2015-10-07 board.

Tobi_WMDE_SW added a project: TCB-Team-Sprint-2015-10-14.Oct 14 2015, 1:09 PM

Tobi_WMDE_SW moved this task from Backlog to Review on the TCB-Team-Sprint-2015-10-14 board.

Addshore closed this task as Declined.Oct 20 2015, 9:57 PM

Addshore moved this task from Review to Done on the TCB-Team-Sprint-2015-10-14 board.

MGChecker subscribed.Oct 21 2015, 10:42 PM

Addshore moved this task from Incoming to Done on the TCB-Team (now WMDE-TechWish) board.Nov 27 2015, 10:29 AM

Tobi_WMDE_SW moved this task from Work in progress to Done on the German-Community-Wishlist board.Jan 21 2016, 12:15 PM

Luke081515 added a project: CatWatch.Feb 24 2016, 7:24 PM

Aklapper removed subscribers: Anomie, • KasiaWMDE.Oct 16 2020, 5:28 PM

Restricted Application added a project: User-Addshore. · View Herald TranscriptOct 16 2020, 5:28 PM

[CatWatch] Page ID for categorizations in API inconsistentClosed, DeclinedPublic5 Estimated Story PointsActions

Description

Related ObjectsSearch...

Event Timeline

[CatWatch] Page ID for categorizations in API inconsistent
Closed, DeclinedPublic5 Estimated Story Points
Actions

Related Objects
Search...