MobileFrontend should use usermodule from core (enable User common.js on mobile)
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Aug 25 2015, 10:58 PM

Description

I suspect this bug will just sit here since everything currently just works (TM) but we really should remove the MobileFrontend user module.

Previously this was setup as scripts in common.js were not compatible with the mobile skin and when we enabled the user module originally there were various bug reports due to breakage.

I think it is our duty to force users to think about the scripts they put in their user common.js and make them more future proof.

The question is do we accept the trade-off of temporary inconvenience and do so, or do we make more efforts to prevent scripts from breaking in the first case (e.g. wrap in try/catch blocks)

Related Objects
Search...

Status	Assigned	Task
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Resolved	Jdlrobson	T71366 [EPIC] Extract Minerva skin from MobileFrontend to its own repository
Declined	None	T162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
Duplicate	None	T110258 MobileFrontend should use usermodule from core (enable User common.js on mobile)

Event Timeline

Jdlrobson created this task.Aug 25 2015, 10:58 PM

Jdlrobson raised the priority of this task from to Low.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: MobileFrontend.

Jdlrobson added a parent task: T71366: [EPIC] Extract Minerva skin from MobileFrontend to its own repository.

Jdlrobson added subscribers: Krinkle, Gregrwm, bd808 and 4 others.

Legoktm removed a parent task: T102554: User js not getting invalidated without debug=false.Aug 25 2015, 11:07 PM

Legoktm renamed this task from MobileFrontend should use usermodule from core to MobileFrontend should use usermodule from core (enable User common.js on mobile).Aug 28 2015, 5:15 PM

Legoktm set Security to None.

I think we should do this, but I'm concerned we will run into issues if site-wide Common.js and CSS are still not being loaded on mobile. So we'd want to enable both, announce it widely, document that people can wrap their code if ( mw.config.get( 'skin' ) == 'minerva' ) { ... } or use a .skin-minerva selector to only load it on mobile (or do the opposite).

Jdlrobson moved this task from Backlog to Discussing on the MobileFrontend board.Nov 4 2015, 5:17 PM

MBinder_WMF added a project: Web-Team-Backlog.Apr 27 2016, 4:24 PM

MBinder_WMF moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jul 4 2016, 7:38 PM

Jdlrobson added a project: Technical-Debt.Jul 7 2016, 4:37 PM

MaxSem moved this task from Unsorted to Needs refactor on the Technical-Debt board.Jul 17 2016, 6:17 PM

MBinder_WMF added a project: Reading-Web-Tech-Debt.Oct 3 2016, 8:35 PM

MBinder_WMF edited projects, added Technical-Debt (RW-Tech-Debt); removed Technical-Debt.Oct 4 2016, 6:16 PM

MBinder_WMF removed a project: Reading-Web-Tech-Debt.Oct 4 2016, 7:53 PM

• bmansurov moved this task from Uncategorized to Maintainability on the Technical-Debt (RW-Tech-Debt) board.Oct 7 2016, 5:20 PM

Krinkle awarded a token.Oct 7 2016, 8:52 PM

Jdlrobson added a parent task: T162210: [EPIC] Upstream MobileFrontend components to core and other extensions (tracking).Apr 4 2017, 11:27 PM

Jdlrobson closed this task as a duplicate of T156426: Issues with loading user common/minerva scripts in mobile site.May 3 2017, 6:02 PM