Page MenuHomePhabricator

MobileFrontend should use usermodule from core (enable User common.js on mobile)
Closed, DuplicatePublic


I suspect this bug will just sit here since everything currently just works (TM) but we really should remove the MobileFrontend user module.

Previously this was setup as scripts in common.js were not compatible with the mobile skin and when we enabled the user module originally there were various bug reports due to breakage.

I think it is our duty to force users to think about the scripts they put in their user common.js and make them more future proof.

The question is do we accept the trade-off of temporary inconvenience and do so, or do we make more efforts to prevent scripts from breaking in the first case (e.g. wrap in try/catch blocks)

Event Timeline

Jdlrobson raised the priority of this task from to Low.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: MobileFrontend.
Jdlrobson added subscribers: Krinkle, Gregrwm, bd808 and 4 others.
Legoktm renamed this task from MobileFrontend should use usermodule from core to MobileFrontend should use usermodule from core (enable User common.js on mobile).Aug 28 2015, 5:15 PM
Legoktm set Security to None.

I think we should do this, but I'm concerned we will run into issues if site-wide Common.js and CSS are still not being loaded on mobile. So we'd want to enable both, announce it widely, document that people can wrap their code if ( mw.config.get( 'skin' ) == 'minerva' ) { ... } or use a .skin-minerva selector to only load it on mobile (or do the opposite).