Improve edit summary for calls to `wbeditentity` with the `clear` parameter set
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Addshore
	Sep 6 2015, 8:09 PM

Description

Problem:
Currently, the edit summary generated from an API call to wbeditentity when the clear parameter is set reads "Cleared an Item" which is misleading, as the Item is not cleared, but in fact, overridden with new data in most cases. See the following diff as an example: https://wikidata.beta.wmflabs.org/w/index.php?title=Q522318&diff=1309601&oldid=1113678

Therefore, we would like to update this edit summary message to read: "Overwrote an Item"

Acceptance Criteria:

Edit summaries for API changes from wbeditentity with the clear parameter read "Overwrote an Item"

Related Objects

Mentioned In: T67846: wbeditentity: try to use appropriate autocomment instead of the generic one

Event Timeline

Addshore created this task.Sep 6 2015, 8:09 PM

Addshore raised the priority of this task from to Low.

Addshore updated the task description. (Show Details)

Addshore added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.

Addshore added subscribers: Addshore, Bene, daniel.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2015, 8:09 PM

Addshore added a project: good first task.Sep 6 2015, 8:09 PM

Addshore set Security to None.

I guess the best option is to just ignore the clear parameter in the summary. The entity mostly doesn't get cleared but only some data is added and some is removed. If a lot of stuff gets removed that is indicated by the byte difference.

https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/8ce054eb5c34cf4c5e3bc5bc6fbce69329ded11f/repo/includes/api/EditEntity.php#L271

JanZerebecki renamed this task from When using wbeditentity and the clear parameter the summary should be improved to say "Setting entity" or just "editing entity" to [Story] When using wbeditentity and the clear parameter the summary should be improved to say "Setting entity" or just "editing entity".Sep 10 2015, 6:15 PM

JanZerebecki moved this task from incoming to ready to go on the Wikidata board.

Should we just go and change that line?

In T111649#1629525, @Ricordisamoa wrote:

Should we just go and change that line?

Yes

JanZerebecki added a project: Story.Sep 25 2015, 8:31 PM

Addshore mentioned this in T67846: wbeditentity: try to use appropriate autocomment instead of the generic one.Feb 3 2016, 10:40 AM

jayvdb subscribed.Feb 3 2016, 10:47 PM

Addshore changed the task status from Open to Stalled.Feb 28 2018, 12:51 PM

The previous comments don't explain what/who exactly this task is stalled on ("If a report is waiting for further input (e.g. from its reporter or a third party) and can currently not be acted on"). Hence resetting task status.

daniel unsubscribed.May 11 2020, 8:17 AM

ItamarWMDE renamed this task from [Story] When using wbeditentity and the clear parameter the summary should be improved to say "Setting entity" or just "editing entity" to Improve edit summary for calls to `wbeditentities` with the `clear` paramter set.Aug 4 2022, 2:20 PM

ItamarWMDE renamed this task from Improve edit summary for calls to `wbeditentities` with the `clear` paramter set to Improve edit summary for calls to `wbeditentity` with the `clear` paramter set.

ItamarWMDE updated the task description. (Show Details)

ItamarWMDE added a subscriber: Lydia_Pintscher.

Lydia_Pintscher removed a project: Story.Aug 4 2022, 3:58 PM

Lydia_Pintscher updated the task description. (Show Details)

matej_suchanek renamed this task from Improve edit summary for calls to `wbeditentity` with the `clear` paramter set to Improve edit summary for calls to `wbeditentity` with the `clear` parameter set.Aug 5 2022, 3:27 PM

Lydia_Pintscher added a project: patch-welcome.Aug 10 2022, 8:59 AM

Lydia_Pintscher raised the priority of this task from Low to Medium.Aug 10 2022, 10:12 AM

Addshore unsubscribed.Jun 27 2023, 12:41 PM

Improve edit summary for calls to `wbeditentity` with the `clear` parameter setOpen, MediumPublicActions

Description

Related Objects

Event Timeline

Improve edit summary for calls to `wbeditentity` with the `clear` parameter set
Open, MediumPublic
Actions