[Regression] Clicking on Echo's "All notifications" does not work
Closed, ResolvedPublic
Actions

Description

Create a new account at http://en.wikipedia.beta.wmflabs.org/
Log in
Notice the "Welcome to Wikipedia..." notification
Try to open "All notifications" by clicking on the link.

Expected result
This page is loaded: http://en.wikipedia.beta.wmflabs.org/wiki/Special:Notifications

Actual result
Nothing happens

Details

	Subject	Repo	Branch	Lines +/-
	Use #pt-notifications-alert to get Special:Notifications link	mediawiki/extensions/Echo	wmf/1.26wmf22	+1 -1
	Use #pt-notifications-alert to get Special:Notifications link	mediawiki/extensions/Echo	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rMW441719e5d36b: Updated mediawiki/core Project: mediawiki/extensions/Echo…
rECHOd0ab583b9015: Use #pt-notifications-alert to get Special:Notifications link
rECHOaae891d8399d: Use #pt-notifications-alert to get Special:Notifications link
rMEXTbecb1ad8f828: Updated mediawiki/extensions Project: mediawiki/extensions/Echo…

Event Timeline

He7d3r created this task.Sep 8 2015, 2:27 PM

He7d3r raised the priority of this task from to Needs Triage.

He7d3r updated the task description. (Show Details)

He7d3r added a project: Notifications.

He7d3r subscribed.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 8 2015, 2:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Apparently the link has no href attribute:

<div class="mw-echo-ui-notificationBadgeButtonPopupWidget-footer">
    <div aria-disabled="false" class="mw-echo-ui-notificationBadgeButtonPopupWidget-footer-allnotifs oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-iconElement oo-ui-labelElement oo-ui-buttonWidget">
        <a rel="nofollow" aria-disabled="false" role="button" class="oo-ui-buttonElement-button">
            <span class="oo-ui-iconElement-icon oo-ui-icon-next"></span>
            <span class="oo-ui-labelElement-label">All notifications</span>
            <span class="oo-ui-indicatorElement-indicator"></span>
        </a>
    </div>
    <div aria-disabled="false" class="mw-echo-ui-notificationBadgeButtonPopupWidget-footer-preferences oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-iconElement oo-ui-labelElement oo-ui-buttonWidget">
        <a rel="nofollow" href="/wiki/Special:Preferences" aria-disabled="false" role="button" class="oo-ui-buttonElement-button">
            <span class="oo-ui-iconElement-icon oo-ui-icon-advanced"></span>
            <span class="oo-ui-labelElement-label">Preferences</span>
            <span class="oo-ui-indicatorElement-indicator"></span>
        </a>
    </div>
</div>

Legoktm renamed this task from Clicking on Echo's "All notifications" does not work to [Regression] Clicking on Echo's "All notifications" does not work.Sep 8 2015, 3:08 PM

Legoktm claimed this task.

Legoktm triaged this task as High priority.

Legoktm set Security to None.

Change 236799 had a related patch set uploaded (by Legoktm):
Use #pt-notifications_alert to get Special:Notifications link

https://gerrit.wikimedia.org/r/236799

gerritbot added a project: Patch-For-Review.Sep 8 2015, 3:29 PM

Legoktm edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.Sep 8 2015, 3:30 PM

Legoktm moved this task from Untriaged to Needs Review on the Collaboration-Team-Archive-2015-2016 board.

Change 236799 merged by jenkins-bot:
Use #pt-notifications-alert to get Special:Notifications link

https://gerrit.wikimedia.org/r/236799

Diffusion mentioned this in rMEXTbecb1ad8f828: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 8 2015, 9:14 PM

Mooeypoo mentioned this in rECHOaae891d8399d: Use #pt-notifications-alert to get Special:Notifications link.Sep 8 2015, 9:14 PM