Page MenuHomePhabricator
Create Task
Maniphest T112394

Copying a rendered table into VE missed a |- and other parsing issues
Closed, ResolvedPublic
Actions

Assigned To
ssastry
Authored By
• Quiddity
Sep 12 2015, 6:12 PM
Tags
Referenced Files
F2576233: Screenshot from 2015-09-12 11:00:16.png
Sep 12 2015, 6:12 PM
F2576213: Screenshot from 2015-09-12 10:30:02.png
Sep 12 2015, 6:12 PM
F2576211: Screenshot from 2015-09-12 10:39:54.png
Sep 12 2015, 6:12 PM
F2576231: Screenshot from 2015-09-12 10:52:42.png
Sep 12 2015, 6:12 PM
F2576210: Screenshot from 2015-09-12 10:45:55.png
Sep 12 2015, 6:12 PM
F2576240: Screenshot from 2015-09-12 11:02:43.png
Sep 12 2015, 6:12 PM
Subscribers
Aklapper
Esanders
Jdforrester-WMF
• Quiddity
ssastry

Description

A table is rendered correctly during preview/live-edit, but problems occur after saving.

Steps to reproduce:

  1. Using this section https://en.wikipedia.org/w/index.php?title=User:Quiddity_%28WMF%29/sandbox&oldid=680711195 (taken from an actual talkpage)
  2. Copy the entire rendered section, from above the ==RfC== header, past the table, down to anywhere below the table.
  3. paste that content into either:
    1. a VisualEditor-mode sandbox
    2. a new post in a Flow sandbox, using VE-edit-mode.
  4. It will look mostly as expected during the edit,* but shows problems with the table upon saving.

*unexpected during preview, are the ↵arrows, which don't match linebreaks in the source text.

Scenario A) example at https://en.wikipedia.org/w/index.php?title=User:Quiddity_%28WMF%29/sandbox&oldid=680707793

Preview (looks mostly good):

Screenshot from 2015-09-12 10:30:02.png (1×1 px, 312 KB)

Outcome:
Screenshot from 2015-09-12 10:45:55.png (876×1 px, 193 KB)

The main missing bit, is a crucial |-: (although it also added a jquery-tablesorter which was unexpected (by me), and many erroneous linebreaks)
Screenshot from 2015-09-12 10:39:54.png (608×1 px, 216 KB)

Scenario B) example at https://en.wikipedia.org/w/index.php?title=Topic:Sosjy6pjhih092j2&topic_showPostId=sosk8798djw6mz2k#flow-post-sosk8798djw6mz2k

Preview:

Screenshot from 2015-09-12 11:00:16.png (832×1 px, 261 KB)

Outcome:
Screenshot from 2015-09-12 10:52:42.png (832×1 px, 153 KB)

The wikitext of the outcome, has the same problems as Scenario A, but also adds an unexpected title="Sort ascending" class="headerSort" | to each of the headers:
Screenshot from 2015-09-12 11:02:43.png (832×1 px, 178 KB)

Related Objects

Event Timeline

• Quiddity created this task.Sep 12 2015, 6:12 PM
• Quiddity raised the priority of this task from to Needs Triage.
• Quiddity updated the task description. (Show Details)
• Quiddity added a project: Parsoid.
• Quiddity subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2015, 6:12 PM
ssastry added a project: VisualEditor.Sep 12 2015, 9:05 PM
ssastry set Security to None.
ssastry subscribed.Sep 12 2015, 9:12 PM

The line breaks are specific to what VE gets from the copy-paste functionality of the browsers. Parsoid is not involved there.

When I opened that sandbox in VE and then copy-pasted it onto my sandbox here, it worked just fine for me. https://www.mediawiki.org/w/index.php?title=User%3ASSastry_%28WMF%29%2FSandbox&type=revision&diff=1880770&oldid=1816970
There is jquery-tablesorter, nor is there a missing |- tag. So, I think this is probably browser specific and what VE generates on copy-paste. I used Firefox on a Ubuntu box.

What browser did you use for the copy-paste? Added the VisualEditor project in case this is known.
Also, worth trying to reproduce with a smaller test case.

• Quiddity added a comment.Sep 14 2015, 9:13 PM
In T112394#1634343, @ssastry wrote:

What browser did you use for the copy-paste? Added the VisualEditor project in case this is known.
Also, worth trying to reproduce with a smaller test case.

I'm also using Firefox in Ubuntu.
One other user, who also uses Firefox, was experiencing problems but had a different result, visible at https://en.wikipedia.org/wiki/Topic:Sor98w5yvlxnd79o but I cannot reproduce the exact error that he is getting (which omits the entire !header section, and inserts <nowiki>s throughout).

ssastry added subscribers: Esanders, Jdforrester-WMF.Sep 14 2015, 9:17 PM

I think this is VE-land issue with the HTML that is pasted in copy-paste mode. @Jdforrester-WMF, @Esanders.

Jdforrester-WMF triaged this task as Low priority.Sep 15 2015, 7:09 PM
Jdforrester-WMF added projects: VisualEditor-CopyPaste, Browser-Support-Firefox, VisualEditor-Tables.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
Alsee mentioned this in T117063: Paste in flow (and VE) inserts awkward soft-newline characters that must be manually deleted.Nov 17 2015, 2:28 PM
Esanders moved this task from Backlog to Data model on the VisualEditor-Tables board.Jan 31 2016, 2:59 PM
ssastry moved this task from Needs Triage to html2wt on the Parsoid board.Dec 18 2017, 10:01 PM
ssastry edited projects, added Parsoid-Edit-Support; removed Parsoid.Sep 20 2018, 4:28 PM
Aklapper edited projects, added Parsoid; removed Parsoid-Edit-Support.Feb 29 2020, 5:15 PM
ssastry closed this task as Resolved.Mar 9 2020, 11:43 PM
ssastry claimed this task.

https://en.wikipedia.org/w/index.php?title=User:SSastry_(WMF)/VE_Test/Sandbox&oldid=944795673

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 9 2020, 11:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits