Introduce an IDValueSnakFormatter (for datatype "ID", for HTML; perhaps we also need an implementation for wikitext output) which uses a lookup service to get the formatter URL to use for linking IDs associated with a specific property. IDValueSnakFormatter could in the future take advantage of derived values (the full URL) being present in the PropertyValueSnak, if/when this is implemented (see T112550).
IDValueSnakFormatter may or may not use a ValueFormatter internally.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Introduce SnakFormatters for ID snaks. | mediawiki/extensions/Wikibase | master | +355 -0 |
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Resolved | Bene | T95684 [Story] Format identifiers as Links | ||
| Resolved | daniel | T112760 [Task] Implement snakformatter for identifiers | ||
| Resolved | daniel | T112754 [Task] Use DataTypeDefinitions in OutputFormatSnakFormatterFactory | ||
| Resolved | daniel | T112762 [Task] Introduce a lookup service for formatter URLs based on a given property ID | ||
| · · · |
Camel case please. Either EntityIdValueSnakFormatter, if this is meant to format EntityIdValue objects. Or if this is not about entity ids, you need to be much, much more specific and avoid "id" at all, if possible.
Change 254473 had a related patch set uploaded (by Daniel Kinzler):
Introduce SnakFormatters for ID snaks.
It's HtmlIdValueSnakFormatter and WikitextIdValueSnakFormatter now. And they are formatters for the "ID" data type, as stated in the task description. I don't know how I can be more specific here.
The datatype should not be called "ID". Is this proposed somewhere? I never heard of that. This would be confusing as hell, in my opinion. It should be "identifier". The classes dealing with identifiers should also be called "HtmlIdentifierFormatter" and such.
I don't care much what it is called. IIRC, "ID" was the original proposal, but I really don't care.
What I don't see is how "identifier" is less confusing than "ID". It means the same thing, neither name provides more information or context.