Page MenuHomePhabricator

[Task] Use DataTypeDefinitions in OutputFormatSnakFormatterFactory
Closed, ResolvedPublic

Description

Change OutputFormatSnakFormatterFactory to construct a DispatchingValueSnakFormatter based on factory callbacks from DataTypeDefinitions, similar to how OutputFormatValueFormatterFactory. If possible, the fallback logic using automatic escaping used for ValueFormatters should be re-used for SnakFormatters.

OutputFormatSnakFormatterFactory should fall back to a GenericValueSnakFormatter for any datatype that has no specialized SnakFormatter associated. That GenericValueSnakFormatter would be based on a DispatchingValueFormatter provided by OutputFormatValueFormatterFactory.

Event Timeline

daniel raised the priority of this task from to Medium.
daniel updated the task description. (Show Details)
Jonas renamed this task from Change OutputFormatSnakFormatterFactory to construct a DispatchingValueSnakFormatter based on factory callbacks from DataTypeDefinitions to [Task] Change OutputFormatSnakFormatterFactory to construct a DispatchingValueSnakFormatter based on factory callbacks from DataTypeDefinitions.Nov 2 2015, 11:46 AM
Jonas set Security to None.

This is in review but no patch is linked from here?

Jonas renamed this task from [Task] Change OutputFormatSnakFormatterFactory to construct a DispatchingValueSnakFormatter based on factory callbacks from DataTypeDefinitions to [Task] Use DataTypeDefinitions in OutputFormatSnakFormatterFactory .Nov 23 2015, 3:37 PM

Change 253683 merged by jenkins-bot:
OutputFormatSnakFormatterFactory to construct SnakFormatter based on factory callbacks

https://gerrit.wikimedia.org/r/253683

daniel claimed this task.