mw-config now dosent show any styles
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Paladox
	Sep 26 2015, 12:34 PM

Description

Hi when going to mw-config it now dosent style correctly it just shows as if it is just plain and just shows text

To reproduce

Please go to mw-config on a mediawiki 1.26 wmf24 wiki.

Actual outcome:
When on that page you notice no styles have been applied from the vector skin

expect outcome:
It should shows styles it should like it was before with the vector skin styles applied.

Please fix it.

Seems it also affects whole site not just mw-config.

Affects js too.

Details

Subject	Repo	Branch	Lines +/-
Don't overwrite all available object caches	mediawiki/core	master	+3 -3
Add 'hash' object cache for installer	mediawiki/core	master	+2 -0
Revert "resourceloader: Improve caching for LESS file compilation"	mediawiki/core	master	+3 -147
Revert "resourceloader: Use FileContentsHasher in safeFileHash()"	mediawiki/core	master	+30 -1
Revert "Backport I1ff61153d and I8e4c3d5a5"	mediawiki/core	wmf/1.26wmf24	+42 -10

Customize query in gerrit

Related Objects

Mentioned In: rMWcaa637dd837a: Don't overwrite all available object caches
rMWded1a61e20e2: Add 'hash' object cache for installer

Event Timeline

Paladox created this task.Sep 26 2015, 12:34 PM

Paladox raised the priority of this task from to Needs Triage.

Paladox updated the task description. (Show Details)

Paladox added a project: MediaWiki-General.

Paladox subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2015, 12:34 PM

Paladox added a comment.Sep 26 2015, 1:32 PM

This comment was removed by Paladox.

It was probably caching problem so when I updated to the latest version of less.php the problem showed. But mw-config wont show properly since changing less.php packages.

Paladox added a project: Vector (legacy skin).Sep 26 2015, 1:54 PM

Paladox set Security to None.

Found the trace it was caused by https://gerrit.wikimedia.org/r/#/c/240316/

Change 241306 had a related patch set uploaded (by Paladox):
Revert "resourceloader: Improve caching for LESS file compilation"

https://gerrit.wikimedia.org/r/241306

gerritbot added a project: Patch-For-Review.Sep 26 2015, 2:08 PM

lcawte subscribed.Sep 26 2015, 3:18 PM

Paladox updated the task description. (Show Details)Sep 26 2015, 5:24 PM

Change 241340 had a related patch set uploaded (by Paladox):
Revert "Backport I1ff61153d and I8e4c3d5a5"

https://gerrit.wikimedia.org/r/241340

Paladox added a project: MediaWiki-ResourceLoader.Sep 26 2015, 5:25 PM

Change 241342 had a related patch set uploaded (by Paladox):
Revert "resourceloader: Use FileContentsHasher in safeFileHash()"

https://gerrit.wikimedia.org/r/241342

Change 241340 abandoned by Paladox:
Revert "Backport I1ff61153d and I8e4c3d5a5"

https://gerrit.wikimedia.org/r/241340

Unless it is a extension which is unlikely since when the wmf1.26wmf24 was created I downloaded it and uploaded it to my site then there were a few more updates to that branch and so I downloaded it and uploaded it to my site which then broke css and js.

Js only broke if you reverted one patch. So doing the other one fixed it.

Florian claimed this task.Sep 26 2015, 10:41 PM

Paladox added a comment.Sep 26 2015, 10:44 PM

This comment was removed by Paladox.

Change 241477 had a related patch set uploaded (by Florianschmidtwelzow):
Disable hash object cache for the installer

https://gerrit.wikimedia.org/r/241477

Change 241342 abandoned by Paladox:
Revert "resourceloader: Use FileContentsHasher in safeFileHash()"

https://gerrit.wikimedia.org/r/241342

Change 241477 merged by jenkins-bot:
Add 'hash' object cache for installer

https://gerrit.wikimedia.org/r/241477

Florian mentioned this in rMWded1a61e20e2: Add 'hash' object cache for installer.Sep 26 2015, 11:06 PM

Tested it on a different site and works.

Thanks for fixing it.

@Paladox: Please check the request to the styles and what error messages you get (browser, web server, ...). And please ztry to upgrade Vector and check if this helps :)

Change 241306 abandoned by Florianschmidtwelzow:
Revert "resourceloader: Improve caching for LESS file compilation"

Reason:
Fixed in I1c1938b3fac395dda5b42dd68b

https://gerrit.wikimedia.org/r/241306

Hi it works now because I was using parts of the patches I reverted. I just uploaded a new copy of files and then add the code that fixes installer and now works. Thanks for fixing.

This can now be closed.

Florian closed this task as Resolved.Sep 26 2015, 11:15 PM