Page MenuHomePhabricator
Create Task
Maniphest T114043

'View and restore deleted pages': posting a new topic, re-sorting, and Edit board actions on a page are present but don't work
Closed, ResolvedPublic
Actions

Description

Per @SBisson comment on T113668

One thing I noticed while working on this is that some features of the board are present and enabled but not working: new topic, edit description, sorting

  1. On any page with content in 'View and restore deleted pages, click to edit Board description - it 'silently fails'.
  1. Click on sorting options and click on an available selection - the page starts reloading and never finishes.

While the page is dimmed (reloading), it's still functional - e.g. you can open a topic's permalink

  1. Try to post a new topic - "Exception Caught: Invalid or virtual namespace -1 given."

Details

SubjectRepoBranchLines +/-
Hide actions when viewing a board through Special:Undeletemediawiki/extensions/Flowmaster+63 -30
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Sep 28 2015, 10:16 PM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added projects: StructuredDiscussions, Collaboration-Team-Archive-2015-2016.
Etonkovidova added subscribers: Etonkovidova, SBisson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2015, 10:16 PM
Etonkovidova renamed this task from 'View and restore deleted pages': re-sorting and Edit board actions on a page are present but don't work to 'View and restore deleted pages': posting a new topic, re-sorting, and Edit board actions on a page are present but don't work .Sep 28 2015, 10:17 PM
Etonkovidova updated the task description. (Show Details)
Etonkovidova set Security to None.
Etonkovidova mentioned this in T113668: 'View and restore deleted pages' displays broken layout for deleted Flow pages.
Etonkovidova mentioned this in T110696: Can no longer view deleted board in Special:Undelete.Sep 28 2015, 10:25 PM
SBisson claimed this task.Sep 29 2015, 3:25 PM
SBisson triaged this task as High priority.
SBisson moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.
SBisson added a project: Regression.Sep 29 2015, 4:43 PM
gerritbot subscribed.Sep 30 2015, 1:47 PM

Change 242544 had a related patch set uploaded (by Sbisson):
[WIP] Hide actions when viewing a board through Special:Undelete

https://gerrit.wikimedia.org/r/242544

gerritbot added a project: Patch-For-Review.Sep 30 2015, 1:47 PM
SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Sep 30 2015, 2:32 PM
SBisson moved this task from Needs Review to In Development on the Collaboration-Team-Archive-2015-2016 board.Sep 30 2015, 3:37 PM
Catrope subscribed.Sep 30 2015, 11:23 PM

Could T114138: 'View and restore deleted pages' displays 'No topics returned from API' be related?

SBisson added a comment.Oct 1 2015, 11:10 AM
In T114043#1691619, @Catrope wrote:

Could T114138: 'View and restore deleted pages' displays 'No topics returned from API' be related?

Very likely. I'll test it with my patch once I have fixed the other issues.

SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Oct 1 2015, 2:48 PM
gerritbot added a comment.Oct 2 2015, 3:04 AM

Change 242544 merged by jenkins-bot:
Hide actions when viewing a board through Special:Undelete

https://gerrit.wikimedia.org/r/242544

Diffusion mentioned this in rMEXTa67552191e2f: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Oct 2 2015, 3:04 AM
SBisson mentioned this in rEFLWc3b904beaaaa: Hide actions when viewing a board through Special:Undelete.Oct 2 2015, 3:05 AM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Oct 2 2015, 4:00 AM
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Oct 2 2015, 10:14 AM
Etonkovidova added a comment.Oct 2 2015, 10:49 PM

Checked the fix in betalabs.

NOTE: There is the following error for http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Undelete&target=Talk%3AET11&timestamp=20150710225615

[FLOW] No topics returned from API [_RecursiveConstructor, Object, true, jQuery.fn.init[1], "window", "< .flow-topics", "flow_topiclist_loop.partial"]

The error appears only after scrolling to the bottom of the page, so T114138: 'View and restore deleted pages' displays 'No topics returned from API' for deleted protected pages is not specific to protected pages. I edited the topic's title accordingly.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Oct 2 2015, 10:49 PM
Catrope added a comment.Oct 13 2015, 1:08 AM
In T114043#1698940, @Etonkovidova wrote:

Checked the fix in betalabs.

NOTE: There is the following error for http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Undelete&target=Talk%3AET11&timestamp=20150710225615

[FLOW] No topics returned from API [_RecursiveConstructor, Object, true, jQuery.fn.init[1], "window", "< .flow-topics", "flow_topiclist_loop.partial"]

The error appears only after scrolling to the bottom of the page, so T114138: 'View and restore deleted pages' displays 'No topics returned from API' for deleted protected pages is not specific to protected pages. I edited the topic's title accordingly.

Hah, it looks like the infinite scroll code is trying to load more topics. I'll file a low-prio bug for that, because it's not causing any user-facing problems.

Catrope closed this task as Resolved.Oct 13 2015, 1:10 AM
Catrope mentioned this in T115295: Scrolling to the bottom of undelete preview causes exception in infinite scroll code.
In T114043#1720451, @Catrope wrote:

I'll file a low-prio bug for that

T115295: Scrolling to the bottom of undelete preview causes exception in infinite scroll code

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL