Page MenuHomePhabricator
Create Task
Maniphest T110696

Can no longer view deleted board in Special:Undelete
Closed, ResolvedPublic
Actions

Description

This is a regression from https://gerrit.wikimedia.org/r/#/c/233066/ .

flow bug 2.PNG (209×1 px, 21 KB)

See also T110679: MediaWiki error for deleted Flow board, when clicking 'Show changes'

Details

SubjectRepoBranchLines +/-
Show real output instead of placeholder HTMLmediawiki/extensions/Flowmaster+62 -43
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Mattflaschen-WMF created this task.Aug 28 2015, 4:30 PM
• Mattflaschen-WMF raised the priority of this task from to Unbreak Now!.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added projects: StructuredDiscussions, Collaboration-Team-Archive-2015-2016.
• Mattflaschen-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2015, 4:30 PM
• Mattflaschen-WMF added a project: Regression.Aug 28 2015, 4:30 PM
• Mattflaschen-WMF mentioned this in T110679: MediaWiki error for deleted Flow board, when clicking 'Show changes'.
Luke081515 subscribed.Aug 28 2015, 10:08 PM
• DannyH lowered the priority of this task from Unbreak Now! to Medium.Aug 31 2015, 5:19 PM
• DannyH subscribed.
Catrope raised the priority of this task from Medium to High.Sep 1 2015, 5:55 PM
Catrope set Security to None.
matthiasmullie claimed this task.Sep 3 2015, 10:29 AM
matthiasmullie moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.
• DannyH added a project: OKR-Work.Sep 3 2015, 4:38 PM
gerritbot subscribed.Sep 4 2015, 1:18 PM

Change 236016 had a related patch set uploaded (by Matthias Mullie):
[WIP] Show real output instead of placeholder HTML

https://gerrit.wikimedia.org/r/236016

gerritbot added a project: Patch-For-Review.Sep 4 2015, 1:18 PM
matthiasmullie moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Sep 8 2015, 3:35 PM
SBisson moved this task from Needs Review to Code Review Started on the Collaboration-Team-Archive-2015-2016 board.Sep 14 2015, 1:47 PM
SBisson claimed this task.Sep 16 2015, 6:52 PM
SBisson moved this task from Code Review Started to In Development on the Collaboration-Team-Archive-2015-2016 board.
SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Sep 16 2015, 8:39 PM
matthiasmullie moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Sep 18 2015, 7:11 AM
gerritbot added a comment.Sep 18 2015, 7:15 AM

Change 236016 merged by jenkins-bot:
Show real output instead of placeholder HTML

https://gerrit.wikimedia.org/r/236016

Diffusion mentioned this in rMEXTe632ca3df6af: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Sep 18 2015, 7:15 AM
Jdforrester-WMF mentioned this in rEFLW09d031c991a8: Show real output instead of placeholder HTML.Sep 18 2015, 7:15 AM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 18 2015, 8:00 AM
Etonkovidova subscribed.Sep 23 2015, 1:30 AM

Checked in betalabs - one case seems still to be producing an error

[81586032] /w/index.php?title=Special:Undelete&action=submit MWException from line 791 of /srv/mediawiki/php-master/includes/diff/DifferenceEngine.php: Diff not implemented for Flow\Content\BoardContent; override generateContentDiffBody to fix this.

Backtrace:

#0 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(1087): DifferenceEngine->generateContentDiffBody(WikitextContent, Flow\Content\BoardContent)
#1 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(953): SpecialUndelete->showDiff(Revision, Revision)
#2 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(807): SpecialUndelete->showRevision(string)
#3 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(384): SpecialUndelete->execute(NULL)
#4 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(553): SpecialPage->run(NULL)
#5 /srv/mediawiki/php-master/includes/MediaWiki.php(249): SpecialPageFactory::executePath(Title, RequestContext)
#6 /srv/mediawiki/php-master/includes/MediaWiki.php(682): MediaWiki->performRequest()
#7 /srv/mediawiki/php-master/includes/MediaWiki.php(476): MediaWiki->main()
#8 /srv/mediawiki/php-master/index.php(41): MediaWiki->run()
#9 /srv/mediawiki/w/index.php(3): include(string)
#10 {main}

It might be a specific case that can be split into a separate bug. The following cases do not give any errors:

  • normal (not Talk pages)
  • Talk pages (not LQT)
  • Flow pages
Etonkovidova added a comment.Sep 24 2015, 9:52 PM
  1. Clicking 'Show changes' on http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Undelete&target=Talk%3AET11&timestamp=20150710225615 gives http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Undelete&action=submit

[66c40915] /w/index.php?title=Special:Undelete&action=submit MWException from line 786 of /srv/mediawiki/php-master/includes/diff/DifferenceEngine.php: Diff not implemented for Flow\Content\BoardContent; override generateContentDiffBody to fix this.

Backtrace:

#0 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(1087): DifferenceEngine->generateContentDiffBody(Flow\Content\BoardContent, Flow\Content\BoardContent)
#1 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(953): SpecialUndelete->showDiff(Revision, Revision)
#2 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(807): SpecialUndelete->showRevision(string)
#3 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(384): SpecialUndelete->execute(NULL)
#4 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(553): SpecialPage->run(NULL)
#5 /srv/mediawiki/php-master/includes/MediaWiki.php(249): SpecialPageFactory::executePath(Title, RequestContext)
#6 /srv/mediawiki/php-master/includes/MediaWiki.php(682): MediaWiki->performRequest()
#7 /srv/mediawiki/php-master/includes/MediaWiki.php(476): MediaWiki->main()
#8 /srv/mediawiki/php-master/index.php(41): MediaWiki->run()
#9 /srv/mediawiki/w/index.php(3): include(string)
#10 {main}

  1. There is also T113668.
  1. Deleting and viewing/restoring another user's User talk page seems to produce a specific error

Error
An error has occurred.

Return to Main Page

[ebd47fb1] /w/index.php?title=Special:Undelete&action=submit Flow\Exception\FlowException from line 88 of /srv/mediawiki/php-master/extensions/Flow/includes/BoardMover.php: Main discussion workflow for 131863 not found

Backtrace:

#0 /srv/mediawiki/php-master/extensions/Flow/Hooks.php(1560): Flow\BoardMover->prepareMove(integer, Title)
#1 /srv/mediawiki/php-master/includes/Hooks.php(204): FlowHooks::onArticleUndelete(Title, boolean, string, integer)
#2 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(636): Hooks::run(string, array)
#3 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(385): PageArchive->undeleteRevisions(array, boolean, string)
#4 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(1655): PageArchive->undelete(array, string, array, boolean, User)
#5 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(825): SpecialUndelete->undelete()
#6 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(384): SpecialUndelete->execute(NULL)
#7 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(553): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-master/includes/MediaWiki.php(249): SpecialPageFactory::executePath(Title, RequestContext)
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(682): MediaWiki->performRequest()
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(476): MediaWiki->main()
#11 /srv/mediawiki/php-master/index.php(41): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include(string)
#13 {main}

Etonkovidova moved this task from QA Review to In Development on the Collaboration-Team-Archive-2015-2016 board.Sep 24 2015, 9:53 PM
SBisson added a comment.Sep 25 2015, 4:40 PM
  1. Deleting and viewing/restoring another user's User talk page seems to produce a specific error

I can't reproduce it locally. What did you do exactly?

SBisson added a comment.Sep 25 2015, 4:43 PM

/srv/mediawiki/php-master/includes/diff/DifferenceEngine.php: Diff not implemented for Flow\Content\BoardContent; override generateContentDiffBody to fix this.

Based by this message, it is unlikely that this ever worked. I would suggest creating a new ticket for this so we can define what diff really means at the board level and prioritize accordingly.

• Mattflaschen-WMF added a comment.Sep 25 2015, 5:50 PM

Show changes is T110679: MediaWiki error for deleted Flow board, when clicking 'Show changes'.

Etonkovidova added a comment.Sep 25 2015, 9:03 PM

All issues in my comments seem to be addressed by already filed tickets

1

T110679

3

T104591
Deleted wikitext Talk page cannot be restored after EnableFlow creates the same page

Per @DannyH T113668 'View and restore deleted pages' displays broken layout for deleted Flow pages- is a blocker for this ticket and should be fixed.

Etonkovidova added a subtask: T113668: 'View and restore deleted pages' displays broken layout for deleted Flow pages.Sep 25 2015, 9:04 PM
SBisson moved this task from In Development to QA Review on the Collaboration-Team-Archive-2015-2016 board.Sep 28 2015, 11:17 AM
Etonkovidova added a comment.Sep 28 2015, 10:25 PM
  • T113668 'View and restore deleted pages' displays broken layout for deleted Flow pages- which was a blocker for this ticket is fixed.

'View and restore deleted pages': posting a new topic, re-sorting, and Edit board actions on a page are present but don't work

  • The following ticket is still Open

T110679
MediaWiki error for deleted Flow board, when clicking 'Show changes'.

  • Any clicking on 'Show changes' will give the error
[4ab6413c] /w/index.php?title=Special:Undelete&action=submit MWException from line 786 of /srv/mediawiki/php-master/includes/diff/DifferenceEngine.php: Diff not implemented for Flow\Content\BoardContent; override generateContentDiffBody to fix this.

Backtrace:

#0 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(1087): DifferenceEngine->generateContentDiffBody(Flow\Content\BoardContent, Flow\Content\BoardContent)
#1 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(953): SpecialUndelete->showDiff(Revision, Revision)
#2 /srv/mediawiki/php-master/includes/specials/SpecialUndelete.php(807): SpecialUndelete->showRevision(string)
#3 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(384): SpecialUndelete->execute(NULL)
#4 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(553): SpecialPage->run(NULL)
#5 /srv/mediawiki/php-master/includes/MediaWiki.php(249): SpecialPageFactory::executePath(Title, RequestContext)
#6 /srv/mediawiki/php-master/includes/MediaWiki.php(682): MediaWiki->performRequest()
#7 /srv/mediawiki/php-master/includes/MediaWiki.php(476): MediaWiki->main()
#8 /srv/mediawiki/php-master/index.php(41): MediaWiki->run()
#9 /srv/mediawiki/w/index.php(3): include(string)
#10 {main}
Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Sep 28 2015, 10:43 PM
• DannyH closed this task as Resolved.Sep 30 2015, 4:56 PM
• DannyH closed subtask T113668: 'View and restore deleted pages' displays broken layout for deleted Flow pages as Resolved.Sep 30 2015, 5:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL