Page MenuHomePhabricator
Create Task
Maniphest T113668

'View and restore deleted pages' displays broken layout for deleted Flow pages
Closed, ResolvedPublic
Actions

Description

Viewing a revision of a deleted Flow board page - e.g. following a link <a href="/w/index.php?title=Special:Undelete&amp;target=Talk%3AET11&amp;timestamp=20150710225615" title="Special:Undelete">22:56, 10 July 2015</a> on a page
http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Undelete&target=Talk%3AET11

will display a broken layout on a page http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Undelete&target=Talk%3AET11&timestamp=20150710225615

Screen Shot 2015-09-24 at 2.20.40 PM.png (619×617 px, 65 KB)

Details

SubjectRepoBranchLines +/-
Fix Flow board layout on Special:Undeletemediawiki/extensions/Flowmaster+5 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Sep 24 2015, 9:44 PM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added projects: StructuredDiscussions, Collaboration-Team-Archive-2015-2016.
Etonkovidova subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2015, 9:44 PM
Etonkovidova renamed this task from 'View a restore deleted pages' displays broken layout for deleted Flow pages to 'View and restore deleted pages' displays broken layout for deleted Flow pages.Sep 24 2015, 9:45 PM
Etonkovidova set Security to None.
Etonkovidova mentioned this in T110696: Can no longer view deleted board in Special:Undelete.Sep 24 2015, 9:52 PM
• Mattflaschen-WMF moved this task from Untriaged to Ready for pickup on the Collaboration-Team-Archive-2015-2016 board.Sep 25 2015, 5:58 PM
Etonkovidova added a parent task: T110696: Can no longer view deleted board in Special:Undelete.Sep 25 2015, 9:04 PM
SBisson claimed this task.Sep 25 2015, 10:01 PM
SBisson triaged this task as High priority.
SBisson moved this task from Ready for pickup to In Development on the Collaboration-Team-Archive-2015-2016 board.
gerritbot subscribed.Sep 28 2015, 2:44 PM

Change 241655 had a related patch set uploaded (by Sbisson):
Fix Flow board layout on Special:Undelete

https://gerrit.wikimedia.org/r/241655

gerritbot added a project: Patch-For-Review.Sep 28 2015, 2:44 PM
SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Sep 28 2015, 2:45 PM
SBisson moved this task from Needs Review to Code Review Started on the Collaboration-Team-Archive-2015-2016 board.Sep 28 2015, 5:20 PM
gerritbot added a comment.Sep 28 2015, 5:24 PM

Change 241655 merged by jenkins-bot:
Fix Flow board layout on Special:Undelete

https://gerrit.wikimedia.org/r/241655

SBisson mentioned this in rEFLW36214dc8f0e9: Fix Flow board layout on Special:Undelete.Sep 28 2015, 5:24 PM
Diffusion mentioned this in rMEXT4c3180b5f8ba: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Sep 28 2015, 5:24 PM
SBisson moved this task from Code Review Started to QA Review on the Collaboration-Team-Archive-2015-2016 board.Sep 28 2015, 5:24 PM
SBisson merged a task: T107580: Interface looks broken in Special:Undelete.Sep 28 2015, 7:58 PM
SBisson added subscribers: Catrope, matthiasmullie.
SBisson added a comment.Sep 28 2015, 8:57 PM

One thing I noticed while working on this is that some features of the board are present and enabled but not working: new topic, edit description, sorting

Etonkovidova mentioned this in T114043: 'View and restore deleted pages': posting a new topic, re-sorting, and Edit board actions on a page are present but don't work .Sep 28 2015, 10:16 PM
Etonkovidova added a comment.Sep 28 2015, 10:18 PM

@ SBisson - I filed T114043.

The fix for 'View and restore deleted pages' display works in beta.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Sep 28 2015, 10:19 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 10:13 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:48 AM
• DannyH closed this task as Resolved.Sep 30 2015, 5:17 PM
• DannyH subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL