Page MenuHomePhabricator
Create Task
Maniphest T114288

Exception in module-execute in module mediawiki.page.watch.ajax:
Closed, ResolvedPublic
Actions

Description

on wikidata, as well as other group1 wikis like English Wikisource (the main page with really no wikidata stuff), I am getting a js error.

this especially affects editing on Wikidata, but also other stuff

Exception in module-execute in module mediawiki.page.watch.ajax:
load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=z8ML1kIu:177 TypeError: Cannot set property 'watch' of undefined TypeError: Cannot set property 'watch' of undefined

at https://en.wikisource.org/w/load.php?debug=false&lang=en&modules=ext.echo.i…s%2Csite%7Cschema.NavigationTiming&skin=vector&version=76431d02efea:71:569
at mw.loader.implement.tooltip-ca-unwatch (https://en.wikisource.org/w/load.php?debug=false&lang=en&modules=ext.echo.i…s%2Csite%7Cschema.NavigationTiming&skin=vector&version=76431d02efea:72:704)
at Object.<anonymous> (https://en.wikisource.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=z8ML1kIu:162:659)
at jQuery.Callbacks.fire (https://en.wikisource.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=z8ML1kIu:45:122)
at Object.jQuery.Callbacks.self.add [as done] (https://en.wikisource.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=z8ML1kIu:45:656)
at Object.jQuery.extend.Deferred.promise.always (https://en.wikisource.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=z8ML1kIu:46:874)
at mw.loader.runScript (https://en.wikisource.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=z8ML1kIu:162:546)
at mw.loader.checkCssHandles (https://en.wikisource.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=z8ML1kIu:163:319)
at execute (https://en.wikisource.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=z8ML1kIu:164:25)
at handlePending (https://en.wikisource.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=z8ML1kIu:160:192)

Details

SubjectRepoBranchLines +/-
Restore dependency on module 'mediawiki.page.startup'mediawiki/corewmf/1.30.0-wmf.2+1 -0
Restore dependency on module 'mediawiki.page.startup'mediawiki/coremaster+1 -0
mediawiki.page.watch.ajax: Add dependency on mediawiki.page.startupmediawiki/coremaster+1 -0
mediawiki.page.watch.ajax: Add dependency on mediawiki.page.startupmediawiki/corewmf/1.27.0-wmf.1+1 -0
Customize query in gerrit

Related Objects

Event Timeline

aude created this task.Sep 30 2015, 6:37 PM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude added a project: MediaWiki-JavaScript.
aude subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2015, 6:37 PM
aude added a comment.Sep 30 2015, 6:38 PM

with debug=true, stuff seems to work

aude added a comment.Sep 30 2015, 6:39 PM

also, I don't always get the error

• mmodell subscribed.Sep 30 2015, 6:44 PM

I've rolled back the deployment of 1.27.0-wmf.1, we need to recreate this on testwiki if possible.

• mmodell triaged this task as Unbreak Now! priority.Sep 30 2015, 6:44 PM
greg edited projects, added JavaScript, MediaWiki-General; removed MediaWiki-JavaScript.Sep 30 2015, 6:46 PM
greg set Security to None.
• mmodell added a project: MediaWiki-User-Interface.Sep 30 2015, 6:46 PM
aude added a comment.Sep 30 2015, 6:50 PM

can reproduce on test.wikidata on https://test.wikidata.org/wiki/Q22

(though I had no issues earlier today editing the item)

gerritbot subscribed.Sep 30 2015, 7:11 PM

Change 242646 had a related patch set uploaded (by Krinkle):
mediawiki.page.watch.ajax: Add dependency on mediawiki.page.startup

https://gerrit.wikimedia.org/r/242646

gerritbot added a project: Patch-For-Review.Sep 30 2015, 7:11 PM
Krinkle claimed this task.Sep 30 2015, 7:11 PM
Krinkle removed a project: Patch-For-Review.
Krinkle removed a subscriber: gerritbot.
gerritbot added a comment.Sep 30 2015, 7:11 PM

Change 242647 had a related patch set uploaded (by Krinkle):
mediawiki.page.watch.ajax: Add dependency on mediawiki.page.startup

https://gerrit.wikimedia.org/r/242647

gerritbot added a project: Patch-For-Review.Sep 30 2015, 7:11 PM
Krinkle closed this task as Resolved.Sep 30 2015, 7:20 PM
Krinkle edited projects, added Regression; removed MediaWiki-General.
gerritbot added a comment.Sep 30 2015, 7:21 PM

Change 242647 merged by jenkins-bot:
mediawiki.page.watch.ajax: Add dependency on mediawiki.page.startup

https://gerrit.wikimedia.org/r/242647

Krinkle mentioned this in rMW53edbe109065: mediawiki.page.watch.ajax: Add dependency on mediawiki.page.startup.Sep 30 2015, 7:24 PM
revi removed a project: Patch-For-Review.Sep 30 2015, 11:01 PM
gerritbot added a comment.Oct 1 2015, 12:27 AM

Change 242646 merged by jenkins-bot:
mediawiki.page.watch.ajax: Add dependency on mediawiki.page.startup

https://gerrit.wikimedia.org/r/242646

Krinkle mentioned this in rMWf177e40ac83e: mediawiki.page.watch.ajax: Add dependency on mediawiki.page.startup.Oct 1 2015, 12:28 AM
ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)), MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)), MW-1.27-release-notes.Oct 1 2015, 5:02 PM
gerritbot added a comment.May 23 2017, 6:01 PM

Change 355256 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/core@master] Restore dependency on module 'mediawiki.page.startup'

https://gerrit.wikimedia.org/r/355256

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptMay 23 2017, 6:01 PM
gerritbot edited projects, added Patch-For-Review; removed MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)).May 23 2017, 6:01 PM
gerritbot added a comment.May 23 2017, 6:49 PM

Change 355256 merged by jenkins-bot:
[mediawiki/core@master] Restore dependency on module 'mediawiki.page.startup'

https://gerrit.wikimedia.org/r/355256

ReleaseTaggerBot added a project: MW-1.30-release-notes.May 23 2017, 7:00 PM
Fomafix edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.30-release-notes, Patch-For-Review, MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).May 23 2017, 7:11 PM
gerritbot added a comment.May 24 2017, 3:20 PM

Change 355437 had a related patch set uploaded (by Krinkle; owner: Fomafix):
[mediawiki/core@wmf/1.30.0-wmf.2] Restore dependency on module 'mediawiki.page.startup'

https://gerrit.wikimedia.org/r/355437

gerritbot added a project: Patch-For-Review.May 24 2017, 3:20 PM
gerritbot added a comment.May 24 2017, 3:33 PM

Change 355437 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.2] Restore dependency on module 'mediawiki.page.startup'

https://gerrit.wikimedia.org/r/355437

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 24 2017, 4:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL