Seems the issue is in the python module mwclient: https://github.com/mwclient/mwclient.git

I have filled https://github.com/mwclient/mwclient/issues/98

Once fixed, would need someone to git pull the repo and reinstall the module on tools-labs.

In T114365#1693219, @hashar wrote:

Seems the issue is in the python module mwclient

Also see T114349 ?

Just a question: the change was to go from version number such as 1.26wmf24 and now mwclient should probably support also number such as 1.27.0-wmf.1 ?

Yup, it needs to support Semantic versioning. There is a python module for that, and probably others:

In T67306#683821, @hashar wrote:

Relative python awesomeness: there is a python module that support the semantic versioning spec.

Pypi: https://pypi.python.org/pypi/semantic_version/
Doc: http://pythonhosted.org/semantic_version/

In T114365#1693227, @hashar wrote:

Merged in since I filled the upstream issue.

Latest mwclient doesn't crash. The tool labs install of mwclient is from 2011.

tools.yifeibot@tools-bastion-02:~$ ls -alh /usr/share/pyshared/mwclient/
total 80K
drwxr-xr-x  2 root root 4.0K Apr 22 06:11 .
drwxr-xr-x 41 root root 4.0K Jun  9 10:22 ..
-rw-r--r--  1 root root  18K Apr 10  2011 client.py
-rw-r--r--  1 root root 2.5K Apr 10  2011 compatibility.py
-rw-r--r--  1 root root  847 Apr 10  2011 errors.py
-rw-r--r--  1 root root 2.1K Apr 10  2011 ex.py
-rw-r--r--  1 root root 6.9K Apr 10  2011 http.py
-rw-r--r--  1 root root 1.3K Apr 10  2011 __init__.py
-rw-r--r--  1 root root 6.5K Apr 10  2011 listing.py
-rw-r--r--  1 root root 3.4K Apr 10  2011 page_nowriteapi.py
-rw-r--r--  1 root root  12K Apr 10  2011 page.py
-rw-r--r--  1 root root 3.6K Apr 10  2011 upload.py

@zhuyifei1999 that's good news! Can you point me to an up-to-date .deb of that tool? (meanwhile, I will google :) )

Maybe it has been installed via git clone + python setup.py install ?

No, it comes from our repo:

Package python-mwclient:                 
i   0.6.5-1                                                          trusty-wikimedia                              1001

I built python-mwclient_0.8.0~dev1-1_all.deb and provided it on carbon. I also made the inclusion of python-mwclient explicit on tools exec nodes in the attached patch.

So... once we get some puppet runs (20 minutes or so) I can restart the bots and things should/may/might work better.

Note that python-mwclient_0.8.0~dev1-1_all.deb was built directly out of the github source at https://github.com/mwclient/mwclient. I did not bother to import the source into gerrit since I didn't make any changes.

The .deb was built with

$ python setup.py --command-packages=stdeb.command bdist_deb

Just for the record, this SAL tool has been chugging along just fine: https://tools.wmflabs.org/sal/production

Morebots is now re-deployed using a virtualenv rather than using system packages. The logging seems to have become significantly more verbose, but this is less urgent to fix.

Yay. Should we kill the package finally now?

Can y'all open a new task for whatever morebots refactoring you're doing, and then close this one? I think the immediate issue associated with this bug is resolved, twice :)

In T114365#1693281, @hashar wrote:

Yup, it needs to support Semantic versioning. There is a python module for that, and probably others:

It cannot really use such a package because it needs to support both the correct semantic versioning style (1.27.0-wmf.1), and the old-style (1.26wmf24). Anyways, both the latest development version (0.8) and the whole 0.7.x series of mwclient should handle this fine (by just checking the major and minor parts).

Note that it's currently not running under a virtualenv (due to miscommunication, @Andrew and I were working on it in parallel and the updated debian-packaged was deployed around the same time).

means that mwclient is broken right now on labs?

In T114365#1699308, @Steinsplitter wrote:

means that mwclient is broken right now on labs?

@Andrew fixed it