Page MenuHomePhabricator

Zerobanner extension needlessly pulls in entire oojs ui library
Closed, ResolvedPublic

Description

It should only need to do that when you actually navigate to the route....

Details

Related Gerrit Patches:
mediawiki/extensions/ZeroBanner : wmf/1.27.0-wmf.2Defer loading of ZeroOverlay until needed
mediawiki/extensions/ZeroBanner : masterDefer loading of ZeroOverlay until needed

Event Timeline

Jdlrobson created this task.Oct 1 2015, 7:48 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: ZeroBanner.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2015, 7:48 PM

Change 243014 had a related patch set uploaded (by Jdlrobson):
Defer loading of oojs ui on zero banners until needed

https://gerrit.wikimedia.org/r/243014

Jdlrobson triaged this task as High priority.Oct 1 2015, 8:16 PM
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson set Security to None.

Per https://phabricator.wikimedia.org/T114416#1698102, I'm going to check and see if we can eliminate the OOjs-UI code altogether from Zero as it's currently not being used.

It would be great if this change could ride the train Monday. I'm not sure how much of our traffic comes from zero but it would be interesting to see that in our performance graphs if it's significant.

I got the go-ahead from Dan to remove ZeroInfo.js completely, which should allow us to completely remove OOjs-UI as a dependency. I'm reviewing your patch right now (there are some other issues), but feel free to start removing OOjs stuff for the next patch set @Jdlrobson

Feedback waiting on the patch.

Change 244737 had a related patch set uploaded (by Yurik):
Defer loading of ZeroOverlay until needed

https://gerrit.wikimedia.org/r/244737

Change 243014 merged by jenkins-bot:
Defer loading of ZeroOverlay until needed

https://gerrit.wikimedia.org/r/243014

Jdlrobson closed this task as Resolved.Oct 9 2015, 8:06 PM

Change 244737 merged by jenkins-bot:
Defer loading of ZeroOverlay until needed

https://gerrit.wikimedia.org/r/244737