| Ryasmeen | |
| Oct 7 2015, 7:56 PM |
| F2716382: pasted_file | |
| Oct 13 2015, 1:12 PM |
| F2664798: Screen Shot 2015-10-07 at 12.53.21 PM.png | |
| Oct 7 2015, 7:56 PM |
Steps to reproducible:
2.Select and image
3.No w from the Details dialog change the name of the image to make it customized
4.Click on "Save" on the dialog
Observed Result:
A not so understandable error "<api-error-titleblacklist-custom-imagename>" shows up on the dialog
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | matmarex | T115260 Provide precise information for errors caused by title blacklist in upload image dialog | |||
| Resolved | matmarex | T114940 Trying to upload image under blacklisted title in the upload image dialog throws error "<api-error-titleblacklist-custom-imagename>" |
Change 244429 had a related patch set uploaded (by Prtksxna):
i18n: Add message api-error-titleblacklist-custom-imagename
Change 244429 abandoned by Bartosz Dziewoński:
i18n: Add message api-error-titleblacklist-custom-imagename
Reason:
Different approach needed.
Change 244512 had a related patch set uploaded (by Bartosz Dziewoński):
mw.Upload: Refactor error handling for the umpteenth time
The patch above does not fix the issue yet (we're still not handling TitleBlacklist errors), but it lays some groundwork and makes the error message return all available information (such as Unknown error: "{"servedby":"deployment-mediawiki01","error":{"code":"senselessimagename","info":"TitleBlacklist prevents this title from being created","filekey":"13i5i0u8vv8w.5sc2g2.1252.jpg","sessionkey":"13i5i0u8vv8w.5sc2g2.1252.jpg","invalidparameter":"filename","*":"See http://commons.wikimedia.beta.wmflabs.org/w/api.php for API usage"}}".), which does at least mention that "TitleBlacklist prevents this title from being created".
Change 244676 had a related patch set uploaded (by Bartosz Dziewoński):
mediawiki.Upload.BookletLayout: Handle errors from TitleBlacklist (HACK)
It seems to be that devising and introducing a sane, non-hacky method to handle TitleBlacklist-blocked file names is something we should've planned at least several weeks in advance :/
I filed T115260 to track further work on this. Let's first get the patches here merged quickly to give our users not-entirely-shitty experience.
Change 244512 merged by jenkins-bot:
mw.Upload: Refactor error handling for the umpteenth time
Change 244676 merged by jenkins-bot:
mediawiki.Upload.BookletLayout: Handle errors from TitleBlacklist (HACK)