Page MenuHomePhabricator
Create Task
Maniphest T115822

Special:Upload shouldn't try stashing files for anonymous users
Closed, ResolvedPublic
Actions

Description

Uploading a file on my dev wiki not logged in...

Why must files belong to users? What's wrong with Anons?

[581c4356] /wiki/Special:Upload UploadStashNotLoggedInException from line 272 of /var/www/wiki/mediawiki/core/includes/upload/UploadStash.php: UploadStash::stashFile No user is logged in, files must belong to users

Backtrace:

#0 /var/www/wiki/mediawiki/core/includes/upload/UploadBase.php(922): UploadStash->stashFile(string, string)
#1 /var/www/wiki/mediawiki/core/includes/upload/UploadBase.php(935): UploadBase->stashFile()
#2 /var/www/wiki/mediawiki/core/includes/upload/UploadBase.php(944): UploadBase->stashFileGetKey()
#3 /var/www/wiki/mediawiki/core/includes/specials/SpecialUpload.php(359): UploadBase->stashSession()
#4 /var/www/wiki/mediawiki/core/includes/specials/SpecialUpload.php(473): SpecialUpload->showUploadWarning(array)
#5 /var/www/wiki/mediawiki/core/includes/specials/SpecialUpload.php(197): SpecialUpload->processUpload()
#6 /var/www/wiki/mediawiki/core/includes/specialpage/SpecialPage.php(384): SpecialUpload->execute(NULL)
#7 /var/www/wiki/mediawiki/core/includes/specialpage/SpecialPageFactory.php(553): SpecialPage->run(NULL)
#8 /var/www/wiki/mediawiki/core/includes/MediaWiki.php(248): SpecialPageFactory::executePath(Title, RequestContext)
#9 /var/www/wiki/mediawiki/core/includes/MediaWiki.php(668): MediaWiki->performRequest()
#10 /var/www/wiki/mediawiki/core/includes/MediaWiki.php(474): MediaWiki->main()
#11 /var/www/wiki/mediawiki/core/index.php(41): MediaWiki->run()
#12 {main}

Details

SubjectRepoBranchLines +/-
Instruct stashed upload failures to reupload filemediawiki/coremaster+10 -4
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Oct 18 2015, 9:33 PM
Reedy raised the priority of this task from to Needs Triage.
Reedy updated the task description. (Show Details)
Reedy added projects: Multimedia, MediaWiki-Uploading.
Reedy subscribed.
Restricted Application added subscribers: Steinsplitter, Matanya, Aklapper. · View Herald TranscriptOct 18 2015, 9:33 PM
Reedy mentioned this in T115813: Thumbnail missing for PDF file.Oct 18 2015, 9:38 PM
matmarex subscribed.Oct 18 2015, 9:50 PM

Stashed files must belong to users because the database schema doesn't allow otherwise.

Special:Upload shouldn't try stashing files when you're anonymous, I guess.

matmarex unsubscribed.Oct 18 2015, 9:50 PM
matmarex renamed this task from Why must files belong to users? to Why must stashed files belong to users?.Oct 18 2015, 10:08 PM
matmarex set Security to None.
Tgr subscribed.Oct 19 2015, 5:18 AM

The stash is private (has to be; at this point the file has no license yet). How do you provide private access to an anonymous user? I guess it could be done via some token system, but it's not a trivial change.

Reedy added a subscriber: matmarex.Oct 19 2015, 9:54 AM
In T115822#1733798, @Tgr wrote:

The stash is private (has to be; at this point the file has no license yet). How do you provide private access to an anonymous user? I guess it could be done via some token system, but it's not a trivial change.

In T115822#1733615, @matmarex wrote:

Special:Upload shouldn't try stashing files when you're anonymous, I guess.

I guess that should be the minimal fix; it shouldn't end in an exception. Whether anonymous users can actually "use" the stash is up for debate, and something that can be worked on longer term

Tgr added a comment.Oct 20 2015, 1:24 AM
In T115822#1733615, @matmarex wrote:

Special:Upload shouldn't try stashing files when you're anonymous, I guess.

Does it even work (when you are logged in)? The purpose seems to be to be able repost the form after a warning without reuploading the file, but I just get an error message about empty files when I try to do that.

Reedy added a comment.Oct 20 2015, 7:20 AM

Yeah, it seemed to be working with the PDF from T115813. I think it failed, as the pdf was taking a long time to process, and when I went back to the tab, it'd lost session data

matmarex renamed this task from Why must stashed files belong to users? to Special:Upload shouldn't try stashing files for anonymous users.Oct 23 2015, 12:30 AM
Reedy merged a task: T68115: anonymous upload gives UploadStashNotLoggedInException.Nov 15 2015, 1:50 PM
Reedy added subscribers: MarkTraceur, Bawolff, • Fabrice_Florin and 2 others.
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 15 2015, 1:50 PM
Reedy removed a subscriber: • wikibugs-l-list.Dec 10 2015, 11:00 PM
MarkTraceur triaged this task as Medium priority.Dec 21 2015, 3:22 PM
MarkTraceur moved this task from Untriaged to Triaged on the Multimedia board.Dec 5 2016, 9:42 PM
MarkTraceur unsubscribed.Jan 27 2017, 10:16 PM
saturn_mimas subscribed.Feb 13 2017, 10:33 AM
MarkTraceur moved this task from Triaged to Next up on the Multimedia board.Jun 5 2017, 3:27 PM
gerritbot subscribed.Jul 17 2017, 2:26 PM

Change 365607 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/core@master] Instruct stashed upload failures to reupload file

https://gerrit.wikimedia.org/r/365607

gerritbot added a project: Patch-For-Review.Jul 17 2017, 2:26 PM
matthiasmullie subscribed.Jul 17 2017, 2:27 PM

By now, this exception no longer happens and you'll just see the form to reupload the file & correct the description.
I've submitted another patch that'll just change the warning message, instructing those where a stash failed to reupload their file as well.

matthiasmullie claimed this task.Jul 17 2017, 2:28 PM
matthiasmullie moved this task from Next up to Needs code review on the Multimedia board.
gerritbot added a comment.Sep 14 2017, 7:46 PM

Change 365607 merged by jenkins-bot:
[mediawiki/core@master] Instruct stashed upload failures to reupload file

https://gerrit.wikimedia.org/r/365607

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).Sep 14 2017, 8:00 PM
matthiasmullie closed this task as Resolved.Sep 15 2017, 11:54 AM
Tchanders mentioned this in T233723: Error trying to anonymously upload files in VisualEditor: UploadStashNotLoggedInException or apierror-missingparam-one-of.May 23 2023, 5:23 PM
Maintenance_bot removed a project: Patch-For-Review.May 23 2023, 5:30 PM
Tchanders mentioned this in T331578: File upload defaults for Temporary account should match those for anon users.May 24 2023, 3:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL