animation length could be slightly decreased.
Wikimedia Design uses Ease-in as a timing function for all animations. drawers should use the same.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Change the drawer animation type | mediawiki/extensions/MobileFrontend | master | +1 -2 |
Revisions and Commits
Revisions and Commits
| Unknown Object (Diffusion Commit) | |
| Unknown Object (Diffusion Commit) | |
| Unknown Object (Diffusion Commit) |
Related Objects
Related Objects
Event Timeline
Comment Actions
@Jdlrobson, I don't think the overall timing needs to changed necessarily, can we start with just adjusting easing? perhaps easeInOutBack
Comment Actions
Change 182108 had a related patch set uploaded (by Jdlrobson):
Change navigation easing function
Comment Actions
@Jaredzimmerman-WMF, is my implementation good enough? Please see a comment from Jon in gerrit.
Comment Actions
Yeah, sorry I don't have a dev env. set up on my machine, if I can test on a beta server somewhere that would be ideal, thanks!
Comment Actions
@Jaredzimmerman-WMF, I've shared a screencast with you (via youtube). If you want to try it live I'll set up a local tunnel at a time suitable for you.
Comment Actions
The video would be likely fine but it's private. So I can't view it.
Sent from my iPad
Comment Actions
@bmansurov looks good on the left drawer, but it feels a little spastic on the right when you see the left drawer for a second, I guess this is due to the right drawer being white, and you not seeing the background initially?
Comment Actions
@Jaredzimmerman-WMF the effect is applied to the page center but it gives an impression as though drawers are being animated. In fact the left drawer is always on the page and it's covered by the page center (body). So when we animate the right drawer, the page uncovers part of the left drawer.
Comment Actions
reopening because the current animation has "Spring" action to it. it does not go with the image of Wikipedia. We use damped ease-in and ease-out for position animations. Drawers should use the same.
Comment Actions
Change 282407 had a related patch set uploaded (by Bmansurov):
Change the drawer animation type
This comment was removed by Jdlrobson.
Comment Actions
(@MBinder_WMF Actually not sure how it works if something in sprint 71 was done during sprint 70 - I suspect we move it into sprint 70 and add unplanned sprint work?)
Comment Actions
@Jdlrobson Yes, I would say the current sprint should be tagged with work that we are doing/have done, and if it was unexpected work then it gets Unplanned-Sprint-Work :)