Page MenuHomePhabricator

OOUIHTMLForm should use PanelLayout for sections
Closed, ResolvedPublic

Description

While doing T117752, I'll discovered, that the section parameter of HTMLForm doesn't use PanelLayout in OOUIHTMLForm, which results in the following output:

OOUIHTMLForm should probably use PanelLayout elements for sections.

Event Timeline

Florian created this task.Nov 4 2015, 5:54 PM
Florian raised the priority of this task from to Medium.
Florian updated the task description. (Show Details)
Florian added subscribers: Florian, Paladox, Aklapper and 4 others.

Yeah, the OOUI version of HTMLForm doesn't really handle sections. As I remember, I discovered that the code for this is just really gnarly, and decided that it's used rarely enough that a better implementation can wait until we actually need it. :)

Florian claimed this task.Nov 4 2015, 6:13 PM

Yeah, I remember that point in your one of your many changes to OOUIHTMLForm :P

I looked into it and it would be relatively easy to achieve, as far as I haven't missed a very important point :P Let me upload a change to gerrit so we can look into it, ok? :)

Change 251012 had a related patch set uploaded (by Florianschmidtwelzow):
Implement section support for OOUIHTMLForm

https://gerrit.wikimedia.org/r/251012

Change 251012 merged by jenkins-bot:
Implement section support for OOUIHTMLForm

https://gerrit.wikimedia.org/r/251012

Florian closed this task as Resolved.Nov 6 2015, 1:07 PM