Maniphest T118898

"TypeError: can't convert undefined to object" apperas when I delete all the co-ordinates from Data section of the Graph editor and cannot open any other inspector after that
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Ryasmeen
	Nov 17 2015, 7:49 PM

Tags

Referenced Files

	F2970376: Screen Shot 2015-11-17 at 11.45.16 AM.png
	Nov 17 2015, 7:49 PM

Subscribers

Description

Steps to reproduce:

1.Open Graph editor from VE
2.Go to the tab "Data"
3.Delete all the (X,Y) pairs
4.Insert it

Observed Results:
There is a graph node with no index points on any axis. Error in the console:
"TypeError: can't convert undefined to object"

Screen Shot 2015-11-17 at 11.45.16 AM.png (748×1 px, 276 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Handle empty datasets in graphs	mediawiki/extensions/Graph	master	+45 -9

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• ferdbold	T119233 [Objective] It's easier to create and edit charts from within VisualEditor
		Resolved		• ferdbold	T118898 "TypeError: can't convert undefined to object" apperas when I delete all the co-ordinates from Data section of the Graph editor and cannot open any other inspector after that

Event Timeline

Ryasmeen created this task.Nov 17 2015, 7:49 PM

Ryasmeen raised the priority of this task from to Needs Triage.

Ryasmeen updated the task description. (Show Details)

Ryasmeen added a project: VisualEditor.

Ryasmeen subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 17 2015, 7:49 PM

Ryasmeen added a project: Graph-VisualEditor.Nov 17 2015, 7:49 PM

Ryasmeen set Security to None.

• ferdbold triaged this task as High priority.Nov 17 2015, 8:05 PM

Change 253777 had a related patch set uploaded (by Ferdbold):
Handle empty datasets in graphs

https://gerrit.wikimedia.org/r/253777

gerritbot added a project: Patch-For-Review.Nov 17 2015, 11:01 PM

• ferdbold moved this task from Backlog to For review on the Graph-VisualEditor board.Nov 17 2015, 11:18 PM

Jdforrester-WMF assigned this task to • ferdbold.Nov 18 2015, 9:19 PM

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.

Jdforrester-WMF added a parent task: T119233: [Objective] It's easier to create and edit charts from within VisualEditor.Nov 20 2015, 8:01 PM

Jdforrester-WMF added a project: MediaWiki-extensions-Graph.Nov 20 2015, 8:04 PM

Yurik moved this task from Backlog to VisualEditor on the MediaWiki-extensions-Graph board.Nov 25 2015, 9:13 PM

Jdforrester-WMF added subtasks: T119261: While using the resize handler on a graph, the lowest limit for resizing is 60x60px, but not when resizing from dialog, T109629: Edit graph colors in VisualEditor.Dec 3 2015, 6:12 PM

Jdforrester-WMF removed subtasks: T109629: Edit graph colors in VisualEditor, T119261: While using the resize handler on a graph, the lowest limit for resizing is 60x60px, but not when resizing from dialog.

Change 253777 merged by jenkins-bot:
Handle empty datasets in graphs

https://gerrit.wikimedia.org/r/253777

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Jan 26 2016, 7:00 PM

Jdforrester-WMF closed this task as Resolved.Jan 26 2016, 7:39 PM

Jdforrester-WMF removed a project: Patch-For-Review.